Implementation of Wishart distribution#68588
Closed
nonconvexopt wants to merge 188 commits intopytorch:masterfrom
Closed
Implementation of Wishart distribution#68588nonconvexopt wants to merge 188 commits intopytorch:masterfrom
nonconvexopt wants to merge 188 commits intopytorch:masterfrom
Conversation
CI Flow Status⚛️ CI FlowRuleset - Version:
You can add a comment to the PR and tag @pytorchbot with the following commands: # ciflow rerun, "ciflow/default" will always be added automatically
@pytorchbot ciflow rerun
# ciflow rerun with additional labels "-l <ciflow/label_name>", which is equivalent to adding these labels manually and trigger the rerun
@pytorchbot ciflow rerun -l ciflow/scheduled -l ciflow/slowFor more information, please take a look at the CI Flow Wiki. |
Contributor
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit d08a1fa (more details on the Dr. CI page):
🕵️ 18 new failures recognized by patternsThe following CI failures do not appear to be due to upstream breakages:
|
| Job | Step | Action |
|---|---|---|
| Unknown | 🔁 rerun | |
| Unknown | 🔁 rerun | |
| Unknown | 🔁 rerun | |
| Unknown | 🔁 rerun | |
| Unknown | 🔁 rerun | |
| Unknown | 🔁 rerun | |
| Unknown | 🔁 rerun | |
| Unknown | 🔁 rerun | |
| Unknown | 🔁 rerun |
❄️ 1 failure tentatively classified as flaky
but reruns have not yet been triggered to confirm:
periodic-linux-xenial-cuda10.2-py3-gcc7-slow-gradcheck / test (default, 2, 2, linux.4xlarge.nvidia.gpu) (1/1)
Step: "Unknown" (full log | diagnosis details | 🔁 rerun) ❄️
2021-12-24T01:22:49.0857291Z ConnectionResetError: [Errno 104] Connection reset by peer
2021-12-24T01:22:49.0848104Z File "/opt/conda/lib/python3.6/multiprocessing/connection.py", line 455, in accept
2021-12-24T01:22:49.0849099Z deliver_challenge(c, self._authkey)
2021-12-24T01:22:49.0850086Z File "/opt/conda/lib/python3.6/multiprocessing/connection.py", line 722, in deliver_challenge
2021-12-24T01:22:49.0851292Z response = connection.recv_bytes(256) # reject large message
2021-12-24T01:22:49.0852209Z File "/opt/conda/lib/python3.6/multiprocessing/connection.py", line 216, in recv_bytes
2021-12-24T01:22:49.0853206Z buf = self._recv_bytes(maxlength)
2021-12-24T01:22:49.0853993Z File "/opt/conda/lib/python3.6/multiprocessing/connection.py", line 407, in _recv_bytes
2021-12-24T01:22:49.0854915Z buf = self._recv(4)
2021-12-24T01:22:49.0855620Z File "/opt/conda/lib/python3.6/multiprocessing/connection.py", line 379, in _recv
2021-12-24T01:22:49.0856576Z chunk = read(handle, remaining)
2021-12-24T01:22:49.0857291Z ConnectionResetError: [Errno 104] Connection reset by peer
2021-12-24T01:22:54.1845269Z /opt/conda/lib/python3.6/multiprocessing/semaphore_tracker.py:143: UserWarning: semaphore_tracker: There appear to be 14 leaked semaphores to clean up at shutdown
2021-12-24T01:22:54.1846341Z len(cache))
2021-12-24T01:22:57.8440000Z Process ErrorTrackingProcess-88:
2021-12-24T01:22:57.8440816Z Traceback (most recent call last):
2021-12-24T01:22:57.8441584Z File "/opt/conda/lib/python3.6/multiprocessing/process.py", line 258, in _bootstrap
2021-12-24T01:22:57.8442608Z self.run()
2021-12-24T01:22:57.8443697Z File "/var/lib/jenkins/workspace/test/test_dataloader.py", line 406, in run
2021-12-24T01:22:57.8444514Z super(ErrorTrackingProcess, self).run()
2021-12-24T01:22:57.8445347Z File "/opt/conda/lib/python3.6/multiprocessing/process.py", line 93, in run
2021-12-24T01:22:57.8446076Z self._target(*self._args, **self._kwargs)
🚧 5 fixed upstream failures:
These were probably caused by upstream breakages that were already fixed.
Please rebase on the viable/strict branch (expand for instructions)
If your commit is older than viable/strict, run these commands:
git fetch https://github.com/pytorch/pytorch viable/strict
git rebase FETCH_HEAD
- linux-docs / build-docs (cpp) on Dec 18 from 12:00am to 11:42pm (94abf12 - b331752)
- win-vs2019-cuda11.3-py3 / test (default, 2, 2, windows.8xlarge.nvidia.gpu) on Dec 18 from 12:00am to 5:54pm (94abf12 - 94abf12)
- linux-xenial-py3.6-clang7-asan / test (default, 1, 3, linux.2xlarge) from Dec 17 until Dec 18 (6a97d0b - 5db711f)
- periodic-win-vs2019-cuda11.5-py3 / test (default, 2, 2, windows.8xlarge.nvidia.gpu) on Dec 18 from 12:00am to 5:54pm (94abf12 - 94abf12)
- linux-docs-push / build-docs (cpp) on Dec 18 from 12:00am to 11:42pm (94abf12 - b331752)
This comment was automatically generated by Dr. CI (expand for details).
Please report bugs/suggestions to the (internal) Dr. CI Users group.
Contributor
|
@neerajprad has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
neerajprad
reviewed
Dec 21, 2021
Contributor
neerajprad
left a comment
There was a problem hiding this comment.
I didn't notice that you merged your df changes in this PR, just had some small comments regarding that. We should also add a float df value to the unit tests.
Contributor
Author
Thank you for your feedback. I will add unit test for float |
neerajprad
reviewed
Dec 21, 2021
neerajprad
approved these changes
Dec 21, 2021
Contributor
|
@neerajprad has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
3 tasks
Contributor
|
This pull request has been reverted by 6217fee. To re-land this change, follow these steps. |
Contributor
|
@nonconvexopt - Could you reopen the original PR? This was reverted by mistake due to an unrelated reason. |
Contributor
Author
Sure, I will reopen it. *EDIT: |
Contributor
Author
|
@neerajprad May I open a new PR with same branch? |
Contributor
That's fine, we can open a new one instead. |
Contributor
Author
Thanks for letting me know. I will open a new one. |
3 tasks
facebook-github-bot
pushed a commit
that referenced
this pull request
Dec 30, 2021
Summary: Implement #68050 Reopened merged and reverted PR #68588 worked with neerajprad cc neerajprad Sorry for the confusion. TODO: - [x] Unit Test - [x] Documentation - [x] Change constraint of matrix variables with 'torch.distributions.constraints.symmetric' if it is reviewed and merged. Debug positive definite constraints #68720 Pull Request resolved: #70377 Reviewed By: mikaylagawarecki Differential Revision: D33355132 Pulled By: neerajprad fbshipit-source-id: e968c0d9a3061fb2855564b96074235e46a57b6c
wconstab
pushed a commit
that referenced
this pull request
Jan 5, 2022
Summary: Implement #68050 Reopened merged and reverted PR #68588 worked with neerajprad cc neerajprad Sorry for the confusion. TODO: - [x] Unit Test - [x] Documentation - [x] Change constraint of matrix variables with 'torch.distributions.constraints.symmetric' if it is reviewed and merged. Debug positive definite constraints #68720 Pull Request resolved: #70377 Reviewed By: mikaylagawarecki Differential Revision: D33355132 Pulled By: neerajprad fbshipit-source-id: e968c0d9a3061fb2855564b96074235e46a57b6c
Contributor
|
This pull request has been reverted by 6217fee. To re-land this change, follow these steps. |
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 25, 2026
Summary: Fixes pytorch#68050 TODO: - [x] Unit Test - [x] Documentation - [x] Change constraint of matrix variables with 'torch.distributions.constraints.symmetric' if it is reviewed and merged. pytorch#68720 Pull Request resolved: pytorch#68588 Reviewed By: bdhirsh Differential Revision: D33246843 Pulled By: neerajprad fbshipit-source-id: 825fcddf478555235e7a66de0c18368c41e935cd
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 25, 2026
Summary: Implement pytorch#68050 Reopened merged and reverted PR pytorch#68588 worked with neerajprad cc neerajprad Sorry for the confusion. TODO: - [x] Unit Test - [x] Documentation - [x] Change constraint of matrix variables with 'torch.distributions.constraints.symmetric' if it is reviewed and merged. Debug positive definite constraints pytorch#68720 Pull Request resolved: pytorch#70377 Reviewed By: mikaylagawarecki Differential Revision: D33355132 Pulled By: neerajprad fbshipit-source-id: e968c0d9a3061fb2855564b96074235e46a57b6c
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #68050
TODO: