OpInfo : nn.functional.embedding#66997
Closed
kshitij12345 wants to merge 7 commits intopytorch:masterfrom
Closed
Conversation
CI Flow Status⚛️ CI FlowRuleset - Version:
You can add a comment to the PR and tag @pytorchbot with the following commands: # ciflow rerun, "ciflow/default" will always be added automatically
@pytorchbot ciflow rerun
# ciflow rerun with additional labels "-l <ciflow/label_name>", which is equivalent to adding these labels manually and trigger the rerun
@pytorchbot ciflow rerun -l ciflow/scheduled -l ciflow/slowFor more information, please take a look at the CI Flow Wiki. |
Contributor
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit e5af0ea (more details on the Dr. CI page):
ci.pytorch.org: 1 failedThis comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
Contributor
|
@kshitij12345 do we have an idea of why the previous test was failing? |
Collaborator
Author
|
See #67084 |
Collaborator
Author
Not really sure at this point. I built locally with CUDA 11.3 but it worked fine. |
Contributor
|
Interesting, thank you for the context. Something definitely sounds fishy there, but we shouldn't let it block the merge for this. |
zou3519
approved these changes
Oct 22, 2021
Contributor
|
@zou3519 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 25, 2021
Summary: Adds OpInfo for `nn.functional.embedding` Pull Request resolved: #66997 Reviewed By: mrshenli Differential Revision: D31859799 Pulled By: zou3519 fbshipit-source-id: bbca860df4fbc243751f5fa81658231866c31d2e
This was referenced Oct 25, 2021
langong347
pushed a commit
that referenced
this pull request
Oct 25, 2021
Summary: Adds OpInfo for `nn.functional.embedding` Pull Request resolved: #66997 Reviewed By: mrshenli Differential Revision: D31859799 Pulled By: zou3519 fbshipit-source-id: bbca860df4fbc243751f5fa81658231866c31d2e
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds OpInfo for
nn.functional.embedding