Added validation of mode parameter in AveragedModel#65921
Added validation of mode parameter in AveragedModel#65921prabhat00155 wants to merge 5 commits intopytorch:masterfrom
Conversation
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 2f43bee (more details on the Dr. CI page):
🕵️ 1 new failure recognized by patternsThe following CI failures do not appear to be due to upstream breakages:
|
| Job | Step | Action |
|---|---|---|
| Run mypy | 🔁 rerun |
🚧 4 fixed upstream failures:
These were probably caused by upstream breakages that were already fixed.
Please rebase on the viable/strict branch (expand for instructions)
If your commit is older than viable/strict, run these commands:
git fetch https://github.com/pytorch/pytorch viable/strict
git rebase FETCH_HEAD
- linux-bionic-py3.6-clang9 / build on Oct 01 from 3:19am to 6:29am (c27b427 - e3af4be)
- linux-xenial-cuda11.3-py3.6-gcc7 / build on Oct 01 from 3:19am to 6:29am (c27b427 - e3af4be)
- linux-xenial-py3.6-clang7-asan / build on Oct 01 from 3:19am to 6:29am (c27b427 - e3af4be)
- linux-xenial-py3.6-gcc5.4 / build on Oct 01 from 3:19am to 6:29am (c27b427 - e3af4be)
This comment was automatically generated by Dr. CI (expand for details).
Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group.
|
@prabhat00155 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
1 similar comment
|
@prabhat00155 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
datumbox
left a comment
There was a problem hiding this comment.
Some minor comments on documentation:
Co-authored-by: Vasilis Vryniotis <datumbox@users.noreply.github.com>
Co-authored-by: Vasilis Vryniotis <datumbox@users.noreply.github.com>
|
@prabhat00155 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
albanD
left a comment
There was a problem hiding this comment.
LGTM Thanks for the update
|
@prabhat00155 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Summary: Discussion: pytorch#65495 (comment) Pull Request resolved: pytorch#65921 Reviewed By: albanD Differential Revision: D31310105 Pulled By: prabhat00155 fbshipit-source-id: 417691832a7c793744830c11e0ce53e3972d21a3 (cherry picked from commit c7748fc)
…65495) (#65755) * Added option to update parameters using state_dict in AveragedModel (#65495) Summary: While implementing [EMA](pytorch/vision#4381 extends AveragedModel) in torchvision, update_parameters() from AveragedModel could not be used as it did not handle state_dict(), so a custom update_parameters() needed to be defined in [EMA class](pytorch/vision#4406). This PR aims to handle this scenario removing the need for this custom update_parameters() implementation. Discussion: pytorch/vision#4406 (review) Pull Request resolved: #65495 Reviewed By: datumbox Differential Revision: D31176742 Pulled By: prabhat00155 fbshipit-source-id: 326d14876018f21cf602bab5eaba344678dbabe2 (cherry picked from commit 2ea724b) * Added validation of mode parameter in AveragedModel (#65921) Summary: Discussion: #65495 (comment) Pull Request resolved: #65921 Reviewed By: albanD Differential Revision: D31310105 Pulled By: prabhat00155 fbshipit-source-id: 417691832a7c793744830c11e0ce53e3972d21a3 (cherry picked from commit c7748fc)
Discussion: #65495 (comment)