[PyTorch Edge] Revert copying of opname in Function::append_operator#65172
Closed
salilsdesai wants to merge 1 commit intopytorch:masterfrom
Closed
[PyTorch Edge] Revert copying of opname in Function::append_operator#65172salilsdesai wants to merge 1 commit intopytorch:masterfrom
salilsdesai wants to merge 1 commit intopytorch:masterfrom
Conversation
Contributor
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 9866bc1 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D31004499 |
1 similar comment
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D31004499 |
7069282 to
0968d3e
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D31004499 |
0968d3e to
8661b9c
Compare
Codecov Report
@@ Coverage Diff @@
## master #65172 +/- ##
==========================================
- Coverage 66.48% 66.47% -0.02%
==========================================
Files 735 735
Lines 93855 93855
==========================================
- Hits 62403 62393 -10
- Misses 31452 31462 +10 |
…ytorch#65172) Summary: Pull Request resolved: pytorch#65172 Based on discussion here: https://www.internalfb.com/diff/D30615710 (pytorch@3727baea6f181f35ed83772abb960ba264d50f12)?dst_version_fbid=182906743925901&transaction_fbid=2132434103575494 This copying change should not have been made in pytorch#64269, so we're reverting it. Test Plan: Phabricator Tests Reviewed By: dhruvbird Differential Revision: D31004499 fbshipit-source-id: f4d63afaa93f11ba9b5a48e48531aa0e6fb373de
8661b9c to
9866bc1
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D31004499 |
Contributor
Author
|
this change is no longer needed after #64816 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Based on discussion here:
https://www.internalfb.com/diff/D30615710 (3727baea6f181f35ed83772abb960ba264d50f12)?dst_version_fbid=182906743925901&transaction_fbid=2132434103575494
Test Plan: Phabricator Tests
Differential Revision: D31004499