Skip to content

[reland] OpInfo: adaptive_avg_pool2d#62935

Closed
krshrimali wants to merge 5 commits intopytorch:masterfrom
krshrimali:opinfo/high_priority/nn/functional/adaptive_avg_pool2d
Closed

[reland] OpInfo: adaptive_avg_pool2d#62935
krshrimali wants to merge 5 commits intopytorch:masterfrom
krshrimali:opinfo/high_priority/nn/functional/adaptive_avg_pool2d

Conversation

@krshrimali
Copy link
Contributor

@krshrimali krshrimali commented Aug 7, 2021 •
edited
Loading

This PR is an attempt to reland #62704.

What has changed?

The op has non-deterministic behavior, hence an appropriate gradcheck wrapper had to be added.

cc: @mruberry @zou3519 @heitorschueroff @kshitij12345

@krshrimali krshrimali marked this pull request as draft August 7, 2021 05:51
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Aug 7, 2021 •
edited
Loading

🔗 Helpful links

💊 CI failures summary and remediations

As of commit 508a447 (more details on the Dr. CI page):

✅ None of the CI failures appear to be your fault 💚

❄️ 1 failure tentatively classified as flaky

but reruns have not yet been triggered to confirm:

See CircleCI build pytorch_linux_xenial_cuda11_1_cudnn8_py3_gcc7_test2 (1/1)

Step: "Run tests" (full log | diagnosis details | 🔁 rerun) ❄️

Aug 07 08:41:17 unknown file: Failure 
Aug 07 08:41:17 frame #9: build/bin/test_api() [0xbdb39a]
Aug 07 08:41:17 frame #10: build/bin/test_api() [0xbdbbed]
Aug 07 08:41:17 frame #11: testing::internal::UnitTestImpl::RunAllTests() + 0xe27 (0xbe47b7 in build/bin/test_api)
Aug 07 08:41:17 frame #12: testing::UnitTest::Run() + 0x8f (0xbe4b6f in build/bin/test_api)
Aug 07 08:41:17 frame #13: main + 0xc8 (0x586cb8 in build/bin/test_api)
Aug 07 08:41:17 frame #14: __libc_start_main + 0xf0 (0x7fa8571a2840 in /lib/x86_64-linux-gnu/libc.so.6)
Aug 07 08:41:17 frame #15: _start + 0x29 (0x5c7b29 in build/bin/test_api)
Aug 07 08:41:17 " thrown in the test body.
Aug 07 08:41:17 [  FAILED  ] IMethodTest.CallMethod (4 ms)
Aug 07 08:41:17 [ RUN      ] IMethodTest.GetArgumentNames
Aug 07 08:41:17 unknown file: Failure
Aug 07 08:41:17 C++ exception with description "open file failed, file path: torch/csrc/deploy/example/generated/simple_jit
Aug 07 08:41:17 Exception raised from RAIIFile at /var/lib/jenkins/workspace/caffe2/serialize/file_adapter.cc:13 (most recent call first):
Aug 07 08:41:17 frame #0: c10::Error::Error(c10::SourceLocation, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >) + 0x6b (0x7fa8578b84ab in /var/lib/jenkins/workspace/build/lib/libc10.so)
Aug 07 08:41:17 frame #1: c10::detail::torchCheckFail(char const*, char const*, unsigned int, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) + 0xce (0x7fa8578b3c6e in /var/lib/jenkins/workspace/build/lib/libc10.so)
Aug 07 08:41:17 frame #2: caffe2::serialize::FileAdapter::RAIIFile::RAIIFile(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) + 0xdc (0x7fa873abc03c in /var/lib/jenkins/workspace/build/lib/libtorch_cpu.so)
Aug 07 08:41:17 frame #3: caffe2::serialize::FileAdapter::FileAdapter(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) + 0x41 (0x7fa873abc6c1 in /var/lib/jenkins/workspace/build/lib/libtorch_cpu.so)
Aug 07 08:41:17 frame #4: torch::jit::load(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, c10::optional<c10::Device>, std::unordered_map<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::hash<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::equal_to<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::allocator<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > > >&) + 0x40 (0x7fa875117370 in /var/lib/jenkins/workspace/build/lib/libtorch_cpu.so)
Aug 07 08:41:17 frame #5: torch::jit::load(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, c10::optional<c10::Device>) + 0x6f (0x7fa8751174ff in /var/lib/jenkins/workspace/build/lib/libtorch_cpu.so)
Aug 07 08:41:17 frame #6: IMethodTest_GetArgumentNames_Test::TestBody() + 0x7e (0xb9f5be in build/bin/test_api)
Aug 07 08:41:17 frame #7: void testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) + 0x4a (0xbebafa in build/bin/test_api)
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@krshrimali krshrimali requested a review from kshitij12345 August 9, 2021 07:00
kshitij12345
kshitij12345 approved these changes Aug 9, 2021
View reviewed changes
Copy link
Collaborator

@kshitij12345 kshitij12345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @krshrimali

@krshrimali krshrimali marked this pull request as ready for review August 9, 2021 07:49
@krshrimali krshrimali requested a review from zou3519 August 9, 2021 09:15
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Aug 10, 2021

@zou3519 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Aug 12, 2021

@zou3519 merged this pull request in aac3c7b.

alanwaketan pushed a commit that referenced this pull request Aug 17, 2021
@krshrimali @alanwaketan
[reland] OpInfo: adaptive_avg_pool2d (#62935)
f6ae5db 
Summary:
This PR is an attempt to reland #62704.

**What has changed?**

The op has non-deterministic behavior, hence an appropriate `gradcheck` wrapper had to be added.

cc: mruberry zou3519 heitorschueroff kshitij12345

Pull Request resolved: #62935

Reviewed By: anjali411

Differential Revision: D30225095

Pulled By: zou3519

fbshipit-source-id: 644873cc21d44b19c8b68f9edff691913778de0e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zou3519 zou3519 zou3519 approved these changes

@kshitij12345 kshitij12345 kshitij12345 approved these changes

Assignees

No one assigned

Labels

cla signed Merged open source

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@krshrimali @facebook-github-bot @zou3519 @kshitij12345 @pytorchbot