[BE] fix bc check#62687
Conversation
1. remove duplicate regex compile 2. make use of the schema string
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit ae683a4 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
0d217a1 to
ae683a4
Compare
|
@walterddr has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
zhouzhuojie
left a comment
There was a problem hiding this comment.
LGTM, also added to the [BE] fix column of the board.
|
Also fyi, there's a PR #61973 that's going to port BC checks from circleci to GHA, and also make it check at the PR time. |
|
@walterddr has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
I think it is already ran on PR from circleci side. so it should be covered |
|
@walterddr merged this pull request in de77c6a. |
Summary: a bug was discovered in pytorch#62434, for some reason comparing the schema name didn't match the allow_list item. So: 1. remove duplicate regex compile 2. make use of the schema string is used instead of just the name Pull Request resolved: pytorch#62687 Reviewed By: ezyang Differential Revision: D30102437 Pulled By: walterddr fbshipit-source-id: 541b2ed77948f24daebb08623cadabb034a241e0
Summary: fix pytorch#62687 error. should allow listed those that has date time newer than today. Pull Request resolved: pytorch#62901 Reviewed By: zhouzhuojie Differential Revision: D30163202 Pulled By: walterddr fbshipit-source-id: b882975a231249137cb2d252f41e98e133b6f337
a bug was discovered in #62434, for some reason comparing the schema name didn't match the allow_list item. So: