OpInfo for `torch.nn.functional.normalize` by krshrimali · Pull Request #62635 · pytorch/pytorch

krshrimali · 2021-08-03T04:48:55Z

See pytorch/functorch#78 and #54261

cc: @mruberry @zou3519 @Chillee

facebook-github-bot · 2021-08-03T04:49:01Z

🔗 Helpful links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/62635
📄 Preview docs built from this PR

💊 CI failures summary and remediations

As of commit 4c7d80d (more details on the Dr. CI page):

✅ None of the CI failures appear to be your fault 💚

1/1 tentatively recognized as flaky ❄️
- Click here to rerun these jobs

❄️ 1 failure tentatively classified as flaky

but reruns have not yet been triggered to confirm:

pytorch_linux_bionic_cuda10_2_cudnn7_py3_9_gcc7_test1 (1/1)

Step: "Set Up CI Environment After attach_workspace" (full log | diagnosis details | 🔁 rerun) ❄️

E: Failed to fetch http://mirrors.ubuntu.com/mi...ubuntu.com:80 (91.189.89.32), connection timed out


0% [Working]
            
W: --force-yes is deprecated, use one of the options starting with --allow instead.
E: Failed to fetch mirror://mirrors.ubuntu.com/mirrors.txt/pool/main/t/tcl8.6/libtcl8.6_8.6.10+dfsg-1_amd64.deb  Downloading mirror file /var/lib/apt/lists/auxfiles/mirrors.ubuntu.com_mirrors.txt failed for mirror://mirrors.ubuntu.com/mirrors.txt/pool/main/t/tcl8.6/libtcl8.6_8.6.10+dfsg-1_amd64.deb
E: Failed to fetch mirror://mirrors.ubuntu.com/mirrors.txt/pool/main/t/tcl8.6/tcl8.6_8.6.10+dfsg-1_amd64.deb  Downloading mirror file /var/lib/apt/lists/auxfiles/mirrors.ubuntu.com_mirrors.txt failed for mirror://mirrors.ubuntu.com/mirrors.txt/pool/main/t/tcl8.6/tcl8.6_8.6.10+dfsg-1_amd64.deb
E: Failed to fetch mirror://mirrors.ubuntu.com/mirrors.txt/pool/universe/e/expect/tcl-expect_5.45.4-2build1_amd64.deb  Downloading mirror file /var/lib/apt/lists/auxfiles/mirrors.ubuntu.com_mirrors.txt failed for mirror://mirrors.ubuntu.com/mirrors.txt/pool/universe/e/expect/tcl-expect_5.45.4-2build1_amd64.deb
E: Failed to fetch mirror://mirrors.ubuntu.com/mirrors.txt/pool/universe/e/expect/expect_5.45.4-2build1_amd64.deb  Downloading mirror file /var/lib/apt/lists/auxfiles/mirrors.ubuntu.com_mirrors.txt failed for mirror://mirrors.ubuntu.com/mirrors.txt/pool/universe/e/expect/expect_5.45.4-2build1_amd64.deb
E: Failed to fetch mirror://mirrors.ubuntu.com/mirrors.txt/pool/main/libi/libio-pty-perl/libio-pty-perl_1.12-1_amd64.deb  Downloading mirror file /var/lib/apt/lists/auxfiles/mirrors.ubuntu.com_mirrors.txt failed for mirror://mirrors.ubuntu.com/mirrors.txt/pool/main/libi/libio-pty-perl/libio-pty-perl_1.12-1_amd64.deb
E: Failed to fetch mirror://mirrors.ubuntu.com/mirrors.txt/pool/main/libi/libipc-run-perl/libipc-run-perl_20180523.0-2_all.deb  Downloading mirror file /var/lib/apt/lists/auxfiles/mirrors.ubuntu.com_mirrors.txt failed for mirror://mirrors.ubuntu.com/mirrors.txt/pool/main/libi/libipc-run-perl/libipc-run-perl_20180523.0-2_all.deb
E: Failed to fetch mirror://mirrors.ubuntu.com/mirrors.txt/pool/universe/libt/libtime-duration-perl/libtime-duration-perl_1.21-1_all.deb  Downloading mirror file /var/lib/apt/lists/auxfiles/mirrors.ubuntu.com_mirrors.txt failed for mirror://mirrors.ubuntu.com/mirrors.txt/pool/universe/libt/libtime-duration-perl/libtime-duration-perl_1.21-1_all.deb
E: Failed to fetch mirror://mirrors.ubuntu.com/mirrors.txt/pool/main/libt/libtimedate-perl/libtimedate-perl_2.3200-1_all.deb  Downloading mirror file /var/lib/apt/lists/auxfiles/mirrors.ubuntu.com_mirrors.txt failed for mirror://mirrors.ubuntu.com/mirrors.txt/pool/main/libt/libtimedate-perl/libtimedate-perl_2.3200-1_all.deb
E: Failed to fetch mirror://mirrors.ubuntu.com/mirrors.txt/pool/universe/m/moreutils/moreutils_0.63-1_amd64.deb  Downloading mirror file /var/lib/apt/lists/auxfiles/mirrors.ubuntu.com_mirrors.txt failed for mirror://mirrors.ubuntu.com/mirrors.txt/pool/universe/m/moreutils/moreutils_0.63-1_amd64.deb
E: Failed to fetch http://mirrors.ubuntu.com/mirrors.txt  Could not connect to mirrors.ubuntu.com:80 (91.189.89.32), connection timed out
E: Unable to fetch some archives, maybe run apt-get update or try with --fix-missing?
+ sudo apt-get -y install moreutils expect-dev

Reading package lists... 0%

Reading package lists... 100%

Reading package lists... Done


Building dependency tree... 0%

Building dependency tree... 0%

Building dependency tree... 50%

Building dependency tree... 50%

Building dependency tree       


Reading state information... 0%

Reading state information... 0%

Reading state information... Done

Note, selecting 'expect' instead of 'expect-dev'
The following additional packages will be installed:
  libio-pty-perl libipc-run-perl libtcl8.6 libtime-duration-perl
  libtimedate-perl tcl-expect tcl8.6
Suggested packages:

This comment was automatically generated by Dr. CI (expand for details).

Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

torch/testing/_internal/common_methods_invocations.py

mruberry · 2021-08-03T04:52:08Z

torch/testing/_internal/common_methods_invocations.py

+               # RuntimeError: aliasOp != torch::jit::getOperatorAliasMap().end()
+               # INTERNAL ASSERT FAILED at "../torch/csrc/jit/passes/utils/check_alias_annotation.cpp":159,
+               # please report a bug to PyTorch.
+               SkipInfo('TestJit', 'test_variant_consistency_jit',),


cc @eellison

From what I understood so far, it's probably because normalize calls norm and torch.div (or / operator) in its definition:

pytorch/torch/nn/functional.py

Lines 4437 to 4441 in 88af4d8

denom = input.norm(p, dim, keepdim=True).clamp_min(eps).expand_as(input)

return input / denom

else:

denom = input.norm(p, dim, keepdim=True).clamp_min_(eps).expand_as(input)

return torch.div(input, denom, out=out)

Hence the graph created from:

pytorch/torch/testing/_internal/jit_metaprogramming_utils.py

Lines 488 to 491 in 88af4d8

torch._C._jit_pass_inline(CU.the_method.graph)

torch._C._jit_pass_constant_propagation(CU.the_method.graph)

torch._C._jit_check_alias_annotation(CU.the_method.graph, tuple(tensors), aten_name)

doesn't consist of aten::normalize but instead has the nodes for norm and div. This leads to continuing from the loop here (no if condition satisfied):

pytorch/torch/csrc/jit/passes/utils/check_alias_annotation.cpp

Lines 151 to 153 in 88af4d8

for (const auto node : g.nodes()) {

if (node->kind() == opName) {

return node;

And hence the final failure here:

pytorch/torch/csrc/jit/passes/utils/check_alias_annotation.cpp

Line 159 in 88af4d8

AT_ASSERT(aliasOp != torch::jit::getOperatorAliasMap().end());

Was just trying to see what's happening. :) In case it helps!

mruberry · 2021-08-03T04:52:38Z

@zou3519 would you make sure this covers the cases you need and shepherd this in?

…//github.com/krshrimali/pytorch into opinfo/high_priority/nn/functional/normalize

zou3519 · 2021-08-03T16:51:32Z

Yes, can do!

facebook-github-bot · 2021-08-05T17:33:30Z

@zou3519 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

zou3519 · 2021-08-06T14:46:01Z

@krshrimali could you rebase this please?

krshrimali · 2021-08-06T14:58:50Z

Thanks for the ping, @zou3519 - I've rebased the branch. Also removed supports_out=True since it's already set to True in the OpInfo class. Hope that's okay. Thanks for taking a look.

mruberry · 2021-08-12T04:29:55Z

ping @zou3519

zou3519 · 2021-08-12T16:27:29Z

Sorry, I missed this notification. @krshrimali could you please rebase this again? (it looks like there are merge conflicts)

krshrimali · 2021-08-12T16:37:53Z

Sorry, I missed this notification. @krshrimali could you please rebase this again? (it looks like there are merge conflicts)

Thanks, @zou3519 for taking a look. I understand, and I should have pinged again but I missed it as well. I have fixed the merge conflicts. :) Thanks again!

facebook-github-bot · 2021-08-12T17:28:49Z

@zou3519 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

facebook-github-bot · 2021-08-13T13:39:27Z

@zou3519 merged this pull request in dcb5eb8.

Summary: See pytorch/functorch#78 and #54261 cc: mruberry zou3519 Chillee Pull Request resolved: #62635 Reviewed By: H-Huang Differential Revision: D30136503 Pulled By: zou3519 fbshipit-source-id: 258c069f30d9c2a51ed27dadf94f3703b9432a4a

krshrimali added 2 commits August 3, 2021 04:19

OpInfo for nn.functional.normalize

4dccc84

Skip test_variant_consistency_jit

3ca9bff

facebook-github-bot added the cla signed label Aug 3, 2021

mruberry reviewed Aug 3, 2021

View reviewed changes

torch/testing/_internal/common_methods_invocations.py Outdated Show resolved Hide resolved

mruberry reviewed Aug 3, 2021

View reviewed changes

mruberry requested a review from zou3519 August 3, 2021 04:52

pytorchbot added the open source label Aug 3, 2021

krshrimali added 3 commits August 3, 2021 10:45

Bring the skip back...was removed by mistake

445fee3

Address review, minor addition to extra cases

c7a829b

Fix, aten::normalize isn't correct, don't test for positional args

f49280a

krshrimali added the module: testing Issues related to the torch.testing module (not tests) label Aug 3, 2021

iramazanli added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Aug 3, 2021

krshrimali added 2 commits August 3, 2021 11:31

Fix mypy failures

bd23409

Merge branch 'opinfo/high_priority/nn/functional/normalize' of https:…

e08d40c

…//github.com/krshrimali/pytorch into opinfo/high_priority/nn/functional/normalize

Merge branch 'master' into opinfo/high_priority/nn/functional/normalize

22c4e4f

zou3519 approved these changes Aug 5, 2021

View reviewed changes

krshrimali added 2 commits August 6, 2021 20:25

Fix merge conflict, rebase

f820dc9

supports_out is by default True, not needed here

cc8ab6f

krshrimali added 2 commits August 12, 2021 16:34

Fix merge conflict

8ac88cf

Remove adaptive_avg_pool2d since it was reverted

4c7d80d

facebook-github-bot closed this in dcb5eb8 Aug 13, 2021

facebook-github-bot added the Merged label Aug 13, 2021

zou3519 mentioned this pull request Aug 18, 2021

Top 25 OpInfos for functorch pytorch/functorch#78

Closed

23 tasks

	denom = input.norm(p, dim, keepdim=True).clamp_min(eps).expand_as(input)
	return input / denom
	else:
	denom = input.norm(p, dim, keepdim=True).clamp_min_(eps).expand_as(input)
	return torch.div(input, denom, out=out)

	torch._C._jit_pass_inline(CU.the_method.graph)
	torch._C._jit_pass_constant_propagation(CU.the_method.graph)
	torch._C._jit_check_alias_annotation(CU.the_method.graph, tuple(tensors), aten_name)

	for (const auto node : g.nodes()) {
	if (node->kind() == opName) {
	return node;

Conversation

krshrimali commented Aug 3, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

facebook-github-bot commented Aug 3, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful links

💊 CI failures summary and remediations

❄️ 1 failure tentatively classified as flaky

pytorch_linux_bionic_cuda10_2_cudnn7_py3_9_gcc7_test1 (1/1)

Uh oh!

Uh oh!

mruberry Aug 3, 2021

Choose a reason for hiding this comment

Uh oh!

krshrimali Aug 3, 2021

Choose a reason for hiding this comment

Uh oh!

mruberry commented Aug 3, 2021

Uh oh!

zou3519 commented Aug 3, 2021

Uh oh!

facebook-github-bot commented Aug 5, 2021

Uh oh!

zou3519 commented Aug 6, 2021

Uh oh!

krshrimali commented Aug 6, 2021

Uh oh!

mruberry commented Aug 12, 2021

Uh oh!

zou3519 commented Aug 12, 2021

Uh oh!

krshrimali commented Aug 12, 2021

Uh oh!

facebook-github-bot commented Aug 12, 2021

Uh oh!

facebook-github-bot commented Aug 13, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

krshrimali commented Aug 3, 2021 •

edited

Loading

facebook-github-bot commented Aug 3, 2021 •

edited

Loading