Release GIL as much as possible in dist_autograd pybind.#61593
Closed
pritamdamania87 wants to merge 1 commit intogh/pritamdamania87/249/basefrom
Closed
Release GIL as much as possible in dist_autograd pybind.#61593pritamdamania87 wants to merge 1 commit intogh/pritamdamania87/249/basefrom
pritamdamania87 wants to merge 1 commit intogh/pritamdamania87/249/basefrom
Conversation
Following the pattern in #61588 to avoid deadlocks as much as possible. Differential Revision: [D29683451](https://our.internmc.facebook.com/intern/diff/D29683451/) [ghstack-poisoned]
Contributor
💊 CI failures summary and remediationsAs of commit 1bb9e92 (more details on the Dr. CI page and at hud.pytorch.org/pr/61593):
❄️ 1 failure tentatively classified as flakybut reruns have not yet been triggered to confirm:
|
pritamdamania87
pushed a commit
that referenced
this pull request
Jul 13, 2021
Following the pattern in #61588 to avoid deadlocks as much as possible. Differential Revision: [D29683451](https://our.internmc.facebook.com/intern/diff/D29683451/) ghstack-source-id: 133497897 Pull Request resolved: #61593
rohan-varma
reviewed
Jul 14, 2021
Contributor
rohan-varma
left a comment
There was a problem hiding this comment.
I wonder if we've looked into building some tool/automatic analysis to detect these sort of issues? Currently seems pretty manual and easy to forget to release GIL when calling into pybind functions.
Also, do we know why our internal TSAN tests don't catch these sort of deadlocks (at least it seems like that to me)?
zhaojuanmao
approved these changes
Jul 14, 2021
Contributor
Author
|
@rohan-varma @ezyang pointed me to this: https://clang.llvm.org/docs/ThreadSafetyAnalysis.html, which does seem to be very useful. |
Contributor
|
This pull request has been merged in 7d2ea9a. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Following the pattern in #61588
to avoid deadlocks as much as possible.
Differential Revision: D29683451