Allow larger margin of error for GPU perf test runtime#6044
Merged
ezyang merged 1 commit intopytorch:masterfrom Mar 27, 2018
Merged
Allow larger margin of error for GPU perf test runtime#6044ezyang merged 1 commit intopytorch:masterfrom
ezyang merged 1 commit intopytorch:masterfrom
Conversation
Contributor
|
I'm a little confused what the long term plan is. Aren't we recording perf results, and planning to use that to track if regressions happen, instead of having a killswitch on the test itself? |
Contributor
Author
|
I think we might want to catch big regressions before the PR gets merged into master, and for small regressions added up due to margin of error, we will have a graph to track it and do something about it if it gets significantly out of hand? It's generally whether we should fix the regression before or after the merge, and I think the former might make more sense. However I think currently it's hard to find out where the regression actually happens in a perf test. The per-operator perf test might help with this once it's launched. |
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current margin of error for GPU perf test runtime is too small (only +-2%), which caused some of the tests to fail such as https://ci.pytorch.org/jenkins/job/pytorch-builds/job/short-perf-test-gpu/1492/console. This PR doubles the margin of error to +-4%.