Add additional script module functionality#6033
Merged
zdevito merged 3 commits intopytorch:masterfrom Mar 28, 2018
Merged
Conversation
apaszke
suggested changes
Mar 27, 2018
Contributor
apaszke
left a comment
There was a problem hiding this comment.
LGTM, but we also need a test that checks that non-script attributes can be changed, and that those changes are later visible in non-script methods (so e.g. change self.value in the first test, and later verify that it's no longer "hi")
apaszke
approved these changes
Mar 27, 2018
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
* allow calls to non-script methods, allow python non-script attributes in methods * add test to make sure submodules are not reassigned * Test that we can change python attributes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
self.submoduleright after__init__is called, script methods would never see the modification to the submodules, hence instead of supporting this case we need to specifically disallow it).Resolves 1--3 of #6015
Resolution order (4) is more complicated and will come in a later PR.