Reorganize third-party libraries into top-level third_party directory#6025
Reorganize third-party libraries into top-level third_party directory#6025ezyang merged 9 commits intopytorch:masterfrom
Conversation
Signed-off-by: Edward Z. Yang <ezyang@fb.com>
|
@pytorchbot retest this please |
|
why is THD going into third_party? it's our code |
|
I'm okay with the code change. But I think it should need a test. |
|
@soumith My bad, I just moved everything from |
|
Libshm is also our code |
|
@pytorchbot retest this please |
1 similar comment
|
@pytorchbot retest this please |
|
Dammit, somewhere between git 2.7.4 and git 2.13.5 they made merges involving submodules actually work XD |
|
@pytorchbot retest this please |
Signed-off-by: Edward Z. Yang <ezyang@fb.com>
Signed-off-by: Edward Z. Yang <ezyang@fb.com>
|
This is ready for merge. CI failure is gpu-perf-test being flaky. |
| @@ -1,10 +1,12 @@ | |||
| #!/usr/bin/env bash | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Signed-off-by: Edward Z. Yang <ezyang@fb.com>
…pytorch#6025) - gloo, pybind11, nanopb and nccl now live in third_party. - ATen builds in aten/build rather than torch/lib/build/aten - A bit of faffing about in the scripts was necessary, because they used to assume that everything lived in the same directory. Now you are expected to cd into the correct directory before calling one of the build functions. The actual builder script lives in tools - Lint now just unconditionally ignores third_party, rather than enumerating folders explicitly
third_party.aten/buildrather thantorch/lib/build/atenthird_party, rather than enumerating folders explicitlyPlease don't forget to squash on merge, and add this PR comment.
CC @peterjc123 @soumith
Signed-off-by: Edward Z. Yang ezyang@fb.com