Update FAQ to make more sense after tensor/variable merge#6017
Merged
soumith merged 1 commit intopytorch:masterfrom Mar 27, 2018
Merged
Update FAQ to make more sense after tensor/variable merge#6017soumith merged 1 commit intopytorch:masterfrom
soumith merged 1 commit intopytorch:masterfrom
Conversation
ezyang
approved these changes
Mar 26, 2018
Contributor
|
wiki applied |
apaszke
approved these changes
Mar 26, 2018
Contributor
apaszke
left a comment
There was a problem hiding this comment.
There's also loss.item(), but I think float(loss) is ok too
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looks like there's already a note about the
total_loss += losstrouble. I've updated it to make more sense after the tensor/variable merge.Also, GitHub doesn't allow pull requests for the wiki. Can someone please edit https://github.com/pytorch/pytorch/wiki/Breaking-Changes-from-Variable-and-Tensor-merge with something like
@ezyang @apaszke @soumith