Move Dockerfile to docker/pytorch#6009
Merged
soumith merged 1 commit intopytorch:masterfrom Mar 26, 2018
Merged
Conversation
Signed-off-by: Edward Z. Yang <ezyang@fb.com>
Contributor
|
Was this helpful? It seems to only have the effect of making building a docker image harder, since normally the contents of the directory where the Dockerfile is located (minus the contents referred to in .dockerignore) are sent to build the image. And the Dockerfile cannot refer to ../../ for building. |
Contributor
Author
|
@topiaruss Sorry about the inconvenience. The reason we moved it is because we'll be adding some new Docker images to the repo soon, and we didn't want to privilege one over any other one. I opened PR #6051 for how to build the Dockerfile in the new location; it is not too much more complicated, so I hope you'll bear with us :) |
Contributor
|
Perfect. Thank you!
On 27 Mar 2018, at 20:47, Edward Z. Yang ***@***.***> wrote:
@topiaruss <https://github.com/topiaruss> Sorry about the inconvenience. The reason we moved it is because we'll be adding some new Docker images to the repo soon, and we didn't want to privilege one over any other one. I opened PR #6051 <#6051> for how to build the Dockerfile in the new location; it is not too much more complicated, so I hope you'll bear with us :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#6009 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AALlWZ2mViescnDhIsV31GPg4yME3uysks5tipc5gaJpZM4S7wyP>.
Russ Ferriday -- Software Product Architect, Developer, Mentor
Founder & CTO Topia Systems Ltd
russ.ferriday@gmail.com -- +44 7429 518822
|
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
Signed-off-by: Edward Z. Yang <ezyang@fb.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CC @orionr
Signed-off-by: Edward Z. Yang ezyang@fb.com