Skip to content

Add precision matrix to MultivariateNormal#5998

Merged
ezyang merged 1 commit intopytorch:masterfrom
ssnl:precision
Mar 26, 2018
Merged

Add precision matrix to MultivariateNormal#5998
ezyang merged 1 commit intopytorch:masterfrom
ssnl:precision

Conversation

@ssnl
Copy link
Copy Markdown
Collaborator

@ssnl ssnl commented Mar 26, 2018

Also changed some .contiguous().view(*) to .reshape(*).

cc @fritzo

@onnxbot-worker-1 onnxbot-worker-1 mentioned this pull request Mar 26, 2018
Closed
vishwakftw
vishwakftw reviewed Mar 26, 2018
View reviewed changes
Comment thread torch/distributions/multivariate_normal.py Outdated

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

fritzo
fritzo reviewed Mar 26, 2018
View reviewed changes
Copy link
Copy Markdown
Collaborator

@fritzo fritzo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, looks very reasonable. Can you just confirm that .reshape() has the correct behavior for non-contiguous tensors (whose dimensions may have been permuted or sliced etc)? Note that we don't have tests for all the possible non-contiguous cases.

Comment thread torch/distributions/multivariate_normal.py Outdated

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

Comment thread torch/distributions/multivariate_normal.py Outdated

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

@ezyang ezyang merged commit cfd94c4 into pytorch:master Mar 26, 2018
@ssnl ssnl deleted the precision branch March 26, 2018 18:10
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 24, 2026
@ssnl @ezyang
Add precision matrix to MultivariateNormal (pytorch#5998)
a07051e 
Also changed some .contiguous().view(*) to .reshape(*).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fritzo fritzo fritzo left review comments

+1 more reviewer

@vishwakftw vishwakftw vishwakftw left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

open source

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ssnl @fritzo @vishwakftw @ezyang