move all external kernels into a class for better compiler error messages by bdhirsh · Pull Request #59839 · pytorch/pytorch

bdhirsh · 2021-06-10T23:26:08Z

Turns external backend kernels into class methods, so they get helpful compiler errors instead of linker errors whenever they're a schema mismatch.

I took a stab at trying to do the same for in-tree kernels, but gave up after a while. It would probably make sense to come back to it with @wenleix 's nice set of regex calls, to automatically pick up all of the native kernels in the aten/src/ATen/native folder.

Corresponding xla PR: pytorch/xla#3012

Stack from ghstack:

detect missing kernels from external backends in codegen #60737 detect missing kernels from external backends in codegen
move all external kernels into a class for better compiler error messages #59839 move all external kernels into a class for better compiler error messages

Differential Revision: D29047680

…ages [ghstack-poisoned]

facebook-github-bot · 2021-06-10T23:26:13Z

💊 CI failures summary and remediations

As of commit 47c1960 (more details on the Dr. CI page and at hud.pytorch.org/pr/59839):

2/3 failures possibly* introduced in this PR
- 1/2 non-scanned failure(s)
1/3 broken upstream at merge base 0d6f291 from Jun 09 until Jun 11

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

pytorch_xla_linux_bionic_py3_6_clang9_build (1/1)

Step: "Build" (full log | diagnosis details | 🔁 rerun)

Jul 06 19:40:58 /var/lib/jenkins/workspace/xla/...any arguments to function call, expected 2, have 3

Jul 06 19:40:58 clang++-9 -MMD -MF /var/lib/jenkins/workspace/xla/build/temp.linux-x86_64-3.6/torch_xla/csrc/aten_xla_type.o.d -Wsign-compare -DNDEBUG -g -fwrapv -O3 -Wall -Wstrict-prototypes -fPIC -I/var/lib/jenkins/workspace/xla -I/var/lib/jenkins/workspace/xla/third_party/tensorflow/bazel-tensorflow -I/var/lib/jenkins/workspace/xla/third_party/tensorflow/bazel-bin -I/var/lib/jenkins/workspace/xla/third_party/tensorflow/bazel-tensorflow/external/protobuf_archive/src -I/var/lib/jenkins/workspace/xla/third_party/tensorflow/bazel-tensorflow/external/com_google_protobuf/src -I/var/lib/jenkins/workspace/xla/third_party/tensorflow/bazel-tensorflow/external/eigen_archive -I/var/lib/jenkins/workspace/xla/third_party/tensorflow/bazel-tensorflow/external/com_google_absl -I/var/lib/jenkins/workspace -I/var/lib/jenkins/workspace/torch/csrc -I/var/lib/jenkins/workspace/torch/lib/tmp_install/include -I/opt/conda/lib/python3.6/site-packages/torch/include -I/opt/conda/lib/python3.6/site-packages/torch/include/torch/csrc/api/include -I/opt/conda/lib/python3.6/site-packages/torch/include/TH -I/opt/conda/lib/python3.6/site-packages/torch/include/THC -I/opt/conda/include/python3.6m -c -c /var/lib/jenkins/workspace/xla/torch_xla/csrc/aten_xla_type.cpp -o /var/lib/jenkins/workspace/xla/build/temp.linux-x86_64-3.6/torch_xla/csrc/aten_xla_type.o -std=c++14 -Wno-sign-compare -Wno-deprecated-declarations -Wno-return-type -Wno-macro-redefined -Wno-return-std-move -DNDEBUG -DTORCH_API_INCLUDE_EXTENSION_H '-DPYBIND11_COMPILER_TYPE="_clang"' '-DPYBIND11_STDLIB="_libstdcpp"' '-DPYBIND11_BUILD_ABI="_cxxabi1002"' -DTORCH_EXTENSION_NAME=_XLAC -D_GLIBCXX_USE_CXX11_ABI=1
Jul 06 19:40:58 /var/lib/jenkins/workspace/xla/torch_xla/csrc/aten_xla_type.cpp:395:21: error: no member named 'index_put_' in namespace 'torch_xla'
Jul 06 19:40:58   return torch_xla::index_put_(self, indices, values, accumulate);
Jul 06 19:40:58          ~~~~~~~~~~~^
Jul 06 19:40:58 /var/lib/jenkins/workspace/xla/torch_xla/csrc/aten_xla_type.cpp:455:10: error: use of undeclared identifier 'view'; did you mean 'View'?
Jul 06 19:40:58   return view(self, size);
Jul 06 19:40:58          ^
Jul 06 19:40:58 /var/lib/jenkins/workspace/xla/torch_xla/csrc/view.h:128:7: note: 'View' declared here
Jul 06 19:40:58 class View {
Jul 06 19:40:58       ^
Jul 06 19:40:58 /var/lib/jenkins/workspace/xla/torch_xla/csrc/aten_xla_type.cpp:1091:56: error: too many arguments to function call, expected 2, have 3
Jul 06 19:40:58   return torch_xla::div(self, other, /*rounding_mode=*/c10::nullopt);
Jul 06 19:40:58          ~~~~~~~~~~~~~~                                ^~~~~~~~~~~~
Jul 06 19:40:58 /var/lib/jenkins/workspace/xla/torch_xla/csrc/aten_xla_type.cpp:1090:1: note: 'div' declared here
Jul 06 19:40:58 at::Tensor div(const at::Tensor& self, const at::Tensor& other) {
Jul 06 19:40:58 ^
Jul 06 19:40:58 3 errors generated.
Jul 06 19:41:00 [19/171] clang++-9 -MMD -MF /var/lib/jenkins/workspace/xla/build/temp.linux-x86_64-3.6/torch_xla/csrc/init_python_bindings.o.d -Wsign-compare -DNDEBUG -g -fwrapv -O3 -Wall -Wstrict-prototypes -fPIC -I/var/lib/jenkins/workspace/xla -I/var/lib/jenkins/workspace/xla/third_party/tensorflow/bazel-tensorflow -I/var/lib/jenkins/workspace/xla/third_party/tensorflow/bazel-bin -I/var/lib/jenkins/workspace/xla/third_party/tensorflow/bazel-tensorflow/external/protobuf_archive/src -I/var/lib/jenkins/workspace/xla/third_party/tensorflow/bazel-tensorflow/external/com_google_protobuf/src -I/var/lib/jenkins/workspace/xla/third_party/tensorflow/bazel-tensorflow/external/eigen_archive -I/var/lib/jenkins/workspace/xla/third_party/tensorflow/bazel-tensorflow/external/com_google_absl -I/var/lib/jenkins/workspace -I/var/lib/jenkins/workspace/torch/csrc -I/var/lib/jenkins/workspace/torch/lib/tmp_install/include -I/opt/conda/lib/python3.6/site-packages/torch/include -I/opt/conda/lib/python3.6/site-packages/torch/include/torch/csrc/api/include -I/opt/conda/lib/python3.6/site-packages/torch/include/TH -I/opt/conda/lib/python3.6/site-packages/torch/include/THC -I/opt/conda/include/python3.6m -c -c /var/lib/jenkins/workspace/xla/torch_xla/csrc/init_python_bindings.cpp -o /var/lib/jenkins/workspace/xla/build/temp.linux-x86_64-3.6/torch_xla/csrc/init_python_bindings.o -std=c++14 -Wno-sign-compare -Wno-deprecated-declarations -Wno-return-type -Wno-macro-redefined -Wno-return-std-move -DNDEBUG -DTORCH_API_INCLUDE_EXTENSION_H '-DPYBIND11_COMPILER_TYPE="_clang"' '-DPYBIND11_STDLIB="_libstdcpp"' '-DPYBIND11_BUILD_ABI="_cxxabi1002"' -DTORCH_EXTENSION_NAME=_XLAC -D_GLIBCXX_USE_CXX11_ABI=1
Jul 06 19:41:00 In file included from /var/lib/jenkins/workspace/xla/torch_xla/csrc/init_python_bindings.cpp:35:
Jul 06 19:41:00 In file included from /var/lib/jenkins/workspace/torch/csrc/jit/python/pybind.h:8:
Jul 06 19:41:00 In file included from /var/lib/jenkins/workspace/torch/csrc/THP.h:42:

🚧 1 fixed upstream failure:

These were probably caused by upstream breakages that were already fixed.

Please rebase on the viable/strict branch (expand for instructions)

If your commit is older than viable/strict, run these commands:

git fetch https://github.com/pytorch/pytorch viable/strict
git rebase FETCH_HEAD

pytorch_linux_xenial_py3_clang5_asan_test2 from Jun 09 until Jun 11 (12b4e89 - b83ac0c)
- 🔁 rerun

Preview docs built from this PR

This comment was automatically generated by Dr. CI (expand for details).

Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

bdhirsh · 2021-06-10T23:34:35Z

@bdhirsh has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

… error messages" Differential Revision: [D29047680](https://our.internmc.facebook.com/intern/diff/D29047680) [ghstack-poisoned]

bdhirsh · 2021-06-11T00:51:23Z

@bdhirsh has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

… error messages" Differential Revision: [D29047680](https://our.internmc.facebook.com/intern/diff/D29047680) [ghstack-poisoned]

…ages Pull Request resolved: #59839 Differential Revision: [D29047615](https://our.internmc.facebook.com/intern/diff/D29047615/) ghstack-source-id: 131148089

… error messages" Differential Revision: [D29047680](https://our.internmc.facebook.com/intern/diff/D29047680) [ghstack-poisoned]

…ages ghstack-source-id: 8d64d20 Pull Request resolved: #59839

bdhirsh · 2021-06-11T15:14:49Z

@bdhirsh has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

… error messages" Differential Revision: [D29047680](https://our.internmc.facebook.com/intern/diff/D29047680) [ghstack-poisoned]

…ages ghstack-source-id: 88f511c Pull Request resolved: #59839

bdhirsh · 2021-06-11T21:43:41Z

@bdhirsh has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

… error messages" Differential Revision: [D29047680](https://our.internmc.facebook.com/intern/diff/D29047680) [ghstack-poisoned]

bdhirsh · 2021-06-14T14:08:23Z

@bdhirsh has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

… error messages" Differential Revision: [D29047680](https://our.internmc.facebook.com/intern/diff/D29047680) [ghstack-poisoned]

bdhirsh · 2021-06-14T14:27:21Z

@bdhirsh has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

… error messages" Differential Revision: [D29047680](https://our.internmc.facebook.com/intern/diff/D29047680) [ghstack-poisoned]

…ages ghstack-source-id: 3413e49 Pull Request resolved: #59839

bdhirsh · 2021-06-14T19:37:45Z

@bdhirsh has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

… error messages" Differential Revision: [D29047680](https://our.internmc.facebook.com/intern/diff/D29047680) [ghstack-poisoned]

…ages Pull Request resolved: #59839 Differential Revision: [D29047680](https://our.internmc.facebook.com/intern/diff/D29047680/) ghstack-source-id: 131502432

… error messages" Differential Revision: [D29047680](https://our.internmc.facebook.com/intern/diff/D29047680) [ghstack-poisoned]

…ages Pull Request resolved: #59839 Differential Revision: [D29047680](https://our.internmc.facebook.com/intern/diff/D29047680/) ghstack-source-id: 131628623

… error messages" Differential Revision: [D29047680](https://our.internmc.facebook.com/intern/diff/D29047680) [ghstack-poisoned]

…ages Pull Request resolved: #59839 Differential Revision: [D29047680](https://our.internmc.facebook.com/intern/diff/D29047680/) ghstack-source-id: 131703206

… error messages" Differential Revision: [D29047680](https://our.internmc.facebook.com/intern/diff/D29047680) [ghstack-poisoned]

bdhirsh · 2021-06-25T13:50:50Z

@bdhirsh has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

… error messages" Differential Revision: [D29047680](https://our.internmc.facebook.com/intern/diff/D29047680) [ghstack-poisoned]

bdhirsh · 2021-06-29T22:37:08Z

@bdhirsh has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@wenleix

… error messages" Turns external backend kernels into class methods, so they get helpful compiler errors instead of linker errors whenever they're a schema mismatch. I took a stab at trying to do the same for in-tree kernels, but gave up after a while. It would probably make sense to come back to it with @wenleix 's nice set of regex calls, to automatically pick up all of the native kernels in the `aten/src/ATen/native` folder. Corresponding xla PR: pytorch/xla#3012 Differential Revision: [D29047680](https://our.internmc.facebook.com/intern/diff/D29047680) [ghstack-poisoned]

bdhirsh · 2021-07-06T18:58:49Z

@bdhirsh has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

ailzhang

Thanks @bdhirsh !

facebook-github-bot · 2021-07-08T22:33:28Z

@bdhirsh merged this pull request in 7318747.

move all external kernels into a class for better compiler error mess…

ce4f19f

…ages [ghstack-poisoned]

This was referenced Jun 10, 2021

bugfix: ensure that at::{dispatch_key}:: API gets external linkage #58569

Closed

generate C++ API for meta functions using at::meta:: #58570

Closed

beef up at::_ops API #59115

Closed

facebook-github-bot added the cla signed label Jun 10, 2021

bdhirsh mentioned this pull request Jun 10, 2021

add a boxed CPU fallback kernel #58065

Closed

Update on "move all external kernels into a class for better compiler…

643288e

… error messages" Differential Revision: [D29047680](https://our.internmc.facebook.com/intern/diff/D29047680) [ghstack-poisoned]

Update on "move all external kernels into a class for better compiler…

ba1f863

… error messages" Differential Revision: [D29047680](https://our.internmc.facebook.com/intern/diff/D29047680) [ghstack-poisoned]

Update on "move all external kernels into a class for better compiler…

77cdc7d

… error messages" Differential Revision: [D29047680](https://our.internmc.facebook.com/intern/diff/D29047680) [ghstack-poisoned]

bdhirsh added a commit that referenced this pull request Jun 11, 2021

move all external kernels into a class for better compiler error mess…

69943f8

…ages ghstack-source-id: 8d64d20 Pull Request resolved: #59839

Update on "move all external kernels into a class for better compiler…

81f4830

… error messages" Differential Revision: [D29047680](https://our.internmc.facebook.com/intern/diff/D29047680) [ghstack-poisoned]

bdhirsh added a commit that referenced this pull request Jun 11, 2021

move all external kernels into a class for better compiler error mess…

6adf436

…ages ghstack-source-id: 88f511c Pull Request resolved: #59839

Update on "move all external kernels into a class for better compiler…

cdd4f11

… error messages" Differential Revision: [D29047680](https://our.internmc.facebook.com/intern/diff/D29047680) [ghstack-poisoned]

Update on "move all external kernels into a class for better compiler…

844f28f

… error messages" Differential Revision: [D29047680](https://our.internmc.facebook.com/intern/diff/D29047680) [ghstack-poisoned]

Update on "move all external kernels into a class for better compiler…

c03153d

… error messages" Differential Revision: [D29047680](https://our.internmc.facebook.com/intern/diff/D29047680) [ghstack-poisoned]

bdhirsh added a commit that referenced this pull request Jun 14, 2021

move all external kernels into a class for better compiler error mess…

e910832

…ages ghstack-source-id: 3413e49 Pull Request resolved: #59839

Update on "move all external kernels into a class for better compiler…

8e30732

… error messages" Differential Revision: [D29047680](https://our.internmc.facebook.com/intern/diff/D29047680) [ghstack-poisoned]

Update on "move all external kernels into a class for better compiler…

2210b78

… error messages" Differential Revision: [D29047680](https://our.internmc.facebook.com/intern/diff/D29047680) [ghstack-poisoned]

Update on "move all external kernels into a class for better compiler…

3f8ceeb

… error messages" Differential Revision: [D29047680](https://our.internmc.facebook.com/intern/diff/D29047680) [ghstack-poisoned]

Update on "move all external kernels into a class for better compiler…

2971229

… error messages" Differential Revision: [D29047680](https://our.internmc.facebook.com/intern/diff/D29047680) [ghstack-poisoned]

Update on "move all external kernels into a class for better compiler…

b0a5868

… error messages" Differential Revision: [D29047680](https://our.internmc.facebook.com/intern/diff/D29047680) [ghstack-poisoned]

Update on "move all external kernels into a class for better compiler…

fe12df4

… error messages" Differential Revision: [D29047680](https://our.internmc.facebook.com/intern/diff/D29047680) [ghstack-poisoned]

bdhirsh mentioned this pull request Jun 25, 2021

detect missing kernels from external backends in codegen #60737

Closed

Update on "move all external kernels into a class for better compiler…

b0f399c

… error messages" Differential Revision: [D29047680](https://our.internmc.facebook.com/intern/diff/D29047680) [ghstack-poisoned]

Update on "move all external kernels into a class for better compiler…

7859a01

… error messages" Differential Revision: [D29047680](https://our.internmc.facebook.com/intern/diff/D29047680) [ghstack-poisoned]

bdhirsh mentioned this pull request Jun 29, 2021

Make kernels methods pytorch/xla#3012

Merged

bdhirsh requested review from ailzhang and ezyang June 29, 2021 22:48

ezyang approved these changes Jun 30, 2021

View reviewed changes

ailzhang approved these changes Jul 7, 2021

View reviewed changes

facebook-github-bot closed this in 7318747 Jul 8, 2021

facebook-github-bot added the Merged label Jul 8, 2021

facebook-github-bot deleted the gh/bdhirsh/124/head branch July 12, 2021 14:18

Conversation

bdhirsh commented Jun 10, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

facebook-github-bot commented Jun 10, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💊 CI failures summary and remediations

🕵️ 1 new failure recognized by patterns

pytorch_xla_linux_bionic_py3_6_clang9_build (1/1)

🚧 1 fixed upstream failure:

Uh oh!

bdhirsh commented Jun 10, 2021

Uh oh!

bdhirsh commented Jun 11, 2021

Uh oh!

bdhirsh commented Jun 11, 2021

Uh oh!

bdhirsh commented Jun 11, 2021

Uh oh!

bdhirsh commented Jun 14, 2021

Uh oh!

bdhirsh commented Jun 14, 2021

Uh oh!

bdhirsh commented Jun 14, 2021

Uh oh!

bdhirsh commented Jun 25, 2021

Uh oh!

bdhirsh commented Jun 29, 2021

Uh oh!

bdhirsh commented Jul 6, 2021

Uh oh!

ailzhang left a comment

Choose a reason for hiding this comment

Uh oh!

facebook-github-bot commented Jul 8, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

bdhirsh commented Jun 10, 2021 •

edited

Loading

facebook-github-bot commented Jun 10, 2021 •

edited

Loading