Strictly type everything in .github and tools#59117
Strictly type everything in .github and tools#59117samestep wants to merge 9 commits intopytorch:masterfrom samestep:mypy-strict-ini-consolidate
Conversation
💊 CI failures summary and remediationsAs of commit 622d4a6 (more details on the Dr. CI page):
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
|
@samestep has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
malfet
left a comment
There was a problem hiding this comment.
mypy is an authority here: if it says its green will merge it!
|
@samestep has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
@samestep has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
@samestep has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
walterddr
left a comment
There was a problem hiding this comment.
looks good.
would suggest landing this during off peak hour to avoid cross merge :-P
Summary: This PR greatly simplifies `mypy-strict.ini` by strictly typing everything in `.github` and `tools`, rather than picking and choosing only specific files in those two dirs. It also removes `warn_unused_ignores` from `mypy-strict.ini`, for reasons described in pytorch#56402 (comment): basically, that setting makes life more difficult depending on what libraries you have installed locally vs in CI (e.g. `ruamel`). Pull Request resolved: pytorch#59117 Test Plan: ``` flake8 mypy --config mypy-strict.ini ``` Reviewed By: malfet Differential Revision: D28765386 Pulled By: samestep fbshipit-source-id: 3e744e301c7a464f8a2a2428fcdbad534e231f2e
This PR greatly simplifies
mypy-strict.iniby strictly typing everything in.githubandtools, rather than picking and choosing only specific files in those two dirs. It also removeswarn_unused_ignoresfrommypy-strict.ini, for reasons described in #56402 (comment): basically, that setting makes life more difficult depending on what libraries you have installed locally vs in CI (e.g.ruamel).Test plan: