[remove xla from codegen] rename aten_xla_type.h -> DispatchKeyNativeFunctions.h#58568
Closed
bdhirsh wants to merge 6 commits intogh/bdhirsh/119/basefrom
Closed
[remove xla from codegen] rename aten_xla_type.h -> DispatchKeyNativeFunctions.h#58568bdhirsh wants to merge 6 commits intogh/bdhirsh/119/basefrom
bdhirsh wants to merge 6 commits intogh/bdhirsh/119/basefrom
Conversation
…Functions.h [ghstack-poisoned]
Contributor
💊 CI failures summary and remediationsAs of commit 525b46c (more details on the Dr. CI page):
🕵️ 2 new failures recognized by patternsThe following CI failures do not appear to be due to upstream breakages:
|
This was referenced May 19, 2021
…chKeyNativeFunctions.h"
I split out the file rename into a separate commit to make the diff easier. The template file name is `aten_xla_type.h` -> `{DispatchKey}NativeFunctions.h`
[ghstack-poisoned]
…chKeyNativeFunctions.h"
I split out the file rename into a separate commit to make the diff easier. The template file name is `aten_xla_type.h` -> `{DispatchKey}NativeFunctions.h`
[ghstack-poisoned]
…chKeyNativeFunctions.h"
I split out the file rename into a separate commit to make the diff easier. The template file name is `aten_xla_type.h` -> `{DispatchKey}NativeFunctions.h`
[ghstack-poisoned]
…chKeyNativeFunctions.h"
I split out the file rename into a separate commit to make the diff easier. The template file name is `aten_xla_type.h` -> `{DispatchKey}NativeFunctions.h`
[ghstack-poisoned]
ezyang
approved these changes
May 20, 2021
…chKeyNativeFunctions.h"
I split out the file rename into a separate commit to make the diff easier. The template file name is `aten_xla_type.h` -> `{DispatchKey}NativeFunctions.h`
[ghstack-poisoned]
Collaborator
Author
|
@bdhirsh has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Contributor
Closed
deniskokarev
pushed a commit
to deniskokarev/pytorch
that referenced
this pull request
Jun 9, 2021
…Functions.h (pytorch#58568) Summary: Pull Request resolved: pytorch#58568 I split out the file rename into a separate commit to make the diff easier. The template file name is `aten_xla_type.h` -> `{DispatchKey}NativeFunctions.h` Test Plan: Imported from OSS Reviewed By: pbelevich Differential Revision: D28711298 Pulled By: bdhirsh fbshipit-source-id: 2fa7d2abede560a2c577300f0b5a1f7de263d897
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I split out the file rename into a separate commit to make the diff easier. The template file name is
aten_xla_type.h->{DispatchKey}NativeFunctions.hStack from ghstack:
Differential Revision: D28711298