Fix some tensor operators to return `NotImplemented` for invalid inputs by asi1024 · Pull Request #58216 · pytorch/pytorch

asi1024 · 2021-05-13T04:50:37Z

Same as #57934. (cc/ @albanD)

facebook-github-bot · 2021-05-13T04:50:42Z

💊 CI failures summary and remediations

As of commit 41af3ca (more details on the Dr. CI page):

4/4 failures introduced in this PR

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

pytorch_xla_linux_bionic_py3_6_clang9_build (1/1)

Step: "Build" (full log | diagnosis details | 🔁 rerun)

May 17 23:59:42 rm: cannot remove '/var/lib/jenkins/sccache_error.log': No such file or directory

May 17 23:59:42 ++++ extract_trap_cmd
May 17 23:59:42 ++++ printf '%s\n' ''
May 17 23:59:42 +++ printf '%s\n' cleanup
May 17 23:59:42 ++ trap -- '
May 17 23:59:42 cleanup' EXIT
May 17 23:59:42 ++ [[ pytorch-xla-linux-bionic-py3.6-clang9-build != *pytorch-win-* ]]
May 17 23:59:42 ++ which sccache
May 17 23:59:42 ++ sccache --stop-server
May 17 23:59:42 ++ true
May 17 23:59:42 ++ rm /var/lib/jenkins/sccache_error.log
May 17 23:59:42 rm: cannot remove '/var/lib/jenkins/sccache_error.log': No such file or directory
May 17 23:59:42 ++ true
May 17 23:59:42 ++ [[ -n '' ]]
May 17 23:59:42 ++ [[ pytorch-xla-linux-bionic-py3.6-clang9-build == *rocm* ]]
May 17 23:59:42 ++ SCCACHE_ERROR_LOG=/var/lib/jenkins/sccache_error.log
May 17 23:59:42 ++ SCCACHE_IDLE_TIMEOUT=1200
May 17 23:59:42 ++ RUST_LOG=sccache::server=error
May 17 23:59:42 ++ sccache --start-server
May 17 23:59:42 sccache: Starting the server...
May 17 23:59:43 ++ sccache --zero-stats
May 17 23:59:43 Compile requests                      0

3 failures not recognized by patterns:

Job	Step	Action
^{binary_linux_libtorch_3_7m_cpu_devtoolset7_shared-with-deps_test}	^{Checkout pytorch/builder repo}	🔁 rerun
^{binary_linux_libtorch_3_7m_cpu_gcc5_4_cxx11-abi_shared-with-deps_test}	^{Checkout pytorch/builder repo}	🔁 rerun
^{binary_linux_manywheel_3_7m_cu102_devtoolset7_test}	^{Checkout pytorch/builder repo}	🔁 rerun

This comment was automatically generated by Dr. CI (expand for details).

Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

albanD · 2021-05-13T14:10:32Z

Hi thanks for the new PR
I don't see any difference with the previous one though wrt to the rmatmul test?

asi1024 · 2021-05-14T08:16:55Z

@albanD Sorry, I have forgotten to make a change skipping bfloat16 test. 🙇
I fixed OpInfo('__rmatmul__') to skip bfloat16 test in d083d47, and rebased onto master branch.

albanD · 2021-05-14T13:55:28Z

I think there are some formatting issue (missing parenthesis)?
Also you can check in the issue you opened for ideas how to avoid disabling all these tests if you want.

asi1024 · 2021-05-14T20:03:40Z

@albanD Sorry, I have accidentally deleted the comma at the end of the line before I committed. Now I fixed it!

albanD · 2021-05-14T20:31:07Z

I would like to get the windows cuda test to run here before merging to make sure we don't have to revert again. It might take a few days as we are changing this process right now.

albanD · 2021-05-17T15:25:38Z

Ok, it should be ready now. Could you rebase on top of master please so that we can run all the CI?

asi1024 · 2021-05-17T19:21:33Z

@albanD Rebased!

codecov · 2021-05-17T22:44:51Z

Codecov Report

Merging #58216 (41af3ca) into master (a3b3313) will increase coverage by 6.01%.
The diff coverage is 84.61%.

@@            Coverage Diff             @@
##           master   #58216      +/-   ##
==========================================
+ Coverage   70.46%   76.47%   +6.01%     
==========================================
  Files        1969     1992      +23     
  Lines      197141   199899    +2758     
==========================================
+ Hits       138909   152867   +13958     
+ Misses      58232    47032   -11200

facebook-github-bot · 2021-05-17T23:59:20Z

@albanD has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

facebook-github-bot · 2021-05-19T20:11:05Z

@albanD merged this pull request in 3113a1d.

asi1024 · 2021-05-19T22:33:38Z

@albanD Thanks!

Summary: Fixes #58035. This PR implements `torch.Tensor.__rmod__` and `torch.remainder(scalar, tensor)` for the compatibility with NumPy’s interface. (cc: mruberry, rgommers, emcastillo, kmaehashi) TODO: - [x] Update `tensor_binary_op` in test/test_binary_ufuncs.py after #58216 is merged. Pull Request resolved: #58476 Reviewed By: ngimel Differential Revision: D28776810 Pulled By: mruberry fbshipit-source-id: 74f8aea80f439ef2cc370333524e39971eeb7bf4

Summary: Fixes pytorch#58035. This PR implements `torch.Tensor.__rmod__` and `torch.remainder(scalar, tensor)` for the compatibility with NumPy’s interface. (cc: mruberry, rgommers, emcastillo, kmaehashi) TODO: - [x] Update `tensor_binary_op` in test/test_binary_ufuncs.py after pytorch#58216 is merged. Pull Request resolved: pytorch#58476 Reviewed By: ngimel Differential Revision: D28776810 Pulled By: mruberry fbshipit-source-id: 74f8aea80f439ef2cc370333524e39971eeb7bf4

…ts (pytorch#58216) Summary: Same as pytorch#57934. (cc/ albanD) Pull Request resolved: pytorch#58216 Reviewed By: ailzhang Differential Revision: D28494886 Pulled By: albanD fbshipit-source-id: 380205867ee1cde90e1c6fcfe2a31749e1243530

Summary: Fixes pytorch#58035. This PR implements `torch.Tensor.__rmod__` and `torch.remainder(scalar, tensor)` for the compatibility with NumPy’s interface. (cc: mruberry, rgommers, emcastillo, kmaehashi) TODO: - [x] Update `tensor_binary_op` in test/test_binary_ufuncs.py after pytorch#58216 is merged. Pull Request resolved: pytorch#58476 Reviewed By: ngimel Differential Revision: D28776810 Pulled By: mruberry fbshipit-source-id: 74f8aea80f439ef2cc370333524e39971eeb7bf4

asi1024 requested review from BowenBao, neginraoof and spandantiwari as code owners May 13, 2021 04:50

facebook-github-bot added the cla signed label May 13, 2021

asi1024 mentioned this pull request May 13, 2021

Fix some tensor operators to return NotImplemented for invalid inputs #57934

Closed

pytorchbot added the open source label May 13, 2021

albanD added the ci/master label May 13, 2021

ejguan added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label May 13, 2021

asi1024 force-pushed the fix-operator branch 2 times, most recently from 27f4daa to d083d47 Compare May 14, 2021 08:13

asi1024 force-pushed the fix-operator branch from d083d47 to d6df9c3 Compare May 14, 2021 19:02

albanD removed the ci/master label May 17, 2021

asi1024 added 4 commits May 17, 2021 18:39

Fix some operators to return NotImplemented for invalid inputs

7eced27

Fix variable name in test/onnx/expect/TestOperators.test_rsub.expect

625a54b

Add torch.__rmatmul__

5b57b0a

Skip __rmatmul__ test_unsupported_dtypes test for bfloat16 input

41af3ca

asi1024 force-pushed the fix-operator branch from d6df9c3 to 41af3ca Compare May 17, 2021 18:40

albanD added the ci/master label May 17, 2021

asi1024 mentioned this pull request May 18, 2021

Support __rmod__ #58476

Closed

1 task

facebook-github-bot closed this in 3113a1d May 19, 2021

facebook-github-bot added the Merged label May 19, 2021

asi1024 deleted the fix-operator branch May 19, 2021 22:33

pmeier mentioned this pull request Jun 10, 2021

Python Array API New Operators Tracker #58742

Open

28 tasks

pmeier added the module: python array api Issues related to the Python Array API label Jun 10, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix some tensor operators to return `NotImplemented` for invalid inputs#58216

Fix some tensor operators to return `NotImplemented` for invalid inputs#58216
asi1024 wants to merge 4 commits intopytorch:masterfrom
asi1024:fix-operator

asi1024 commented May 13, 2021

Uh oh!

facebook-github-bot commented May 13, 2021 •

edited

Loading

Uh oh!

albanD commented May 13, 2021

Uh oh!

asi1024 commented May 14, 2021

Uh oh!

albanD commented May 14, 2021

Uh oh!

asi1024 commented May 14, 2021

Uh oh!

albanD commented May 14, 2021

Uh oh!

albanD commented May 17, 2021

Uh oh!

asi1024 commented May 17, 2021

Uh oh!

codecov Bot commented May 17, 2021

Uh oh!

facebook-github-bot commented May 17, 2021

Uh oh!

facebook-github-bot commented May 19, 2021

Uh oh!

asi1024 commented May 19, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

asi1024 commented May 13, 2021

Uh oh!

facebook-github-bot commented May 13, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💊 CI failures summary and remediations

🕵️ 1 new failure recognized by patterns

pytorch_xla_linux_bionic_py3_6_clang9_build (1/1)

3 failures not recognized by patterns:

Uh oh!

albanD commented May 13, 2021

Uh oh!

asi1024 commented May 14, 2021

Uh oh!

albanD commented May 14, 2021

Uh oh!

asi1024 commented May 14, 2021

Uh oh!

albanD commented May 14, 2021

Uh oh!

albanD commented May 17, 2021

Uh oh!

asi1024 commented May 17, 2021

Uh oh!

codecov Bot commented May 17, 2021

Codecov Report

Uh oh!

facebook-github-bot commented May 17, 2021

Uh oh!

facebook-github-bot commented May 19, 2021

Uh oh!

asi1024 commented May 19, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

facebook-github-bot commented May 13, 2021 •

edited

Loading