Add CUDA Vital by bitfort · Pull Request #58059 · pytorch/pytorch

bitfort · 2021-05-11T17:30:41Z

Summary: Add CUDA.used vital sign which is true only if CUDA was "used" which technically means the context was created.

Test Plan: buck test mode/dbg caffe2/test:torch -- --regex basic_vitals

Differential Revision: D28357615

facebook-github-bot · 2021-05-11T17:30:48Z

💊 CI failures summary and remediations

As of commit bb7409c (more details on the Dr. CI page and at hud.pytorch.org/pr/58059):

1/2 failures possibly* introduced in this PR
- 1/1 non-scanned failure(s)
1/2 broken upstream at merge base f2f2f5b from Jun 23 until Jun 24

🚧 1 fixed upstream failure:

These were probably caused by upstream breakages that were already fixed.

Please rebase on the viable/strict branch (expand for instructions)

If your commit is older than viable/strict, run these commands:

git fetch https://github.com/pytorch/pytorch viable/strict
git rebase FETCH_HEAD

pytorch_xla_linux_bionic_py3_6_clang9_test from Jun 23 until Jun 24 (80f40b1 - b7298f4)
- 🔁 rerun

This comment was automatically generated by Dr. CI (expand for details).

Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

facebook-github-bot · 2021-05-11T17:31:03Z

This pull request was exported from Phabricator. Differential Revision: D28357615

facebook-github-bot · 2021-05-18T16:23:43Z

This pull request was exported from Phabricator. Differential Revision: D28357615

codecov · 2021-05-18T22:33:42Z

Codecov Report

Merging #58059 (2d6235f) into master (ccd7141) will increase coverage by 0.02%.
The diff coverage is 78.71%.

❗ Current head 2d6235f differs from pull request most recent head f00af20. Consider uploading reports for the commit f00af20 to get more accurate results

@@            Coverage Diff             @@
##           master   #58059      +/-   ##
==========================================
+ Coverage   76.44%   76.46%   +0.02%     
==========================================
  Files        1990     1992       +2     
  Lines      199690   199960     +270     
==========================================
+ Hits       152651   152900     +249     
- Misses      47039    47060      +21

facebook-github-bot · 2021-05-24T18:47:59Z

This pull request was exported from Phabricator. Differential Revision: D28357615

xuzhao9

I am not familiar with the Vitals project, so just adding a few questions here.

xuzhao9 · 2021-05-27T17:33:32Z

Why we are only returning the "second" values here, but not "first"? In the test below, it looks like both the name and the value should be returned, say 'CUDA.used\t\t true'.

I believe second calls toString() which has both the name and value in it and concatenates the two. So first is actually also inside second :)

xuzhao9 · 2021-05-27T17:34:12Z

May I ask what is the field of "force" doing here?

This is making sure the vital data is updated, even if the TORCHVITAL env variable is not set. This is to enable testing because the env variable isn't always set when the test is being done - and we no easy workaround.

facebook-github-bot · 2021-06-03T18:27:02Z

This pull request was exported from Phabricator. Differential Revision: D28357615

xuzhao9

Looking good, having two comments inlined

ngimel · 2021-06-04T23:35:46Z

nit: do you need an extra API, or is it enough to have setVital with default force=false arg?

I'll check, not sure.

ngimel · 2021-06-05T06:40:00Z

here conditional also seems like unnecessary complication - if you had write(value, force) you could have avoided conditional

ngimel · 2021-06-05T06:40:38Z

Why are there 2 functions instead of write(const T& t, bool force)?

Good idea :)

ngimel · 2021-06-05T06:45:49Z

Why toString function instead of redefining << so that you can directly call std::cout << this ?

Probably because I have python semantics on my mind instead of c++ semantics :)

I implemented a << operator.

facebook-github-bot · 2021-06-21T23:06:44Z

This pull request was exported from Phabricator. Differential Revision: D28357615

facebook-github-bot · 2021-06-22T03:07:16Z

This pull request was exported from Phabricator. Differential Revision: D28357615

facebook-github-bot · 2021-06-22T17:17:15Z

This pull request was exported from Phabricator. Differential Revision: D28357615

Summary: Pull Request resolved: pytorch#58059 Add CUDA.used vital sign which is true only if CUDA was "used" which technically means the context was created. Also adds the following features: - Force vitals to be written even if vitals are disabled, to enable testing when the env variable is not set from the start of execution - Add a read_vitals call for python to read existing vital signs. Test Plan: buck test mode/dbg caffe2/test:torch -- --regex basic_vitals Reviewed By: xuzhao9 Differential Revision: D28357615 fbshipit-source-id: 78a8755801b11ccc7e33a9eac669ebb7a83ddb87

facebook-github-bot · 2021-06-24T17:34:48Z

This pull request was exported from Phabricator. Differential Revision: D28357615

xuzhao9

LGTM!

facebook-github-bot · 2021-06-25T23:33:18Z

This pull request has been merged in 8b6487c.

Summary: Pull Request resolved: pytorch#58059 Add CUDA.used vital sign which is true only if CUDA was "used" which technically means the context was created. Also adds the following features: - Force vitals to be written even if vitals are disabled, to enable testing when the env variable is not set from the start of execution - Add a read_vitals call for python to read existing vital signs. Test Plan: buck test mode/dbg caffe2/test:torch -- --regex basic_vitals Reviewed By: xuzhao9 Differential Revision: D28357615 fbshipit-source-id: 681bf9ef63cb1458df9f1c241d301a3ddf1e5252

Summary: Pull Request resolved: #58059 Add CUDA.used vital sign which is true only if CUDA was "used" which technically means the context was created. Also adds the following features: - Force vitals to be written even if vitals are disabled, to enable testing when the env variable is not set from the start of execution - Add a read_vitals call for python to read existing vital signs. Test Plan: buck test mode/dbg caffe2/test:torch -- --regex basic_vitals Reviewed By: xuzhao9 Differential Revision: D28357615 fbshipit-source-id: 681bf9ef63cb1458df9f1c241d301a3ddf1e5252

TorchVitals was an undocumented feature gated behind the TORCH_VITAL environment variable that allowed setting and reading key-value "vital signs" (e.g. whether CUDA or DataLoader was used). It was never documented and the test itself had a "FIXME: document or deprecate" comment. Originally added in PR #51047 (Jan 2021), with a Python API in #53238 and a CUDA vital in #58059. There have been no feature changes since June 2021 — all subsequent commits were mechanical cleanups (clang-tidy, thread-safe getenv, etc.). A search on cs.github.com and general web search confirmed no external projects depend on torch.set_vital, torch.read_vitals, or torch.vitals_enabled — usage was limited to pytorch/pytorch itself. Authored with Claude. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> ghstack-source-id: b56228f Pull-Request: #178479

TorchVitals was an undocumented feature gated behind the TORCH_VITAL environment variable that allowed setting and reading key-value "vital signs" (e.g. whether CUDA or DataLoader was used). It was never documented and the test itself had a "FIXME: document or deprecate" comment. Originally added in PR #51047 (Jan 2021), with a Python API in #53238 and a CUDA vital in #58059. There have been no feature changes since June 2021 — all subsequent commits were mechanical cleanups (clang-tidy, thread-safe getenv, etc.). A search on cs.github.com and general web search confirmed no external projects depend on torch.set_vital, torch.read_vitals, or torch.vitals_enabled — usage was limited to pytorch/pytorch itself. Authored with Claude. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> ghstack-source-id: 372adae Pull-Request: #178479

TorchVitals was an undocumented feature gated behind the TORCH_VITAL environment variable that allowed setting and reading key-value "vital signs" (e.g. whether CUDA or DataLoader was used). It was never documented and the test itself had a "FIXME: document or deprecate" comment. Originally added in PR #51047 (Jan 2021), with a Python API in #53238 and a CUDA vital in #58059. There have been no feature changes since June 2021 — all subsequent commits were mechanical cleanups (clang-tidy, thread-safe getenv, etc.). A search on cs.github.com and general web search confirmed no external projects depend on torch.set_vital, torch.read_vitals, or torch.vitals_enabled — usage was limited to pytorch/pytorch itself. Authored with Claude. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> ghstack-source-id: 1c33462 Pull-Request: #178479

TorchVitals was an undocumented feature gated behind the TORCH_VITAL environment variable that allowed setting and reading key-value "vital signs" (e.g. whether CUDA or DataLoader was used). It was never documented and the test itself had a "FIXME: document or deprecate" comment. Originally added in PR #51047 (Jan 2021), with a Python API in #53238 and a CUDA vital in #58059. There have been no feature changes since June 2021 — all subsequent commits were mechanical cleanups (clang-tidy, thread-safe getenv, etc.). A search on cs.github.com and general web search confirmed no external projects depend on torch.set_vital, torch.read_vitals, or torch.vitals_enabled — usage was limited to pytorch/pytorch itself. Authored with Claude. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> ghstack-source-id: 65c136a Pull-Request: #178479

TorchVitals was an undocumented feature gated behind the TORCH_VITAL environment variable that allowed setting and reading key-value "vital signs" (e.g. whether CUDA or DataLoader was used). It was never documented and the test itself had a "FIXME: document or deprecate" comment. Originally added in PR #51047 (Jan 2021), with a Python API in #53238 and a CUDA vital in #58059. There have been no feature changes since June 2021 — all subsequent commits were mechanical cleanups (clang-tidy, thread-safe getenv, etc.). A search on cs.github.com and general web search confirmed no external projects depend on torch.set_vital, torch.read_vitals, or torch.vitals_enabled — usage was limited to pytorch/pytorch itself. Authored with Claude. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> ghstack-source-id: 160ae2f Pull-Request: #178479

TorchVitals was an undocumented feature gated behind the TORCH_VITAL environment variable that allowed setting and reading key-value "vital signs" (e.g. whether CUDA or DataLoader was used). It was never documented and the test itself had a "FIXME: document or deprecate" comment. Originally added in PR #51047 (Jan 2021), with a Python API in #53238 and a CUDA vital in #58059. There have been no feature changes since June 2021 — all subsequent commits were mechanical cleanups (clang-tidy, thread-safe getenv, etc.). A search on cs.github.com and general web search confirmed no external projects depend on torch.set_vital, torch.read_vitals, or torch.vitals_enabled — usage was limited to pytorch/pytorch itself. Authored with Claude. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Pull Request resolved: #178479 Approved by: https://github.com/msaroufim, https://github.com/albanD

TorchVitals was an undocumented feature gated behind the TORCH_VITAL environment variable that allowed setting and reading key-value "vital signs" (e.g. whether CUDA or DataLoader was used). It was never documented and the test itself had a "FIXME: document or deprecate" comment. Originally added in PR #51047 (Jan 2021), with a Python API in #53238 and a CUDA vital in #58059. There have been no feature changes since June 2021 — all subsequent commits were mechanical cleanups (clang-tidy, thread-safe getenv, etc.). A search on cs.github.com and general web search confirmed no external projects depend on torch.set_vital, torch.read_vitals, or torch.vitals_enabled — usage was limited to pytorch/pytorch itself. Authored with Claude. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Pull Request resolved: #178479 Approved by: https://github.com/msaroufim, https://github.com/albanD Co-authored-by: Xia-Weiwen <12522207+Xia-Weiwen@users.noreply.github.com>

TorchVitals was an undocumented feature gated behind the TORCH_VITAL environment variable that allowed setting and reading key-value "vital signs" (e.g. whether CUDA or DataLoader was used). It was never documented and the test itself had a "FIXME: document or deprecate" comment. Originally added in PR pytorch#51047 (Jan 2021), with a Python API in pytorch#53238 and a CUDA vital in pytorch#58059. There have been no feature changes since June 2021 — all subsequent commits were mechanical cleanups (clang-tidy, thread-safe getenv, etc.). A search on cs.github.com and general web search confirmed no external projects depend on torch.set_vital, torch.read_vitals, or torch.vitals_enabled — usage was limited to pytorch/pytorch itself. Authored with Claude. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Pull Request resolved: pytorch#178479 Approved by: https://github.com/msaroufim, https://github.com/albanD

TorchVitals was an undocumented feature gated behind the TORCH_VITAL environment variable that allowed setting and reading key-value "vital signs" (e.g. whether CUDA or DataLoader was used). It was never documented and the test itself had a "FIXME: document or deprecate" comment. Originally added in PR #51047 (Jan 2021), with a Python API in #53238 and a CUDA vital in #58059. There have been no feature changes since June 2021 — all subsequent commits were mechanical cleanups (clang-tidy, thread-safe getenv, etc.). A search on cs.github.com and general web search confirmed no external projects depend on torch.set_vital, torch.read_vitals, or torch.vitals_enabled — usage was limited to pytorch/pytorch itself. Authored with Claude. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Pull Request resolved: #178479 Approved by: https://github.com/msaroufim, https://github.com/albanD

TorchVitals was an undocumented feature gated behind the TORCH_VITAL environment variable that allowed setting and reading key-value "vital signs" (e.g. whether CUDA or DataLoader was used). It was never documented and the test itself had a "FIXME: document or deprecate" comment. Originally added in PR #51047 (Jan 2021), with a Python API in #53238 and a CUDA vital in #58059. There have been no feature changes since June 2021 — all subsequent commits were mechanical cleanups (clang-tidy, thread-safe getenv, etc.). A search on cs.github.com and general web search confirmed no external projects depend on torch.set_vital, torch.read_vitals, or torch.vitals_enabled — usage was limited to pytorch/pytorch itself. Authored with Claude. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> ghstack-source-id: 46b1a3d Pull-Request: #178479

TorchVitals was an undocumented feature gated behind the TORCH_VITAL environment variable that allowed setting and reading key-value "vital signs" (e.g. whether CUDA or DataLoader was used). It was never documented and the test itself had a "FIXME: document or deprecate" comment. Originally added in PR #51047 (Jan 2021), with a Python API in #53238 and a CUDA vital in #58059. There have been no feature changes since June 2021 — all subsequent commits were mechanical cleanups (clang-tidy, thread-safe getenv, etc.). Update: `torch.set_vital` was used from TorchData (see meta-pytorch/data#1537 ) so will keep the dummy API around Authored with Claude. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Pull Request resolved: #178479 Approved by: https://github.com/msaroufim, https://github.com/albanD, https://github.com/mlazos

TorchVitals was an undocumented feature gated behind the TORCH_VITAL environment variable that allowed setting and reading key-value "vital signs" (e.g. whether CUDA or DataLoader was used). It was never documented and the test itself had a "FIXME: document or deprecate" comment. Originally added in PR pytorch#51047 (Jan 2021), with a Python API in pytorch#53238 and a CUDA vital in pytorch#58059. There have been no feature changes since June 2021 — all subsequent commits were mechanical cleanups (clang-tidy, thread-safe getenv, etc.). A search on cs.github.com and general web search confirmed no external projects depend on torch.set_vital, torch.read_vitals, or torch.vitals_enabled — usage was limited to pytorch/pytorch itself. Authored with Claude. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Pull Request resolved: pytorch#178479 Approved by: https://github.com/msaroufim, https://github.com/albanD

TorchVitals was an undocumented feature gated behind the TORCH_VITAL environment variable that allowed setting and reading key-value "vital signs" (e.g. whether CUDA or DataLoader was used). It was never documented and the test itself had a "FIXME: document or deprecate" comment. Originally added in PR #51047 (Jan 2021), with a Python API in #53238 and a CUDA vital in #58059. There have been no feature changes since June 2021 — all subsequent commits were mechanical cleanups (clang-tidy, thread-safe getenv, etc.). Update: `torch.set_vital` was used from TorchData (see meta-pytorch/data#1537 ) so will keep the dummy API around Authored with Claude. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Pull Request resolved: #178479 Approved by: https://github.com/msaroufim, https://github.com/albanD, https://github.com/mlazos

TorchVitals was an undocumented feature gated behind the TORCH_VITAL environment variable that allowed setting and reading key-value "vital signs" (e.g. whether CUDA or DataLoader was used). It was never documented and the test itself had a "FIXME: document or deprecate" comment. Originally added in PR pytorch#51047 (Jan 2021), with a Python API in pytorch#53238 and a CUDA vital in pytorch#58059. There have been no feature changes since June 2021 — all subsequent commits were mechanical cleanups (clang-tidy, thread-safe getenv, etc.). A search on cs.github.com and general web search confirmed no external projects depend on torch.set_vital, torch.read_vitals, or torch.vitals_enabled — usage was limited to pytorch/pytorch itself. Authored with Claude. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Pull Request resolved: pytorch#178479 Approved by: https://github.com/msaroufim, https://github.com/albanD

TorchVitals was an undocumented feature gated behind the TORCH_VITAL environment variable that allowed setting and reading key-value "vital signs" (e.g. whether CUDA or DataLoader was used). It was never documented and the test itself had a "FIXME: document or deprecate" comment. Originally added in PR pytorch#51047 (Jan 2021), with a Python API in pytorch#53238 and a CUDA vital in pytorch#58059. There have been no feature changes since June 2021 — all subsequent commits were mechanical cleanups (clang-tidy, thread-safe getenv, etc.). Update: `torch.set_vital` was used from TorchData (see meta-pytorch/data#1537 ) so will keep the dummy API around Authored with Claude. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Pull Request resolved: pytorch#178479 Approved by: https://github.com/msaroufim, https://github.com/albanD, https://github.com/mlazos

TorchVitals was an undocumented feature gated behind the TORCH_VITAL environment variable that allowed setting and reading key-value "vital signs" (e.g. whether CUDA or DataLoader was used). It was never documented and the test itself had a "FIXME: document or deprecate" comment. Originally added in PR #51047 (Jan 2021), with a Python API in #53238 and a CUDA vital in #58059. There have been no feature changes since June 2021 — all subsequent commits were mechanical cleanups (clang-tidy, thread-safe getenv, etc.). Update: `torch.set_vital` was used from TorchData (see meta-pytorch/data#1537 ) so will keep the dummy API around Authored with Claude. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Pull Request resolved: #178479 Approved by: https://github.com/msaroufim, https://github.com/albanD, https://github.com/mlazos

Summary: Pull Request resolved: pytorch#58059 Add CUDA.used vital sign which is true only if CUDA was "used" which technically means the context was created. Also adds the following features: - Force vitals to be written even if vitals are disabled, to enable testing when the env variable is not set from the start of execution - Add a read_vitals call for python to read existing vital signs. Test Plan: buck test mode/dbg caffe2/test:torch -- --regex basic_vitals Reviewed By: xuzhao9 Differential Revision: D28357615 fbshipit-source-id: 681bf9ef63cb1458df9f1c241d301a3ddf1e5252

facebook-github-bot added the cla signed label May 11, 2021

facebook-github-bot added the fb-exported label May 11, 2021

bitfort force-pushed the export-D28357615 branch from 458dab9 to 2d6235f Compare May 18, 2021 16:23

bitfort force-pushed the export-D28357615 branch from 2d6235f to f00af20 Compare May 24, 2021 18:47

bitfort requested review from bwasti, ngimel, robieta and xuzhao9 May 24, 2021 19:01

xuzhao9 reviewed May 27, 2021

View reviewed changes

bitfort force-pushed the export-D28357615 branch from f00af20 to a081618 Compare June 3, 2021 18:27

bitfort requested review from xuzhao9 June 4, 2021 18:28

xuzhao9 approved these changes Jun 4, 2021

View reviewed changes

ngimel reviewed Jun 5, 2021

View reviewed changes

bitfort force-pushed the export-D28357615 branch from a081618 to 4679bdf Compare June 21, 2021 23:06

bitfort force-pushed the export-D28357615 branch from 4679bdf to 27a06bf Compare June 22, 2021 03:07

bitfort force-pushed the export-D28357615 branch from 1e5e092 to bb7409c Compare June 24, 2021 17:34

xuzhao9 approved these changes Jun 24, 2021

View reviewed changes

ngimel approved these changes Jun 24, 2021

View reviewed changes

facebook-github-bot closed this in 8b6487c Jun 25, 2021

facebook-github-bot added the Merged label Jun 25, 2021

malfet mentioned this pull request Mar 26, 2026

Remove TorchVitals #178479

Closed

Conversation

bitfort commented May 11, 2021

Uh oh!

facebook-github-bot commented May 11, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💊 CI failures summary and remediations

🚧 1 fixed upstream failure:

Uh oh!

facebook-github-bot commented May 11, 2021

Uh oh!

facebook-github-bot commented May 18, 2021

Uh oh!

codecov Bot commented May 18, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

facebook-github-bot commented May 24, 2021

Uh oh!

xuzhao9 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

facebook-github-bot commented Jun 3, 2021

Uh oh!

xuzhao9 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

facebook-github-bot commented Jun 21, 2021

Uh oh!

facebook-github-bot commented Jun 22, 2021

Uh oh!

facebook-github-bot commented Jun 22, 2021

Uh oh!

facebook-github-bot commented Jun 24, 2021

Uh oh!

xuzhao9 left a comment

Choose a reason for hiding this comment

Uh oh!

facebook-github-bot commented Jun 25, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

facebook-github-bot commented May 11, 2021 •

edited

Loading

codecov Bot commented May 18, 2021 •

edited

Loading