[profiler][small] Handle empty trace#58013

Closed

ilia-cher wants to merge 9 commits intogh/ilia-cher/105/basefrom

gh/ilia-cher/105/head

Contributor

ilia-cher commented May 11, 2021 •

edited

Loading

Stack from ghstack:

[profiler][small] Add skip_first parameter to the default schedule #58025 [profiler][small] Add skip_first parameter to the default schedule
[profiler] Speed up postprocessing #58021 [profiler][small] Speed up postprocessing
[profiler][small] Handle empty trace #58013 [profiler][small] Handle empty trace
[profiler][resend] Add cuda memory and distributed metadata #58010 [profiler][resend] Add cuda memory and distributed metadata

Summary:
Add a test case and a fix (legacy profiler) for empty trace handling

Test Plan:
python test/test_profiler.py

Differential Revision: D28345388


          [profiler][small] Handle empty trace

8c16ad8

Summary:
Add a test case and a fix (legacy profiler) for empty trace handling

Test Plan:
python test/test_profiler.py

[ghstack-poisoned]

ilia-cher requested review from albanD and soulitzer as code owners

May 11, 2021 04:48

ilia-cher mentioned this pull request

[profiler][resend] Add cuda memory and distributed metadata #58010

Closed

facebook-github-bot added the cla signed label

Contributor

facebook-github-bot commented May 11, 2021 •

edited

Loading

💊 CI failures summary and remediations

As of commit c909034 (more details on the Dr. CI page):

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

ilia-cher pushed a commit that referenced this pull request


          [profiler][small] Handle empty trace

9384b62

Summary:
Add a test case and a fix (legacy profiler) for empty trace handling

Test Plan:
python test/test_profiler.py

ghstack-source-id: 70eae38
Pull Request resolved: #58013

Contributor Author

ilia-cher commented May 11, 2021

@ilia-cher has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

This was referenced May 11, 2021

[profiler] Speed up postprocessing #58021

Closed

[profiler][small] Add skip_first parameter to the default schedule #58025

Closed


          Update on "[profiler][small] Handle empty trace"

6c2e7c7

Summary:
Add a test case and a fix (legacy profiler) for empty trace handling

Test Plan:
python test/test_profiler.py

Differential Revision: [D28345388](https://our.internmc.facebook.com/intern/diff/D28345388)

[ghstack-poisoned]

Contributor Author

ilia-cher commented May 11, 2021

@ilia-cher has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.


          Update on "[profiler][small] Handle empty trace"

596712a

Summary:
Add a test case and a fix (legacy profiler) for empty trace handling

Test Plan:
python test/test_profiler.py

Differential Revision: [D28345388](https://our.internmc.facebook.com/intern/diff/D28345388)

[ghstack-poisoned]

Contributor Author

ilia-cher commented May 11, 2021

@ilia-cher has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

ilia-cher requested review from bitfort, chaekit, gdankel and xuzhao9

May 11, 2021 08:33

dgl-intel pushed a commit to dgl-intel/pytorch that referenced this pull request


          [profiler][small] Handle empty trace

de9bef3

Summary:
Add a test case and a fix (legacy profiler) for empty trace handling

Test Plan:
python test/test_profiler.py

ghstack-source-id: dd3f25d
Pull Request resolved: pytorch#58013


          Update on "[profiler][small] Handle empty trace"

e692bb8

Summary:
Add a test case and a fix (legacy profiler) for empty trace handling

Test Plan:
python test/test_profiler.py

Differential Revision: [D28345388](https://our.internmc.facebook.com/intern/diff/D28345388)

[ghstack-poisoned]

Contributor Author

ilia-cher commented May 11, 2021

@ilia-cher has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.


          Update on "[profiler][small] Handle empty trace"

088ee2d

Summary:
Add a test case and a fix (legacy profiler) for empty trace handling

Test Plan:
python test/test_profiler.py

Differential Revision: [D28345388](https://our.internmc.facebook.com/intern/diff/D28345388)

[ghstack-poisoned]

Contributor Author

ilia-cher commented May 11, 2021

@ilia-cher has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.


          Update on "[profiler][small] Handle empty trace"

3a79fb1

Summary:
Add a test case and a fix (legacy profiler) for empty trace handling

Test Plan:
python test/test_profiler.py

Differential Revision: [D28345388](https://our.internmc.facebook.com/intern/diff/D28345388)

[ghstack-poisoned]

Contributor Author

ilia-cher commented May 11, 2021

@ilia-cher has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.


          Update on "[profiler][small] Handle empty trace"

d70aaf9

Summary:
Add a test case and a fix (legacy profiler) for empty trace handling

Test Plan:
python test/test_profiler.py

Differential Revision: [D28345388](https://our.internmc.facebook.com/intern/diff/D28345388)

[ghstack-poisoned]

Contributor Author

ilia-cher commented May 12, 2021

@ilia-cher has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.


          Update on "[profiler][small] Handle empty trace"

fcb2bdf

Summary:
Add a test case and a fix (legacy profiler) for empty trace handling

Test Plan:
python test/test_profiler.py

Differential Revision: [D28345388](https://our.internmc.facebook.com/intern/diff/D28345388)

[ghstack-poisoned]

Contributor Author

ilia-cher commented May 12, 2021

@ilia-cher has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.


          Update on "[profiler][small] Handle empty trace"

c909034

Summary:
Add a test case and a fix (legacy profiler) for empty trace handling

Test Plan:
python test/test_profiler.py

Differential Revision: [D28345388](https://our.internmc.facebook.com/intern/diff/D28345388)

[ghstack-poisoned]

Contributor Author

ilia-cher commented May 12, 2021

@ilia-cher has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

facebook-github-bot closed this in

bf2ebfc

Contributor

facebook-github-bot commented May 12, 2021

@ilia-cher merged this pull request in bf2ebfc.

facebook-github-bot added the Merged label

facebook-github-bot deleted the gh/ilia-cher/105/head branch

May 15, 2021 14:23

krshrimali pushed a commit to krshrimali/pytorch that referenced this pull request


          [profiler][small] Handle empty trace (pytorch#58013)

06a9693

Summary:
Pull Request resolved: pytorch#58013

Add a test case and a fix (legacy profiler) for empty trace handling

Test Plan: python test/test_profiler.py

Reviewed By: gdankel

Differential Revision: D28345388

Pulled By: ilia-cher

fbshipit-source-id: 4727589ab83367ac8b506cc0f186e5292d974671

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

albanD Awaiting requested review from albanD

soulitzer Awaiting requested review from soulitzer

gdankel Awaiting requested review from gdankel

xuzhao9 Awaiting requested review from xuzhao9

bitfort Awaiting requested review from bitfort

chaekit Awaiting requested review from chaekit

Labels

cla signed Merged