Reland of "D27708346: generate xla codegen in-tree"#56601
Closed
bdhirsh wants to merge 3 commits intogh/bdhirsh/107/basefrom
Closed
Reland of "D27708346: generate xla codegen in-tree"#56601bdhirsh wants to merge 3 commits intogh/bdhirsh/107/basefrom
bdhirsh wants to merge 3 commits intogh/bdhirsh/107/basefrom
Conversation
Updating it to ensure that RegistrationDeclarations.yaml is completely unchanged This reverts commit 90e532f. [ghstack-poisoned]
Contributor
💊 CI failures summary and remediationsAs of commit 61542aa (more details on the Dr. CI page):
1 failure not recognized by patterns:
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
This is a re-land of #55050, but with a small change (pasted the patch below). I confirmed that RegistrationDeclarations.yaml doesn't change after this PR with the following: ``` diff -Naur build/aten/src/ATen/RegistrationDeclarations.h ../pytorch/build/aten/src/ATen/RegistrationDeclarations.h ``` patch: ``` --- a/tools/codegen/api/types.py +++ b/tools/codegen/api/types.py @@ -41,12 +41,12 @@ tensorListT = BaseCppType('at', 'TensorList') dimnameT = BaseCppType('at', 'Dimname') dimnameListT = BaseCppType('at', 'DimnameList') layoutT = BaseCppType('at', 'Layout') -deviceT = BaseCppType('c10', 'Device') +deviceT = BaseCppType('at', 'Device') scalarT = BaseCppType('at', 'Scalar') memoryFormatT = BaseCppType('at', 'MemoryFormat') qschemeT = BaseCppType('at', 'QScheme') storageT = BaseCppType('at', 'Storage') -streamT = BaseCppType('', 'Stream') +streamT = BaseCppType('at', 'Stream') intArrayRefT = BaseCppType('at', 'IntArrayRef') tensorOptionsT = BaseCppType('at', 'TensorOptions') typeAndSizeT = BaseCppType('torch::autograd::generated', 'TypeAndSize') ``` I must have accidentally added the `c10` when I was debugging, to reduce the number of byte-for-byte changes in `aten_xla_type_default.cpp`. That caused a change to `RegistrationDeclarations.yaml`, which is BC-breaking for any downstream consumers. Updating it to ensure that RegistrationDeclarations.yaml is completely unchanged This reverts commit 90e532f. Differential Revision: [D27915305](https://our.internmc.facebook.com/intern/diff/D27915305) [ghstack-poisoned]
This is a re-land of #55050, but with a small change (pasted the patch below). I confirmed that RegistrationDeclarations.yaml doesn't change after this PR with the following: ``` diff -Naur build/aten/src/ATen/RegistrationDeclarations.h ../pytorch/build/aten/src/ATen/RegistrationDeclarations.h ``` patch: ``` --- a/tools/codegen/api/types.py +++ b/tools/codegen/api/types.py @@ -41,12 +41,12 @@ tensorListT = BaseCppType('at', 'TensorList') dimnameT = BaseCppType('at', 'Dimname') dimnameListT = BaseCppType('at', 'DimnameList') layoutT = BaseCppType('at', 'Layout') -deviceT = BaseCppType('c10', 'Device') +deviceT = BaseCppType('at', 'Device') scalarT = BaseCppType('at', 'Scalar') memoryFormatT = BaseCppType('at', 'MemoryFormat') qschemeT = BaseCppType('at', 'QScheme') storageT = BaseCppType('at', 'Storage') -streamT = BaseCppType('', 'Stream') +streamT = BaseCppType('at', 'Stream') intArrayRefT = BaseCppType('at', 'IntArrayRef') tensorOptionsT = BaseCppType('at', 'TensorOptions') typeAndSizeT = BaseCppType('torch::autograd::generated', 'TypeAndSize') ``` I must have accidentally added the `c10` when I was debugging, to reduce the number of byte-for-byte changes in `aten_xla_type_default.cpp`. That caused a change to `RegistrationDeclarations.yaml`, which is BC-breaking for any downstream consumers. Updating it to ensure that RegistrationDeclarations.yaml is completely unchanged This reverts commit 90e532f. Differential Revision: [D27915305](https://our.internmc.facebook.com/intern/diff/D27915305) [ghstack-poisoned]
Contributor
krshrimali
pushed a commit
to krshrimali/pytorch
that referenced
this pull request
May 19, 2021
Summary: Pull Request resolved: pytorch#56601 Updating it to ensure that RegistrationDeclarations.yaml is completely unchanged This reverts commit 90e532f. Test Plan: Imported from OSS Reviewed By: ailzhang Differential Revision: D27915305 Pulled By: bdhirsh fbshipit-source-id: 491a025c44221690dad849f9a2166934130c0fec
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a re-land of #55050, but with a small change (pasted the patch below).
I confirmed that RegistrationDeclarations.yaml doesn't change after this PR with the following:
patch:
I must have accidentally added the
c10when I was debugging, to reduce the number of byte-for-byte changes inaten_xla_type_default.cpp. That caused a change toRegistrationDeclarations.yaml, which is BC-breaking for any downstream consumers.Stack from ghstack:
Updating it to ensure that RegistrationDeclarations.yaml is completely
unchanged
This reverts commit 90e532f.
Differential Revision: D27915305