[profiler] Expand Kineto platform support by ilia-cher · Pull Request #56323 · pytorch/pytorch

ilia-cher · 2021-04-17T05:46:40Z

Summary:
Expanding support to all builds

Test Plan:
CI

facebook-github-bot · 2021-04-17T05:46:47Z

💊 CI failures summary and remediations

As of commit 13c5850 (more details on the Dr. CI page):

✅ None of the CI failures appear to be your fault 💚

1/1 broken upstream at merge base 76d9070 on May 04 from 2:23pm to 4:01pm

🚧 1 fixed upstream failure:

These were probably caused by upstream breakages that were already fixed.

Please rebase on the viable/strict branch (expand for instructions)

If your commit is older than viable/strict, run these commands:

git fetch https://github.com/pytorch/pytorch viable/strict
git rebase FETCH_HEAD

test on May 04 from 2:23pm to 4:01pm (76d9070 - 8c9e42b)
- 🔁 rerun

This comment was automatically generated by Dr. CI (expand for details).

Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

codecov · 2021-04-20T00:46:54Z

Codecov Report

Merging #56323 (13c5850) into master (76d9070) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #56323      +/-   ##
==========================================
- Coverage   76.95%   76.93%   -0.02%     
==========================================
  Files        1968     1968              
  Lines      196252   196251       -1     
==========================================
- Hits       151017   150987      -30     
- Misses      45235    45264      +29

facebook-github-bot · 2021-05-04T02:54:35Z

@ilia-cher has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

.circleci/scripts/binary_ios_upload.sh

android/pytorch_android/CMakeLists.txt

malfet · 2021-05-04T04:31:27Z

android/pytorch_android/CMakeLists.txt

  import_static_lib(libcpuinfo)
  import_static_lib(libclog)
+  import_static_lib(libfmt)
+  import_static_lib(libkineto)


Can you please elaborate in PR how kineto is used in Android?

same as in other builds - using torch.profiler context manager and saving the trace file

Hmm, but I don't think Android builds have any Python bindings enabled in them, are they?

Probably not, but going forward we should be able to use profiler with c++ APIs.

sg, let's keep in mind future C++ api, but for now, as discussed, will split the mobile build support in a separate pr

android/pytorch_android/CMakeLists.txt

cmake/Dependencies.cmake

torch/csrc/autograd/profiler_kineto.h

facebook-github-bot · 2021-05-04T15:18:20Z

@ilia-cher has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

facebook-github-bot · 2021-05-04T15:20:07Z

@ilia-cher has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

facebook-github-bot · 2021-05-04T15:22:07Z

@ilia-cher has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

facebook-github-bot · 2021-05-04T15:25:53Z

@ilia-cher has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

facebook-github-bot · 2021-05-04T15:27:22Z

@ilia-cher has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Summary: Expanding support to all builds Test Plan: CI

facebook-github-bot · 2021-05-04T21:40:59Z

@ilia-cher has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

ilia-cher · 2021-05-04T22:21:16Z

updated to exclude android and ios builds

facebook-github-bot · 2021-05-05T22:01:27Z

@ilia-cher merged this pull request in 65fad0e.

Summary: Pull Request resolved: pytorch#57333 Pull Request resolved: pytorch/kineto#193 Expanding Kineto support to more platforms Test Plan: CI and OSS CI: pytorch#56323 Reviewed By: gdankel Differential Revision: D27873669 fbshipit-source-id: 4a72a589f958440cbfff247751b7f4e1910a10c7

Summary: Expanding support to all builds Pull Request resolved: pytorch#56323 Test Plan: CI Reviewed By: malfet Differential Revision: D28171478 Pulled By: ilia-cher fbshipit-source-id: 16bc752d1be3cbaeda5316f5d8a687ae05a83d22

ilia-cher requested review from albanD and soulitzer as code owners April 17, 2021 05:46

facebook-github-bot added the cla signed label Apr 17, 2021

ilia-cher force-pushed the ci-all/kineto_exp branch 16 times, most recently from 5c0155c to 5e8293b Compare April 19, 2021 19:15

ilia-cher force-pushed the ci-all/kineto_exp branch 6 times, most recently from 96a857e to 628506b Compare April 23, 2021 00:40

ilia-cher mentioned this pull request Apr 28, 2021

[profiler] Expand Kineto platform support #56124

Closed

ilia-cher force-pushed the ci-all/kineto_exp branch 2 times, most recently from 0a339e7 to c3cebc3 Compare April 28, 2021 21:06

ilia-cher requested review from malfet and ngimel May 4, 2021 00:39

malfet requested changes May 4, 2021

View reviewed changes

malfet reviewed May 4, 2021

View reviewed changes

torch/csrc/autograd/profiler_kineto.h Outdated Show resolved Hide resolved

ilia-cher force-pushed the ci-all/kineto_exp branch 2 times, most recently from 8df01bd to 0166137 Compare May 4, 2021 15:14

ilia-cher force-pushed the ci-all/kineto_exp branch from 0166137 to 3250c25 Compare May 4, 2021 15:19

ilia-cher force-pushed the ci-all/kineto_exp branch from 3250c25 to c88c3d9 Compare May 4, 2021 15:25

ilia-cher requested a review from malfet May 4, 2021 15:48

ilia-cher force-pushed the ci-all/kineto_exp branch from c88c3d9 to 5e603db Compare May 4, 2021 21:36

Expand Kineto platform support

13c5850

Summary: Expanding support to all builds Test Plan: CI

ilia-cher force-pushed the ci-all/kineto_exp branch from 5e603db to 13c5850 Compare May 4, 2021 21:38

malfet approved these changes May 5, 2021

View reviewed changes

facebook-github-bot closed this in 65fad0e May 5, 2021

facebook-github-bot added the Merged label May 5, 2021

ilia-cher changed the title ~~Expand Kineto platform support (ci-all)~~ [profiler] Expand Kineto platform support May 25, 2021

github-actions bot deleted the ci-all/kineto_exp branch February 11, 2024 01:56

Conversation

ilia-cher commented Apr 17, 2021

Uh oh!

facebook-github-bot commented Apr 17, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💊 CI failures summary and remediations

🚧 1 fixed upstream failure:

Uh oh!

codecov bot commented Apr 20, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

facebook-github-bot commented May 4, 2021

Uh oh!

Uh oh!

Uh oh!

malfet May 4, 2021

Choose a reason for hiding this comment

Uh oh!

ilia-cher May 4, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

malfet May 4, 2021

Choose a reason for hiding this comment

Uh oh!

ngimel May 4, 2021

Choose a reason for hiding this comment

Uh oh!

ilia-cher May 4, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

facebook-github-bot commented May 4, 2021

Uh oh!

facebook-github-bot commented May 4, 2021

Uh oh!

facebook-github-bot commented May 4, 2021

Uh oh!

facebook-github-bot commented May 4, 2021

Uh oh!

facebook-github-bot commented May 4, 2021

Uh oh!

facebook-github-bot commented May 4, 2021

Uh oh!

ilia-cher commented May 4, 2021

Uh oh!

facebook-github-bot commented May 5, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

facebook-github-bot commented Apr 17, 2021 •

edited

Loading

codecov bot commented Apr 20, 2021 •

edited

Loading

ilia-cher May 4, 2021 •

edited

Loading