Update perf test baseline with every master commit#5605
Merged
ezyang merged 2 commits intopytorch:masterfrom Mar 7, 2018
Merged
Update perf test baseline with every master commit#5605ezyang merged 2 commits intopytorch:masterfrom
ezyang merged 2 commits intopytorch:masterfrom
Conversation
Contributor
|
Do I understand correctly that once this is merged the perf numbers will no longer be checked in to the remote, but will only update some local copy in our CI instances? |
ezyang
reviewed
Mar 7, 2018
| export PYTORCH_COMMIT_ID=$(git log --format="%H" -n 1) | ||
|
|
||
| # Get baseline file from https://github.com/yf225/perf-tests | ||
| cp /var/lib/jenkins/host-workspace/perf_test_numbers_cpu.json perf_test_numbers_cpu.json |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Contributor
|
It's not going to be a local copy; it'll be an honest to goodness Git repo on GitHub that the CI will push to. |
ezyang
approved these changes
Mar 7, 2018
Contributor
|
There’s no push in the script so I wasn’t sure. So it will be a repo parallel to our main one, but with extra perf details? |
Contributor
Author
|
@apaszke The repo is at https://github.com/yf225/perf-tests for now, and we will move it into the PyTorch org when we are ready to do so |
Contributor
|
Perfect 👍 I just wanted to clarify it's not pytorch/pytorch 😄 |
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
* Update perf test baseline with every master commit * Get perf test data from repo for local runs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a commit is merged onto master, we will take its perf test numbers as new baseline for master.
I will add a graph to track the perf test numbers as the next step.