Skip to content

Update perf test baseline with every master commit#5605

Merged
ezyang merged 2 commits intopytorch:masterfrom
yf225:perf_number
Mar 7, 2018
Merged

Update perf test baseline with every master commit#5605
ezyang merged 2 commits intopytorch:masterfrom
yf225:perf_number

Conversation

@yf225
Copy link
Copy Markdown
Contributor

@yf225 yf225 commented Mar 7, 2018

If a commit is merged onto master, we will take its perf test numbers as new baseline for master.

I will add a graph to track the perf test numbers as the next step.

@apaszke
Copy link
Copy Markdown
Contributor

apaszke commented Mar 7, 2018

Do I understand correctly that once this is merged the perf numbers will no longer be checked in to the remote, but will only update some local copy in our CI instances?

Comment thread .jenkins/short-perf-test-cpu.sh Outdated
export PYTORCH_COMMIT_ID=$(git log --format="%H" -n 1)

# Get baseline file from https://github.com/yf225/perf-tests
cp /var/lib/jenkins/host-workspace/perf_test_numbers_cpu.json perf_test_numbers_cpu.json

This comment was marked as off-topic.

@ezyang
Copy link
Copy Markdown
Contributor

ezyang commented Mar 7, 2018

It's not going to be a local copy; it'll be an honest to goodness Git repo on GitHub that the CI will push to.

@apaszke
Copy link
Copy Markdown
Contributor

apaszke commented Mar 7, 2018

There’s no push in the script so I wasn’t sure. So it will be a repo parallel to our main one, but with extra perf details?

@yf225
Copy link
Copy Markdown
Contributor Author

yf225 commented Mar 7, 2018

@apaszke The repo is at https://github.com/yf225/perf-tests for now, and we will move it into the PyTorch org when we are ready to do so

@apaszke
Copy link
Copy Markdown
Contributor

apaszke commented Mar 7, 2018

Perfect 👍 I just wanted to clarify it's not pytorch/pytorch 😄

@ezyang ezyang merged commit 9ebfece into pytorch:master Mar 7, 2018
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 24, 2026
* Update perf test baseline with every master commit

* Get perf test data from repo for local runs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants