remove legacy workaround for hinge embedding loss reference fn#5596
Merged
ezyang merged 1 commit intopytorch:masterfrom Mar 7, 2018
Merged
remove legacy workaround for hinge embedding loss reference fn#5596ezyang merged 1 commit intopytorch:masterfrom
ezyang merged 1 commit intopytorch:masterfrom
Conversation
zou3519
approved these changes
Mar 6, 2018
Contributor
zou3519
left a comment
There was a problem hiding this comment.
LGTM as long as the CI passes
Contributor
|
@pytorchbot retest this please |
2 similar comments
Contributor
|
@pytorchbot retest this please |
Contributor
|
@pytorchbot retest this please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After the tensor variable merge, this workaround should no longer be necessary.