release() does not need to be virtual#5594
Merged
soumith merged 1 commit intopytorch:masterfrom Mar 7, 2018
Merged
Conversation
Only the destructor `~Retainable()` needs to be virtual.
Contributor
|
Does this have to do with the |
goldsborough
approved these changes
Mar 6, 2018
Member
Author
|
No, it just marginally speeds up things by a few ns |
Member
Author
|
@pytorchbot retest this please |
2 similar comments
Contributor
|
@pytorchbot retest this please |
Contributor
|
@pytorchbot retest this please |
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
Only the destructor `~Retainable()` needs to be virtual.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only the destructor
~Retainable()needs to be virtual.