add _to_cpu() operator by bdhirsh · Pull Request #55795 · pytorch/pytorch

bdhirsh · 2021-04-12T17:00:36Z

description coming soon

Stack from ghstack:

add a boxed CPU fallback kernel #58065 add a boxed CPU fallback kernel
remove xla-specific stuff from codegen (minus CPU fallback) #58064 remove xla-specific stuff from codegen (minus CPU fallback)
generate inplace/out kernels for xla #57510 generate inplace/out kernels for xla
[codegen] split out backend-specific information from NativeFunction in the model #57361 [codegen] split out backend-specific information from NativeFunction in the model
remove bridge API from codegen #55796 remove bridge API from codegen
[external codegen] better yaml error messaging, added explicit error message tests #56597 [external codegen] better yaml error messaging, added explicit error message tests
add _to_cpu() operator #55795 add _to_cpu() operator

Differential Revision: D28474365

[ghstack-poisoned]

facebook-github-bot · 2021-04-12T17:00:46Z

💊 CI failures summary and remediations

As of commit 71bfeab (more details on the Dr. CI page):

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

ezyang

Two main thoughts:

I'm not sure I'd deify this with a non-underscored name. torch.to_XXX doesn't really have any precedent (I see you stuck this next to to_dense but that's a method)
There needs to be an explanation somewhere of WHY you would use this operator (it doesn't matter for eager backends, but it matters for lazy)

bdhirsh · 2021-04-12T21:24:53Z

Two main thoughts:

I'm not sure I'd deify this with a non-underscored name. torch.to_XXX doesn't really have any precedent (I see you stuck this next to to_dense but that's a method)

There needs to be an explanation somewhere of WHY you would use this operator (it doesn't matter for eager backends, but it matters for lazy)

Totally agreed with both of those points. I'll add comments soon- I mostly threw this PR up so I could start trying to get rid of the bridge API and let CI tell me if anything breaks, probably should have thrown a comment in the description.

The torch.to_cpu definitely needs documentation. I'm not sure the two overloads that I added deserve entries in the C++ API- I might just put them directly in the codegen template, since they're really just convenience helpers.

[ghstack-poisoned]

description coming soon [ghstack-poisoned]

ghstack-source-id: 218c1b7 Pull Request resolved: pytorch#55795

description coming soon [ghstack-poisoned]

ghstack-source-id: a23b00b Pull Request resolved: pytorch#55795

description coming soon [ghstack-poisoned]

bdhirsh · 2021-05-17T12:46:19Z

@bdhirsh has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

facebook-github-bot · 2021-05-17T19:26:03Z

@bdhirsh merged this pull request in 4dc1b8e.

Summary: Pull Request resolved: pytorch#55795 description coming soon Test Plan: Imported from OSS Reviewed By: navahgar Differential Revision: D28474365 Pulled By: bdhirsh fbshipit-source-id: 0704d7ce354308601a0af9ab48851459f34ce7a0

Summary: Pull Request resolved: #55795 description coming soon Test Plan: Imported from OSS Reviewed By: navahgar Differential Revision: D28474365 Pulled By: bdhirsh fbshipit-source-id: 0704d7ce354308601a0af9ab48851459f34ce7a0

add to_cpu() operator

0d79a13

[ghstack-poisoned]

bdhirsh requested a review from ezyang as a code owner April 12, 2021 17:00

facebook-github-bot added the cla signed label Apr 12, 2021

bdhirsh mentioned this pull request Apr 12, 2021

Return a CType instead of a string for returns, beef up CType #55046

Closed

This was referenced Apr 12, 2021

add C++ namespacing logic to ctypes #55047

Closed

split out NamedCType from CType. Remove direct string comparison from autograd codegen #55334

Closed

generate xla codegen in-tree #55050

Closed

remove bridge API from codegen #55796

Closed

ezyang approved these changes Apr 12, 2021

View reviewed changes

samestep mentioned this pull request Apr 12, 2021

"Add annotations" workflow fails when base branch is pinned to old commit #55810

Closed

bdhirsh added 8 commits April 12, 2021 15:04

Update on "add to_cpu() operator"

2ada3d0

[ghstack-poisoned]

Update on "add to_cpu() operator"

1dc7857

[ghstack-poisoned]

Update on "add to_cpu() operator"

7736d84

[ghstack-poisoned]

Update on "add to_cpu() operator"

38bc128

[ghstack-poisoned]

Update on "add to_cpu() operator"

1d3191a

[ghstack-poisoned]

Update on "add to_cpu() operator"

4b7bfb6

[ghstack-poisoned]

Update on "add to_cpu() operator"

dabce4c

[ghstack-poisoned]

Update on "add to_cpu() operator"

e251e14

[ghstack-poisoned]

bdhirsh changed the title ~~add to_cpu() operator~~ add _to_cpu() operator Apr 15, 2021

bdhirsh added 7 commits April 15, 2021 15:36

Update on "add _to_cpu() operator"

837687d

description coming soon [ghstack-poisoned]

Update on "add _to_cpu() operator"

2edab40

description coming soon [ghstack-poisoned]

Update on "add _to_cpu() operator"

89d7ab9

description coming soon [ghstack-poisoned]

Update on "add _to_cpu() operator"

13d8d76

description coming soon [ghstack-poisoned]

Update on "add _to_cpu() operator"

46b4896

description coming soon [ghstack-poisoned]

Update on "add _to_cpu() operator"

99fe7d2

description coming soon [ghstack-poisoned]

Update on "add _to_cpu() operator"

449d05e

description coming soon [ghstack-poisoned]

bdhirsh mentioned this pull request Apr 21, 2021

[external codegen] better yaml error messaging, added explicit error message tests #56597

Closed

Update on "add _to_cpu() operator"

1054f53

description coming soon [ghstack-poisoned]

This was referenced Apr 23, 2021

add to ExternalBackendFunction data model #56834

Closed

generate in-place/out wrappers for external kernels #56835

Closed

bdhirsh added 2 commits April 23, 2021 16:24

Update on "add _to_cpu() operator"

788dd66

description coming soon [ghstack-poisoned]

Update on "add _to_cpu() operator"

da73317

description coming soon [ghstack-poisoned]

bdhirsh mentioned this pull request Apr 26, 2021

[do not merge] temporary fix #56962

Closed

Update on "add _to_cpu() operator"

6f37a2e

description coming soon [ghstack-poisoned]

bdhirsh mentioned this pull request Apr 30, 2021

[codegen] split out backend-specific information from NativeFunction in the model #57361

Closed

dgl-intel pushed a commit to dgl-intel/pytorch that referenced this pull request Apr 30, 2021

add to_cpu() operator

280e210

ghstack-source-id: 218c1b7 Pull Request resolved: pytorch#55795

Update on "add _to_cpu() operator"

fffc549

description coming soon [ghstack-poisoned]

bdhirsh mentioned this pull request May 3, 2021

generate inplace/out kernels for xla #57510

Closed

Update on "add _to_cpu() operator"

3021a73

description coming soon [ghstack-poisoned]

dgl-intel pushed a commit to dgl-intel/pytorch that referenced this pull request May 3, 2021

add to_cpu() operator

d7330a8

ghstack-source-id: a23b00b Pull Request resolved: pytorch#55795

bdhirsh added 2 commits May 4, 2021 13:19

Update on "add _to_cpu() operator"

42f8c46

description coming soon [ghstack-poisoned]

Update on "add _to_cpu() operator"

7d4d70f

description coming soon [ghstack-poisoned]

This was referenced May 11, 2021

remove xla-specific stuff from codegen (minus CPU fallback) #58064

Closed

add a boxed CPU fallback kernel #58065

Closed

bdhirsh added 2 commits May 12, 2021 07:05

Update on "add _to_cpu() operator"

260efb6

description coming soon [ghstack-poisoned]

Update on "add _to_cpu() operator"

71bfeab

description coming soon [ghstack-poisoned]

facebook-github-bot closed this in 4dc1b8e May 17, 2021

facebook-github-bot added the Merged label May 17, 2021

This was referenced May 20, 2021

Cherrypick xla codegen #58717

Closed

[v1.9.0] Release Tracker #58518

Closed

facebook-github-bot deleted the gh/bdhirsh/101/head branch May 21, 2021 14:17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add _to_cpu() operator#55795

add _to_cpu() operator#55795
bdhirsh wants to merge 26 commits intogh/bdhirsh/101/basefrom
gh/bdhirsh/101/head

bdhirsh commented Apr 12, 2021 •

edited

Loading

Uh oh!

facebook-github-bot commented Apr 12, 2021 •

edited

Loading

Uh oh!

ezyang left a comment

Uh oh!

bdhirsh commented Apr 12, 2021

Uh oh!

bdhirsh commented May 17, 2021

Uh oh!

facebook-github-bot commented May 17, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

bdhirsh commented Apr 12, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

facebook-github-bot commented Apr 12, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💊 CI failures summary and remediations

Uh oh!

ezyang left a comment

Choose a reason for hiding this comment

Uh oh!

bdhirsh commented Apr 12, 2021

Uh oh!

bdhirsh commented May 17, 2021

Uh oh!

facebook-github-bot commented May 17, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

bdhirsh commented Apr 12, 2021 •

edited

Loading

facebook-github-bot commented Apr 12, 2021 •

edited

Loading