Conversation
zdevito
approved these changes
Mar 5, 2018
Contributor
zdevito
left a comment
There was a problem hiding this comment.
Looks good! one minor question
| return c(TK_GLOBAL, range, std::move(idents)); | ||
| auto idents = parseList(TK_NOTHING, ',', TK_NOTHING, &Parser::parseIdent); | ||
| if (idents.empty()) | ||
| throw ErrorReport(range) << "global statement needs a list of variable names"; |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Contributor
Author
|
Fixed the comment and changed all uses of |
zdevito
reviewed
Mar 6, 2018
| // Now we *may* have an expression. | ||
| if (L.cur().kind != ']') { | ||
| second = c(TK_OPTION, range, {parseExp()}); | ||
| second = c(TK_NOTHING, range, {parseExp()}); |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This also makes the syntax recognized by the parser compatible with Python syntax, so it will allow us to reuse Python functions for script tests as well.