Move set_version_counter out of DifferentiableViewMeta constructor.#55653
Move set_version_counter out of DifferentiableViewMeta constructor.#55653ailzhang wants to merge 1 commit intogh/ailzhang/61/basefrom
Conversation
It's hard for me to understand that when we call `impl->set_autograd_meta(std::make_unique<DifferentiableViewMeta>` it has a side effect changing `impl->set_version_counter()` as well. I'd prefer this setter is called explicitly and it's easier for the followup refactor. [ghstack-poisoned]
💊 CI failures summary and remediationsAs of commit a3d6286 (more details on the Dr. CI page):
🕵️ 2 new failures recognized by patternsThe following CI failures do not appear to be due to upstream breakages:
|
It's hard for me to understand that when we call `impl->set_autograd_meta(std::make_unique<DifferentiableViewMeta>` it has a side effect changing `impl->set_version_counter()` as well. I'd prefer this setter is called explicitly and it's easier for the followup refactor. ghstack-source-id: 217bb61 Pull Request resolved: #55653
albanD
left a comment
There was a problem hiding this comment.
Why is this necessary?
Do we have a document that explains the new version counter logic and who is expected to set it and where?
|
@albanD This change is not necessary :P I just feel the side effect was a bit hard to understand during refactoring relevant code. Will send a few more PRs to show how the refactor looks like in the end state and then we can discuss whether we want this change or not :D. |
|
@pytorchbot retest this please |
|
Hi @ailzhang! Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours needs attention. You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
Stack from ghstack:
It's hard for me to understand that when we call
impl->set_autograd_meta(std::make_unique<DifferentiableViewMeta>ithas a side effect changing
impl->set_version_counter()as well.I'd prefer this setter is called explicitly and it's easier for the
followup refactor.
Differential Revision: D27669075