disable ibverbs build with env variable#5513
Merged
ezyang merged 3 commits intopytorch:masterfrom Mar 7, 2018
Merged
Conversation
Contributor
Author
|
@pytorchbot retest this please |
apaszke
reviewed
Mar 2, 2018
|
|
||
| DEBUG = check_env_flag('DEBUG') | ||
| ENABLE_IBVERBS_ENV = check_env_flag('WITH_GLOO_IBVERBS') | ||
| WITH_GLOO_IBVERBS = WITH_GLOO_IBVERBS and ENABLE_IBVERBS_ENV |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
0bf6d0b to
2f60a11
Compare
Contributor
Author
|
@pytorchbot retest this please |
apaszke
reviewed
Mar 3, 2018
Contributor
apaszke
left a comment
There was a problem hiding this comment.
I don’t think this is a good fix. In general we want people to be able to say that they forcefully want to build ibverbs even when we can’t auto detect the program, and we also want them to be able to forbid us from doing this. So it seems like what we should do is:
- if the env variable is specified, use its value to determine what to do
- otherwise use the heuristic we have (
should_build_ib)
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
if the env variable is specified, use its value to determine what to do otherwise use the heuristic we have (should_build_ib)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to fix #5504
Disable ibverbs build with environment variable.