Skip to content

Fix wrong changes from #54103#54610

Closed
albanD wants to merge 2 commits intogh/albanD/74/basefrom
gh/albanD/74/head
Closed

Fix wrong changes from #54103#54610
albanD wants to merge 2 commits intogh/albanD/74/basefrom
gh/albanD/74/head

Conversation

@albanD
Copy link
Copy Markdown
Collaborator

@albanD albanD commented Mar 24, 2021

The .is_view() method actually only refers to backward mode views
This is not a problem right now in master (and thus I didn't revert the other PR) because nothing creates forward AD views.

Stack from ghstack:

Differential Revision: D27396756

[ghstack-poisoned]
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Mar 24, 2021

💊 CI failures summary and remediations

As of commit ebd9f4e (more details on the Dr. CI page):


  • 1/1 failures possibly* introduced in this PR
    • 1/1 non-scanned failure(s)

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Copy link
Copy Markdown
Contributor

@soulitzer soulitzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

The `.is_view()` method actually only refers to backward mode views
This is not a problem right now in master (and thus I didn't revert the other PR) because nothing creates forward AD views.




[ghstack-poisoned]
albanD added a commit to albanD/pytorch that referenced this pull request Mar 29, 2021
ghstack-source-id: b26a8be
Pull Request resolved: pytorch#54610
@facebook-github-bot
Copy link
Copy Markdown
Contributor

@albanD merged this pull request in 5e72571.

@facebook-github-bot facebook-github-bot deleted the gh/albanD/74/head branch April 9, 2021 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants