Port NumPy typing testing style to PyTorch#54234
Closed
guilhermeleobas wants to merge 9 commits intopytorch:masterfrom
guilhermeleobas:test_typing
Closed
Port NumPy typing testing style to PyTorch#54234guilhermeleobas wants to merge 9 commits intopytorch:masterfrom guilhermeleobas:test_typing
guilhermeleobas wants to merge 9 commits intopytorch:masterfrom
guilhermeleobas:test_typing
Conversation
Contributor
💊 CI failures summary and remediationsAs of commit d1cacd6 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
Collaborator
Author
|
Hi @rgommers, can you do an initial review? I'll add more examples to the |
Codecov Report
@@ Coverage Diff @@
## master #54234 +/- ##
==========================================
+ Coverage 77.38% 77.44% +0.05%
==========================================
Files 1896 1893 -3
Lines 186911 186081 -830
==========================================
- Hits 144646 144111 -535
+ Misses 42265 41970 -295 |
rgommers
requested changes
Mar 30, 2021
Collaborator
rgommers
left a comment
There was a problem hiding this comment.
Thanks @guilhermeleobas, overall this looks good. A number of small things to fix. Would also be good to merge with master to get a fresh CI run.
|
|
||
|
|
||
| def _strip_filename(msg: str) -> str: | ||
| """Strip the filename from a mypy message.""" |
Collaborator
Author
|
Hi Ralf, thanks for the review! I've addressed all your comments |
rgommers
approved these changes
Apr 9, 2021
Collaborator
rgommers
left a comment
There was a problem hiding this comment.
Thanks @guilhermeleobas, this LGTM now.
malfet
approved these changes
Apr 9, 2021
Contributor
|
@malfet has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
walterddr
approved these changes
Apr 9, 2021
Contributor
krshrimali
pushed a commit
to krshrimali/pytorch
that referenced
this pull request
May 19, 2021
Summary: This is a follow-up PR of pytorch#52408 and includes the `pass/` and `fail/` directories. Pull Request resolved: pytorch#54234 Reviewed By: walterddr Differential Revision: D27681410 Pulled By: malfet fbshipit-source-id: e6817df77c758f4c1295ea62613106c71cfd3fc3
malfet
added a commit
that referenced
this pull request
Oct 17, 2023
`test_typing.py` was written to use `pytest` in #54234 which unfortunately rendered it incompatible with run_test.py, and therefore it was not running in CI all this time. In this PR, same functionality is re-written using unittest framework, and `parametrize` from `torch.testing._internal._common_utils`. Disable `fail/bitwise_ops.py` as it regressed at some point as well as one of examples in `namedtuple.py` as `torch.linalg.qr` type is no longer revealed correctly. [ghstack-poisoned]
malfet
added a commit
that referenced
this pull request
Oct 17, 2023
`test_typing.py` was written to use `pytest` in #54234 which unfortunately rendered it incompatible with run_test.py, and therefore it was not running in CI all this time. In this PR, same functionality is re-written using unittest framework, and `parametrize` from `torch.testing._internal._common_utils`. Disable `fail/bitwise_ops.py` as it regressed at some point as well as one of examples in `namedtuple.py` as `torch.linalg.qr` type is no longer revealed correctly. [ghstack-poisoned]
malfet
added a commit
that referenced
this pull request
Oct 17, 2023
`test_typing.py` was written to use `pytest` in #54234 which unfortunately rendered it incompatible with run_test.py, and therefore it was not running in CI all this time. In this PR, same functionality is re-written using unittest framework, and `parametrize` from `torch.testing._internal._common_utils`. Disable `fail/bitwise_ops.py` as it regressed at some point as well as one of examples in `namedtuple.py` as `torch.linalg.qr` type is no longer revealed correctly. [ghstack-poisoned]
malfet
added a commit
that referenced
this pull request
Oct 17, 2023
`test_typing.py` was written to use `pytest` in #54234 which unfortunately rendered it incompatible with run_test.py, and therefore it was not running in CI all this time. In this PR, same functionality is re-written using unittest framework, and `parametrize` from `torch.testing._internal._common_utils`. Valid `test_typing.py` with ufmt Disable `fail/bitwise_ops.py` and `pass/jit.py` as it regressed at some point as well as one of examples in `namedtuple.py` as `torch.linalg.qr` type is no longer revealed correctly. [ghstack-poisoned]
malfet
added a commit
that referenced
this pull request
Oct 17, 2023
`test_typing.py` was written to use `pytest` in #54234 which unfortunately rendered it incompatible with run_test.py, and therefore it was not running in CI all this time. In this PR, same functionality is re-written using unittest framework, and `parametrize` from `torch.testing._internal._common_utils`. Valid `test_typing.py` with ufmt Disable `fail/bitwise_ops.py` and `pass/jit.py` as it regressed at some point as well as one of examples in `namedtuple.py` as `torch.linalg.qr` type is no longer revealed correctly. [ghstack-poisoned]
pytorchmergebot
pushed a commit
that referenced
this pull request
Oct 18, 2023
`test_typing.py` was written to use `pytest` in #54234 which unfortunately rendered it incompatible with run_test.py, and therefore it was not running in CI all this time. In this PR, same functionality is re-written using unittest framework, and `parametrize` from `torch.testing._internal._common_utils`. Valid `test_typing.py` with ufmt Disable `fail/bitwise_ops.py` and `pass/jit.py` as it regressed at some point as well as one of examples in `namedtuple.py` as `torch.linalg.qr` type is no longer revealed correctly. Pull Request resolved: #111428 Approved by: https://github.com/clee2000
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
Summary: This is a follow-up PR of pytorch#52408 and includes the `pass/` and `fail/` directories. Pull Request resolved: pytorch#54234 Reviewed By: walterddr Differential Revision: D27681410 Pulled By: malfet fbshipit-source-id: e6817df77c758f4c1295ea62613106c71cfd3fc3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up PR of #52408 and includes the
pass/andfail/directories.