[ci-all] [do not merge] will be closed by 53104#53992
Closed
[ci-all] [do not merge] will be closed by 53104#53992
Conversation
Contributor
💊 CI failures summary and remediationsAs of commit d52f95d (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
1 task
Contributor
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
…decomposition (pytorch#53104) Summary: This PR adds cusolver potrf and potrfBatched to the backend of torch.cholesky and torch.linalg.cholesky. Cholesky heuristics: - Use cusolver potrf for batch_size 1 - Use magma_xpotrf_batched for batch_size >= 2 - if magma is not available, use loop of cusolver potrf for batch_size >= 2 cusolver potrf batched currently has some nan output issue, we will switch to cusolver potrf batched after it's fixed See also pytorch#42666 pytorch#47953 Todo: - [x] benchmark and heuristic Close pytorch#53992 Pull Request resolved: pytorch#53104 Reviewed By: agolynski Differential Revision: D27113963 Pulled By: mruberry fbshipit-source-id: 1429f63891cfc6176f9d8fdeb5c3b0617d750803
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #{issue number}