Skip to content

Skips test_linalg_lstsq on ROCm#53977

Closed
mruberry wants to merge 3 commits intomasterfrom
lstsq_rocm
Closed

Skips test_linalg_lstsq on ROCm#53977
mruberry wants to merge 3 commits intomasterfrom
lstsq_rocm

Conversation

@mruberry
Copy link
Copy Markdown
Collaborator

@mruberry mruberry commented Mar 14, 2021

This test is flaky (tracked in #53976). This PR skips it to let the rest of the ROCm CI run.

cc @nikitaved

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Mar 14, 2021

💊 CI failures summary and remediations

As of commit cbaaf50 (more details on the Dr. CI page):


💚 💚 Looks good so far! There are no failures yet. 💚 💚


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Copy link
Copy Markdown
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mruberry has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@mruberry mruberry requested a review from ngimel March 14, 2021 04:59
@mruberry mruberry changed the title Skips test_lstsq on ROCm Skips test_linalg_lstsq on ROCm Mar 14, 2021
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 14, 2021

Codecov Report

Merging #53977 (cbaaf50) into master (84af0c7) will decrease coverage by 0.42%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #53977      +/-   ##
==========================================
- Coverage   77.33%   76.91%   -0.43%     
==========================================
  Files        1887     1887              
  Lines      184768   184768              
==========================================
- Hits       142890   142106     -784     
- Misses      41878    42662     +784     

Copy link
Copy Markdown
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mruberry has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Copy Markdown
Contributor

@mruberry merged this pull request in 319ab58.

xsacha pushed a commit to xsacha/pytorch that referenced this pull request Mar 31, 2021
Summary:
This test is flaky (tracked in pytorch#53976). This PR skips it to let the rest of the ROCm CI run.

cc nikitaved

Pull Request resolved: pytorch#53977

Reviewed By: ngimel

Differential Revision: D27036705

Pulled By: mruberry

fbshipit-source-id: 5bae741fd2a68f23717cb3a7c8b73e97cfb23b5c
@mruberry mruberry deleted the lstsq_rocm branch May 2, 2021 00:21
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 24, 2026
Summary:
This test is flaky (tracked in pytorch#53976). This PR skips it to let the rest of the ROCm CI run.

cc nikitaved

Pull Request resolved: pytorch#53977

Reviewed By: ngimel

Differential Revision: D27036705

Pulled By: mruberry

fbshipit-source-id: 5bae741fd2a68f23717cb3a7c8b73e97cfb23b5c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants