Skip to content

[ONNX] Update embedding export wrt padding_idx#53931

Closed
BowenBao wants to merge 2 commits intopytorch:masterfrom
BowenBao:onnx_embedding_181
Closed

[ONNX] Update embedding export wrt padding_idx#53931
BowenBao wants to merge 2 commits intopytorch:masterfrom
BowenBao:onnx_embedding_181

Conversation

@BowenBao
Copy link
Copy Markdown
Collaborator

To be in-sync with #53447

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Mar 12, 2021

💊 CI failures summary and remediations

As of commit 254a353 (more details on the Dr. CI page):


💚 💚 Looks good so far! There are no failures yet. 💚 💚


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

@BowenBao
Copy link
Copy Markdown
Collaborator Author

cc @spandantiwari @malfet

Copy link
Copy Markdown
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@malfet has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@BowenBao
Copy link
Copy Markdown
Collaborator Author

I'll take a look at the conflict files

@BowenBao BowenBao force-pushed the onnx_embedding_181 branch from 672fee0 to d56ca31 Compare March 12, 2021 23:41
@malfet
Copy link
Copy Markdown
Contributor

malfet commented Mar 13, 2021

Thank you for the update!

Copy link
Copy Markdown
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@malfet has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 13, 2021

Codecov Report

Merging #53931 (254a353) into master (5b648ef) will decrease coverage by 0.00%.
The diff coverage is 20.00%.

@@            Coverage Diff             @@
##           master   #53931      +/-   ##
==========================================
- Coverage   77.30%   77.30%   -0.01%     
==========================================
  Files        1891     1891              
  Lines      184766   184771       +5     
==========================================
- Hits       142839   142836       -3     
- Misses      41927    41935       +8     

@malfet malfet added this to the 1.8.1 milestone Mar 15, 2021
Copy link
Copy Markdown
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@malfet has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Copy Markdown
Contributor

@malfet merged this pull request in ad8d1b2.

BowenBao added a commit to BowenBao/pytorch that referenced this pull request Mar 15, 2021
Summary:
To be in-sync with pytorch#53447

Pull Request resolved: pytorch#53931

Reviewed By: ngimel

Differential Revision: D27026616

Pulled By: malfet

fbshipit-source-id: 4c50b29fa296c90aeeeb1757bdaada92cbba33d4
malfet pushed a commit that referenced this pull request Mar 16, 2021
Summary:
To be in-sync with #53447

Pull Request resolved: #53931

Reviewed By: ngimel

Differential Revision: D27026616

Pulled By: malfet

fbshipit-source-id: 4c50b29fa296c90aeeeb1757bdaada92cbba33d4
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 24, 2026
Summary:
To be in-sync with pytorch#53447

Pull Request resolved: pytorch#53931

Reviewed By: ngimel

Differential Revision: D27026616

Pulled By: malfet

fbshipit-source-id: 4c50b29fa296c90aeeeb1757bdaada92cbba33d4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants