Fixed the size of the workspace array in functions calling LAPACK#53909
Closed
IvanYashchuk wants to merge 1 commit intopytorch:masterfrom
Closed
Fixed the size of the workspace array in functions calling LAPACK#53909IvanYashchuk wants to merge 1 commit intopytorch:masterfrom
IvanYashchuk wants to merge 1 commit intopytorch:masterfrom
Conversation
Contributor
💊 CI failures summary and remediationsAs of commit f4824c2 (more details on the Dr. CI page): ✅ None of the CI failures appear to be your fault 💚
🚧 3 fixed upstream failures:These were probably caused by upstream breakages that were already fixed.
Please rebase on the
|
mruberry
approved these changes
Mar 12, 2021
Collaborator
mruberry
left a comment
There was a problem hiding this comment.
Cool! Thanks @IvanYashchuk!
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@mruberry has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
xsacha
pushed a commit
to xsacha/pytorch
that referenced
this pull request
Mar 31, 2021
…torch#53909) Summary: The size of the workspace array should be max(1, lwork) according to LAPACK documentation. We got away with this previously because we tested only MKL which does a nice thing returning lwork >= 1. Fixes pytorch#53454 Pull Request resolved: pytorch#53909 Reviewed By: heitorschueroff Differential Revision: D27017025 Pulled By: mruberry fbshipit-source-id: 040a8cfb4bfb98db47d0b117938856d9483b20fb
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
…torch#53909) Summary: The size of the workspace array should be max(1, lwork) according to LAPACK documentation. We got away with this previously because we tested only MKL which does a nice thing returning lwork >= 1. Fixes pytorch#53454 Pull Request resolved: pytorch#53909 Reviewed By: heitorschueroff Differential Revision: D27017025 Pulled By: mruberry fbshipit-source-id: 040a8cfb4bfb98db47d0b117938856d9483b20fb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The size of the workspace array should be max(1, lwork) according to LAPACK documentation. We got away with this previously because we tested only MKL which does a nice thing returning lwork >= 1.
Fixes #53454