[nn] nn.Embedding : padding_idx doc update#53809
Closed
kshitij12345 wants to merge 1 commit intopytorch:masterfrom
Closed
[nn] nn.Embedding : padding_idx doc update#53809kshitij12345 wants to merge 1 commit intopytorch:masterfrom
padding_idx doc update#53809kshitij12345 wants to merge 1 commit intopytorch:masterfrom
Conversation
Contributor
💊 CI failures summary and remediationsAs of commit 4b4d0fa (more details on the Dr. CI page): ✅ None of the CI failures appear to be your fault 💚
🚧 2 fixed upstream failures:These were probably caused by upstream breakages that were already fixed.
Please rebase on the
|
jbschlosser
approved these changes
Mar 15, 2021
Contributor
jbschlosser
left a comment
There was a problem hiding this comment.
lgtm! Thanks for updating these docs :)
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@jbschlosser has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
|
@jbschlosser merged this pull request in c1a3962. |
malfet
pushed a commit
to malfet/pytorch
that referenced
this pull request
Mar 15, 2021
Summary: Follow-up of pytorch#53447 Reference: pytorch#53447 (comment) Pull Request resolved: pytorch#53809 Reviewed By: bdhirsh Differential Revision: D27049643 Pulled By: jbschlosser fbshipit-source-id: 623a2a254783b86391dc2b0777b688506adb4c0e
malfet
added a commit
that referenced
this pull request
Mar 16, 2021
Summary: Follow-up of #53447 Reference: #53447 (comment) Pull Request resolved: #53809 Reviewed By: bdhirsh Differential Revision: D27049643 Pulled By: jbschlosser fbshipit-source-id: 623a2a254783b86391dc2b0777b688506adb4c0e Co-authored-by: kshitij12345 <kshitijkalambarkar@gmail.com>
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
Summary: Follow-up of pytorch#53447 Reference: pytorch#53447 (comment) Pull Request resolved: pytorch#53809 Reviewed By: bdhirsh Differential Revision: D27049643 Pulled By: jbschlosser fbshipit-source-id: 623a2a254783b86391dc2b0777b688506adb4c0e
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up of #53447
Reference: #53447 (comment)