Skip to content

Removes trailing whitespace#53728

Closed
mruberry wants to merge 1 commit intomasterfrom
trailing_whitespace
Closed

Removes trailing whitespace#53728
mruberry wants to merge 1 commit intomasterfrom
trailing_whitespace

Conversation

@mruberry
Copy link
Copy Markdown
Collaborator

Fixes

Run (! git grep -I -l ' $' -- . ':(exclude)**/contrib/**' ':(exclude)third_party' || (echo "The above files have trailing spaces; please remove them"; false))
aten/src/ATen/native/cuda/BatchLinearAlgebra.cu
The above files have trailing spaces; please remove them
Error: Process completed with exit code 1.

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Mar 10, 2021

💊 CI failures summary and remediations

As of commit f077b82 (more details on the Dr. CI page):


  • 2/2 failures introduced in this PR

🕵️ 2 new failures recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See CircleCI build docker-pytorch-linux-bionic-rocm3.9-py3.6 (1/2)

Step: "Check if image should be built" (full log | diagnosis details | 🔁 rerun)

ERROR: Something has gone wrong and the previous image isn't available for the merge-base of your branch
+ docker manifest inspect 308535385114.dkr.ecr.us-east-1.amazonaws.com/pytorch/pytorch-linux-bionic-rocm3.9-py3.6:9e4caef77adcb160c0d1799dfa17cdd984106e12
no such manifest: 308535385114.dkr.ecr.us-east-1.amazonaws.com/pytorch/pytorch-linux-bionic-rocm3.9-py3.6:9e4caef77adcb160c0d1799dfa17cdd984106e12
++ git merge-base HEAD 5658ab5f778ca999521e7a98a9572251c56f2aaf
+ git rev-parse 5658ab5f778ca999521e7a98a9572251c56f2aaf:.circleci/docker
9e4caef77adcb160c0d1799dfa17cdd984106e12
+++ git merge-base HEAD 5658ab5f778ca999521e7a98a9572251c56f2aaf
++ git rev-parse 5658ab5f778ca999521e7a98a9572251c56f2aaf:.circleci/docker
+ PREVIOUS_DOCKER_TAG=9e4caef77adcb160c0d1799dfa17cdd984106e12
+ [[ 9e4caef77adcb160c0d1799dfa17cdd984106e12 = \9\e\4\c\a\e\f\7\7\a\d\c\b\1\6\0\c\0\d\1\7\9\9\d\f\a\1\7\c\d\d\9\8\4\1\0\6\e\1\2 ]]
+ echo 'ERROR: Something has gone wrong and the previous image isn'\''t available for the merge-base of your branch'
ERROR: Something has gone wrong and the previous image isn't available for the merge-base of your branch
+ echo '       contact the PyTorch team to restore the original images'
       contact the PyTorch team to restore the original images
+ exit 1


Exited with code exit status 1

See CircleCI build docker-pytorch-linux-bionic-rocm3.10-py3.6 (2/2)

Step: "Check if image should be built" (full log | diagnosis details | 🔁 rerun)

ERROR: Something has gone wrong and the previous image isn't available for the merge-base of your branch
+ docker manifest inspect 308535385114.dkr.ecr.us-east-1.amazonaws.com/pytorch/pytorch-linux-bionic-rocm3.10-py3.6:9e4caef77adcb160c0d1799dfa17cdd984106e12
no such manifest: 308535385114.dkr.ecr.us-east-1.amazonaws.com/pytorch/pytorch-linux-bionic-rocm3.10-py3.6:9e4caef77adcb160c0d1799dfa17cdd984106e12
++ git merge-base HEAD 5658ab5f778ca999521e7a98a9572251c56f2aaf
+ git rev-parse 5658ab5f778ca999521e7a98a9572251c56f2aaf:.circleci/docker
9e4caef77adcb160c0d1799dfa17cdd984106e12
+++ git merge-base HEAD 5658ab5f778ca999521e7a98a9572251c56f2aaf
++ git rev-parse 5658ab5f778ca999521e7a98a9572251c56f2aaf:.circleci/docker
+ PREVIOUS_DOCKER_TAG=9e4caef77adcb160c0d1799dfa17cdd984106e12
+ [[ 9e4caef77adcb160c0d1799dfa17cdd984106e12 = \9\e\4\c\a\e\f\7\7\a\d\c\b\1\6\0\c\0\d\1\7\9\9\d\f\a\1\7\c\d\d\9\8\4\1\0\6\e\1\2 ]]
+ echo 'ERROR: Something has gone wrong and the previous image isn'\''t available for the merge-base of your branch'
ERROR: Something has gone wrong and the previous image isn't available for the merge-base of your branch
+ echo '       contact the PyTorch team to restore the original images'
       contact the PyTorch team to restore the original images
+ exit 1


Exited with code exit status 1


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Copy link
Copy Markdown
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mruberry has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Copy Markdown
Contributor

@mruberry merged this pull request in b99b606.

facebook-github-bot pushed a commit that referenced this pull request Mar 10, 2021
Summary:
Meant to make tasks like #53728 easier. The `-n` flag enables line numbers, and the `-o` flag reduces noise by only showing the part of the line that matched (which in this case is just the trailing whitespace).

Pull Request resolved: #53733

Test Plan:
```
$ git checkout e937db5
```

Before:
```
$ (! git grep -I -l ' $' -- . ':(exclude)**/contrib/**' ':(exclude)third_party' || (echo "The above files have trailing spaces; please remove them"; false))
aten/src/ATen/native/cuda/BatchLinearAlgebra.cu
The above files have trailing spaces; please remove them
```

After:

```
$ (! git grep -I -no ' $' -- . ':(exclude)**/contrib/**' ':(exclude)third_party' || (echo "The above files have trailing spaces; please remove them"; false))
aten/src/ATen/native/cuda/BatchLinearAlgebra.cu:1972:
The above files have trailing spaces; please remove them
```

Reviewed By: mruberry

Differential Revision: D26953538

Pulled By: samestep

fbshipit-source-id: 5f7d48b79f1a02e5e5a09fe00316ec350cfc340e
xsacha pushed a commit to xsacha/pytorch that referenced this pull request Mar 31, 2021
Summary:
Fixes

```
Run (! git grep -I -l ' $' -- . ':(exclude)**/contrib/**' ':(exclude)third_party' || (echo "The above files have trailing spaces; please remove them"; false))
aten/src/ATen/native/cuda/BatchLinearAlgebra.cu
The above files have trailing spaces; please remove them
Error: Process completed with exit code 1.
```

Pull Request resolved: pytorch#53728

Reviewed By: ngimel

Differential Revision: D26953099

Pulled By: mruberry

fbshipit-source-id: 5f1ed2cd767de49447fcbd8e03cb3af7841cbcaf
xsacha pushed a commit to xsacha/pytorch that referenced this pull request Mar 31, 2021
Summary:
Meant to make tasks like pytorch#53728 easier. The `-n` flag enables line numbers, and the `-o` flag reduces noise by only showing the part of the line that matched (which in this case is just the trailing whitespace).

Pull Request resolved: pytorch#53733

Test Plan:
```
$ git checkout e937db5
```

Before:
```
$ (! git grep -I -l ' $' -- . ':(exclude)**/contrib/**' ':(exclude)third_party' || (echo "The above files have trailing spaces; please remove them"; false))
aten/src/ATen/native/cuda/BatchLinearAlgebra.cu
The above files have trailing spaces; please remove them
```

After:

```
$ (! git grep -I -no ' $' -- . ':(exclude)**/contrib/**' ':(exclude)third_party' || (echo "The above files have trailing spaces; please remove them"; false))
aten/src/ATen/native/cuda/BatchLinearAlgebra.cu:1972:
The above files have trailing spaces; please remove them
```

Reviewed By: mruberry

Differential Revision: D26953538

Pulled By: samestep

fbshipit-source-id: 5f7d48b79f1a02e5e5a09fe00316ec350cfc340e
@mruberry mruberry deleted the trailing_whitespace branch May 1, 2021 23:57
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 24, 2026
Summary:
Fixes

```
Run (! git grep -I -l ' $' -- . ':(exclude)**/contrib/**' ':(exclude)third_party' || (echo "The above files have trailing spaces; please remove them"; false))
aten/src/ATen/native/cuda/BatchLinearAlgebra.cu
The above files have trailing spaces; please remove them
Error: Process completed with exit code 1.
```

Pull Request resolved: pytorch#53728

Reviewed By: ngimel

Differential Revision: D26953099

Pulled By: mruberry

fbshipit-source-id: 5f1ed2cd767de49447fcbd8e03cb3af7841cbcaf
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 24, 2026
Summary:
Meant to make tasks like pytorch#53728 easier. The `-n` flag enables line numbers, and the `-o` flag reduces noise by only showing the part of the line that matched (which in this case is just the trailing whitespace).

Pull Request resolved: pytorch#53733

Test Plan:
```
$ git checkout 6d7f62f
```

Before:
```
$ (! git grep -I -l ' $' -- . ':(exclude)**/contrib/**' ':(exclude)third_party' || (echo "The above files have trailing spaces; please remove them"; false))
aten/src/ATen/native/cuda/BatchLinearAlgebra.cu
The above files have trailing spaces; please remove them
```

After:

```
$ (! git grep -I -no ' $' -- . ':(exclude)**/contrib/**' ':(exclude)third_party' || (echo "The above files have trailing spaces; please remove them"; false))
aten/src/ATen/native/cuda/BatchLinearAlgebra.cu:1972:
The above files have trailing spaces; please remove them
```

Reviewed By: mruberry

Differential Revision: D26953538

Pulled By: samestep

fbshipit-source-id: 5f7d48b79f1a02e5e5a09fe00316ec350cfc340e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants