[quant][graphmode][fx] Fix a condition check for CopyNode#53585
Closed
jerryzh168 wants to merge 3 commits intogh/jerryzh168/569/basefrom
Closed
[quant][graphmode][fx] Fix a condition check for CopyNode#53585jerryzh168 wants to merge 3 commits intogh/jerryzh168/569/basefrom
jerryzh168 wants to merge 3 commits intogh/jerryzh168/569/basefrom
Conversation
Summary: Previously fp16_static CopyNode would be marked as unquantized because of an incorrect condition check of whether a Node is statically quantized or not. This PR fixes that. Test Plan: Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
Contributor
💊 CI failures summary and remediationsAs of commit 0898a9e (more details on the Dr. CI page):
🕵️ 1 new failure recognized by patternsThe following CI failures do not appear to be due to upstream breakages:
|
| Job | Step | Action |
|---|---|---|
| Run tests | 🔁 rerun |
This comment was automatically generated by Dr. CI (expand for details).
Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group.
vkuzo
approved these changes
Mar 9, 2021
Summary: Previously fp16_static CopyNode would be marked as unquantized because of an incorrect condition check of whether a Node is statically quantized or not. This PR fixes that. Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D26912677](https://our.internmc.facebook.com/intern/diff/D26912677) [ghstack-poisoned]
Summary: Previously fp16_static CopyNode would be marked as unquantized because of an incorrect condition check of whether a Node is statically quantized or not. This PR fixes that. Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D26912677](https://our.internmc.facebook.com/intern/diff/D26912677) [ghstack-poisoned]
Contributor
|
This pull request has been merged in 7484c56. |
xsacha
pushed a commit
to xsacha/pytorch
that referenced
this pull request
Mar 31, 2021
) Summary: Pull Request resolved: pytorch#53585 Previously fp16_static CopyNode would be marked as unquantized because of an incorrect condition check of whether a Node is statically quantized or not. This PR fixes that. Test Plan: Imported from OSS Reviewed By: vkuzo Differential Revision: D26912677 fbshipit-source-id: 4ddb538714c5ba2db28430de5e1cf2931baf1993
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
) Summary: Pull Request resolved: pytorch#53585 Previously fp16_static CopyNode would be marked as unquantized because of an incorrect condition check of whether a Node is statically quantized or not. This PR fixes that. Test Plan: Imported from OSS Reviewed By: vkuzo Differential Revision: D26912677 fbshipit-source-id: 4ddb538714c5ba2db28430de5e1cf2931baf1993
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary:
Previously fp16_static CopyNode would be marked as unquantized because of
an incorrect condition check of whether a Node is statically quantized or not.
This PR fixes that.
Test Plan:
Reviewers:
Subscribers:
Tasks:
Tags:
Differential Revision: D26912677