[TestZeroRedundancyOptimizer] Add multi gpu checker#53564
Closed
jaglinux wants to merge 1 commit intopytorch:masterfrom
Closed
[TestZeroRedundancyOptimizer] Add multi gpu checker#53564jaglinux wants to merge 1 commit intopytorch:masterfrom
jaglinux wants to merge 1 commit intopytorch:masterfrom
Conversation
The test test_collect_shards fails on single GPU setup. Enabling the multi gpu checker. Signed-off-by: Jagadish Krishnamoorthy <jagdish.krishna@gmail.com>
Contributor
💊 CI failures summary and remediationsAs of commit 4b0df0b (more details on the Dr. CI page):
ci.pytorch.org: 1 failedThis comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
Contributor
Author
Codecov Report
@@ Coverage Diff @@
## master #53564 +/- ##
==========================================
- Coverage 77.64% 77.22% -0.43%
==========================================
Files 1869 1869
Lines 182321 182321
==========================================
- Hits 141570 140793 -777
- Misses 40751 41528 +777 |
rohan-varma
approved these changes
Mar 10, 2021
Contributor
rohan-varma
left a comment
There was a problem hiding this comment.
Thanks! Rocm failure is test_reference_numerics_normal_tanh_cuda_complex64, looks unrelated
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@rohan-varma has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Collaborator
Yes, test is unrelated. A different PR made ROCm changes and was merged before passing CI. It has since been reverted. But I'd rather not go through a rebase and prolong this current PR landing. |
Contributor
|
@jeffdaily sounds good I'm landing the PR shortly. |
Contributor
|
@rohan-varma merged this pull request in 2cf9098. |
xsacha
pushed a commit
to xsacha/pytorch
that referenced
this pull request
Mar 31, 2021
Summary: The test test_collect_shards fails on single GPU setup. Enabling the multi gpu checker. Signed-off-by: Jagadish Krishnamoorthy <jagdish.krishna@gmail.com> Pull Request resolved: pytorch#53564 Reviewed By: H-Huang Differential Revision: D26952325 Pulled By: rohan-varma fbshipit-source-id: e8956f9277c7320024bece129767e83fbdf02b2c
malfet
pushed a commit
that referenced
this pull request
Mar 4, 2022
…zer.test_collect_shards` (#72923) * [TestZeroRedundancyOptimizer] Add multi gpu checker (#53564) Summary: The test test_collect_shards fails on single GPU setup. Enabling the multi gpu checker. Signed-off-by: Jagadish Krishnamoorthy <jagdish.krishna@gmail.com> Pull Request resolved: #53564 Reviewed By: H-Huang Differential Revision: D26952325 Pulled By: rohan-varma fbshipit-source-id: e8956f9277c7320024bece129767e83fbdf02b2c * fix skip_if_not_multigpu Co-authored-by: Jagadish Krishnamoorthy <jagdish.krishna@gmail.com>
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
Summary: The test test_collect_shards fails on single GPU setup. Enabling the multi gpu checker. Signed-off-by: Jagadish Krishnamoorthy <jagdish.krishna@gmail.com> Pull Request resolved: pytorch#53564 Reviewed By: H-Huang Differential Revision: D26952325 Pulled By: rohan-varma fbshipit-source-id: e8956f9277c7320024bece129767e83fbdf02b2c
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test test_collect_shards fails on single GPU setup.
Enabling the multi gpu checker.
Signed-off-by: Jagadish Krishnamoorthy jagdish.krishna@gmail.com