[testing] assert no duplicate in method_tests for an OpInfo entry#53492
[testing] assert no duplicate in method_tests for an OpInfo entry#53492kshitij12345 wants to merge 6 commits intopytorch:masterfrom
Conversation
💊 CI failures summary and remediationsAs of commit 102e20c (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
| # Verifies that ops do not have an entry in | ||
| # `method_tests` (legacy testing infra). | ||
| @onlyCPU | ||
| @ops(op_db, allowed_dtypes=[torch.float32]) |
There was a problem hiding this comment.
Smart implementation to support skips so this PR doesn't have to update all the sample inputs, too. If there were no skips then this could probably just compare the op_db and method_tests() directly.
mruberry
left a comment
There was a problem hiding this comment.
Smart work, @kshitij12345. Let's just wait for tests.
|
Note: Failures look irrelevant :) |
facebook-github-bot
left a comment
There was a problem hiding this comment.
@mruberry has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
Unfortunately this picked up a merge conflict, likely from the out= update :(. Sorry about that @kshitij12345 -- would you rebase this, please? |
|
@mruberry No worries :) Thanks for the heads-up |
| skips=( | ||
| # `test_duplicate_method_tests` doesn't raise any warning, as it doesn't actually | ||
| # call the operator. | ||
| SkipInfo('TestOpInfo', 'test_duplicate_method_tests'),), |
There was a problem hiding this comment.
@mruberry, think there is a nicer way to avoid the skip?
There was a problem hiding this comment.
No, this seems fine, although it is a humorous niche interaction.
facebook-github-bot
left a comment
There was a problem hiding this comment.
@mruberry has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
Unfortunately our internal tools were unable to merge this properly; sorry about that @kshitij12345. Would you please rebase this? |
Codecov Report
@@ Coverage Diff @@
## master #53492 +/- ##
==========================================
- Coverage 77.34% 77.14% -0.20%
==========================================
Files 1887 1887
Lines 184777 184777
==========================================
- Hits 142918 142551 -367
- Misses 41859 42226 +367 |
facebook-github-bot
left a comment
There was a problem hiding this comment.
@mruberry has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
…torch#53492) Summary: Assert no duplicate in method_tests for an OpInfo entry Pull Request resolved: pytorch#53492 Reviewed By: izdeby Differential Revision: D26882441 Pulled By: mruberry fbshipit-source-id: f0631ea2b46b74285c76365c679bd45abc917d63
…torch#53492) Summary: Assert no duplicate in method_tests for an OpInfo entry Pull Request resolved: pytorch#53492 Reviewed By: izdeby Differential Revision: D26882441 Pulled By: mruberry fbshipit-source-id: f0631ea2b46b74285c76365c679bd45abc917d63
Assert no duplicate in method_tests for an OpInfo entry