Clean up future imports for Python 2#53349
Clean up future imports for Python 2#53349skyline75489 wants to merge 1 commit intopytorch:masterfrom skyline75489:chesterliu/dev/cleanup-future
Conversation
💊 CI failures summary and remediationsAs of commit 550c7db (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
Codecov Report
@@ Coverage Diff @@
## master #53349 +/- ##
==========================================
- Coverage 78.07% 78.07% -0.01%
==========================================
Files 1852 1852
Lines 181145 181144 -1
==========================================
- Hits 141435 141420 -15
- Misses 39710 39724 +14 |
|
@bugra Can you take a look? 😄 |
facebook-github-bot
left a comment
There was a problem hiding this comment.
@bugra has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
Looks good to me! |
|
@skyline75489 Is there anything left over for Python 2? Thanks for doing this! |
|
@bugra I think there are still things left to be done, especially things that are hidden in the logic (for example #42919 (comment) ). It would be more trivial to find and clean them but I'll give it a try when I got the time 😃 |
Summary: See pytorch#42919 Pull Request resolved: pytorch#53349 Reviewed By: malfet Differential Revision: D27039089 Pulled By: bugra fbshipit-source-id: 8063dc184248604506a8dbb1bcb73da8ec85bb18
Summary: See pytorch#42919 Pull Request resolved: pytorch#53349 Reviewed By: malfet Differential Revision: D27039089 Pulled By: bugra fbshipit-source-id: 8063dc184248604506a8dbb1bcb73da8ec85bb18
See #42919