Skip to content

[doc] Fix documentation for tensorsolve#53320

Closed
merajhashemi wants to merge 1 commit intopytorch:masterfrom
merajhashemi:mh-tensorsolve
Closed

[doc] Fix documentation for tensorsolve#53320
merajhashemi wants to merge 1 commit intopytorch:masterfrom
merajhashemi:mh-tensorsolve

Conversation

@merajhashemi
Copy link
Copy Markdown
Contributor

@merajhashemi merajhashemi commented Mar 5, 2021 •
edited
Loading

This PR fixes the explanation of dims in linalg.tensorsolve.

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Mar 5, 2021

Hi @merajhashemi!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Mar 5, 2021 •
edited
Loading

💊 CI failures summary and remediations

As of commit 2d3bb5a (more details on the Dr. CI page):

✅ None of the CI failures appear to be your fault 💚

🚧 2 fixed upstream failures:

These were probably caused by upstream breakages that were already fixed.

Please rebase on the viable/strict branch (expand for instructions)

If your commit is older than viable/strict, run these commands:

git fetch https://github.com/pytorch/pytorch viable/strict
git rebase FETCH_HEAD
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Mar 5, 2021

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@anjali411 anjali411 requested a review from IvanYashchuk March 5, 2021 16:27
@anjali411 anjali411 added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Mar 5, 2021
@anjali411 anjali411 self-requested a review March 5, 2021 16:28
@anjali411
Copy link
Copy Markdown
Contributor

anjali411 commented Mar 5, 2021

@IvanYashchuk could you review this PR?

IvanYashchuk
IvanYashchuk approved these changes Mar 5, 2021
View reviewed changes
Copy link
Copy Markdown
Collaborator

@IvanYashchuk IvanYashchuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@merajhashemi thank you for this fix! Now it is correct.

@merajhashemi
Copy link
Copy Markdown
Contributor Author

merajhashemi commented Mar 13, 2021

@anjali411 Do you think we can merge this?

facebook-github-bot
facebook-github-bot reviewed Mar 15, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anjali411 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@anjali411
Copy link
Copy Markdown
Contributor

anjali411 commented Mar 15, 2021 •
edited
Loading

@anjali411 Do you think we can merge this?

@merajhashemi sorry for the late response. I lost track of this PR until I saw your ping. thanks for the fix!

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Mar 15, 2021

@anjali411 merged this pull request in 7ff4955.

@merajhashemi merajhashemi deleted the mh-tensorsolve branch March 17, 2021 14:05
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 24, 2026
@merajhashemi @facebook-github-bot
[doc] Fix documentation for tensorsolve (pytorch#53320)
5bf4aba 
Summary:
This PR fixes a typo in the explanation of `dims` for `linalg.tensorsolve`.

Pull Request resolved: pytorch#53320

Reviewed By: jbschlosser

Differential Revision: D27048736

Pulled By: anjali411

fbshipit-source-id: db230b21191cc9cfb73b967cd15305fe74178c2b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@IvanYashchuk IvanYashchuk IvanYashchuk approved these changes

@anjali411 anjali411 anjali411 approved these changes

+1 more reviewer

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla signed Merged open source triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@merajhashemi @facebook-github-bot @anjali411 @IvanYashchuk @pytorchbot