Added further automatic IBVERB lib and header check before enabling THD/Gloo IB support#5264
Merged
ezyang merged 2 commits intopytorch:masterfrom Feb 16, 2018
Merged
Added further automatic IBVERB lib and header check before enabling THD/Gloo IB support#5264ezyang merged 2 commits intopytorch:masterfrom
ezyang merged 2 commits intopytorch:masterfrom
Conversation
…HD/Gloo IB support
ezyang
reviewed
Feb 15, 2018
|
|
||
| IS_WINDOWS = (platform.system() == 'Windows') | ||
| IS_WINDOWS = (platform.system() == "Windows") | ||
| IS_CONDA = "conda" in sys.version or "Continuum" in sys.version |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
ezyang
reviewed
Feb 15, 2018
| IB_DEVINFO_CMD = "ibv_devinfo" | ||
|
|
||
|
|
||
| def gather_paths(env_vars): |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
ezyang
reviewed
Feb 15, 2018
| Helper function that detects the system's IB support and returns if we | ||
| should build with IB support. | ||
| """ | ||
| ib_util_found = False |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
ezyang
reviewed
Feb 15, 2018
| "LIBRARY_PATH", | ||
| ]) + gather_paths([ | ||
| "LD_LIBRARY_PATH", | ||
| ]))) |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
ezyang
reviewed
Feb 15, 2018
| for path in lib_paths: | ||
| if path is None or not os.path.exists(path): | ||
| continue | ||
| ib_libraries = sorted(glob.glob(os.path.join(path, "libibverbs*"))) |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Contributor
Author
|
@ezyang refactored :) |
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
…HD/Gloo IB support (pytorch#5264) * Added further automatic IBVERB lib and header check before enabling THD/Gloo IB support * Refectoring and addressed comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing issue:
#5256
In the case when the IB utility is able to run, but Gloo Cmake somehow fails to find IBverb lib/header, the build will fail. We enforce this check at the beginning and will only enable IBVerb build for Gloo if we are able to run IB utility, and also detect IB libs are available.
Tested the build with no problem