[JIT] [Remove Mutation] Add handling of normal_#52175
Closed
eellison wants to merge 3 commits intopytorch:masterfrom
Closed
[JIT] [Remove Mutation] Add handling of normal_#52175eellison wants to merge 3 commits intopytorch:masterfrom
eellison wants to merge 3 commits intopytorch:masterfrom
Conversation
Contributor
💊 CI failures summary and remediationsAs of commit c7d81bf (more details on the Dr. CI page):
1 failure not recognized by patterns:
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
Krovatkin
reviewed
Feb 17, 2021
| // normal(float mean, float std, int[] size, *, Generator? generator=None, | ||
| // ScalarType? dtype=None, Layout? layout=None, Device? device=None, bool? | ||
| // pin_memory=None) -> Tensor | ||
| auto size = graph_->insert(aten::size, {n->inputs().at(0)}); |
Contributor
There was a problem hiding this comment.
Is this transformation always on in RemoveMutation pass? I feel a little bit uneasy seeing how many extra ops we are adding here?
Contributor
Author
There was a problem hiding this comment.
Yes, but RemoveMutation isn't always on anywhere (within JIT)
Contributor
Author
There was a problem hiding this comment.
I opened issue here: #52334. I dont think it should block landing this bug fix.
Closed
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@Krovatkin has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Codecov Report
@@ Coverage Diff @@
## master #52175 +/- ##
==========================================
- Coverage 77.63% 77.63% -0.01%
==========================================
Files 1869 1869
Lines 182394 182407 +13
==========================================
+ Hits 141603 141605 +2
- Misses 40791 40802 +11 |
Contributor
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 10, 2021
xsacha
pushed a commit
to xsacha/pytorch
that referenced
this pull request
Mar 31, 2021
Summary: Fixes pytorch#51735 Pull Request resolved: pytorch#52175 Reviewed By: mrshenli Differential Revision: D26919193 Pulled By: eellison fbshipit-source-id: d036cbc7b42377f88a3d381e4932a710b8d22a04
xsacha
pushed a commit
to xsacha/pytorch
that referenced
this pull request
Mar 31, 2021
Summary: Pull Request resolved: pytorch#53762 Test Plan: CI. Reviewed By: seemethere Differential Revision: D26961133 Pulled By: samestep fbshipit-source-id: 972ea480baa3f34b65327abdf7e8bfdf30788572
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
Summary: Fixes pytorch#51735 Pull Request resolved: pytorch#52175 Reviewed By: mrshenli Differential Revision: D26919193 Pulled By: eellison fbshipit-source-id: d036cbc7b42377f88a3d381e4932a710b8d22a04
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
Summary: Pull Request resolved: pytorch#53762 Test Plan: CI. Reviewed By: seemethere Differential Revision: D26961133 Pulled By: samestep fbshipit-source-id: 972ea480baa3f34b65327abdf7e8bfdf30788572
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #51735