Conversation
…taved/stable_sort_CPU
…taved/stable_sort_CPU
…taved/stable_sort_CPU
|
@glaringlee , hopefully now it could be imported. |
💊 CI failures summary and remediationsAs of commit ba09214 (more details on the Dr. CI page):
ci.pytorch.org: 1 failedThis comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
facebook-github-bot
left a comment
There was a problem hiding this comment.
@glaringlee has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Imported! |
…mmon_methods_invocations.py
facebook-github-bot
left a comment
There was a problem hiding this comment.
@glaringlee has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
glaringlee
left a comment
There was a problem hiding this comment.
@nikitaved This looks good to me now. Please rebase the code, let's get this land.
…taved/stable_sort_CPU_take_2
facebook-github-bot
left a comment
There was a problem hiding this comment.
@glaringlee has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
There was a problem hiding this comment.
@nikitaved Hi, sorry about the last minute change.
This PR broke the Rocm build here:
https://ci.pytorch.org/jenkins/job/pytorch-builds/job/pytorch-linux-bionic-rocm4.0.1-py3.6-test1/246/console (go to the bottom). I commented in the code on how to fix this, please make the change, thanks.
| OpInfo('sort', | ||
| dtypes=all_types_and(torch.bool, torch.float16), | ||
| # sort on CUDA is still in the TH, no torch.bool/torch.float16 support yet | ||
| dtypesIfCUDA=all_types_and(torch.float16), |
There was a problem hiding this comment.
Please add this as well after dtypesIfCUDA
dtypesIfROCM=all_types_and(torch.float16)
…taved/stable_sort_CPU_take_2
facebook-github-bot
left a comment
There was a problem hiding this comment.
@glaringlee has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@nikitaved Can you rebase again? There is a problem with master branch yesterday which broke many CI tests. Thanks a lot. |
…taved/stable_sort_CPU_take_2
facebook-github-bot
left a comment
There was a problem hiding this comment.
@glaringlee has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@glaringlee merged this pull request in 9699c70. |
|
@glaringlee, @mruberry , thank you so much for leading this effort! That was a tough one :) |
Summary: Fixes pytorch#38681. A duplicate of pytorch#50052 created to become importable to the fb internal tests. Pull Request resolved: pytorch#51790 Reviewed By: agolynski Differential Revision: D26279045 Pulled By: glaringlee fbshipit-source-id: 348e171dee9c370a76002b65d0c82c329f57a421
Summary: Fixes pytorch#38681. A duplicate of pytorch#50052 created to become importable to the fb internal tests. Pull Request resolved: pytorch#51790 Reviewed By: agolynski Differential Revision: D26279045 Pulled By: glaringlee fbshipit-source-id: 348e171dee9c370a76002b65d0c82c329f57a421
Summary: Fixes pytorch#38681. A duplicate of pytorch#50052 created to become importable to the fb internal tests. Pull Request resolved: pytorch#51790 Reviewed By: agolynski Differential Revision: D26279045 Pulled By: glaringlee fbshipit-source-id: 348e171dee9c370a76002b65d0c82c329f57a421
Summary: Fixes pytorch#38681. A duplicate of pytorch#50052 created to become importable to the fb internal tests. Pull Request resolved: pytorch#51790 Reviewed By: agolynski Differential Revision: D26279045 Pulled By: glaringlee fbshipit-source-id: 348e171dee9c370a76002b65d0c82c329f57a421
Fixes #38681.
A duplicate of #50052 created to become importable to the fb internal tests.