Skip to content

Warn about floor_divide performing incorrect rounding (#50281)#51745

Closed
mruberry wants to merge 2 commits intopytorch:masterfrom
mruberry:export-D26257855
Closed

Warn about floor_divide performing incorrect rounding (#50281)#51745
mruberry wants to merge 2 commits intopytorch:masterfrom
mruberry:export-D26257855

Conversation

@mruberry
Copy link
Copy Markdown
Collaborator

@mruberry mruberry commented Feb 4, 2021

Summary: Pull Request resolved: #50281

Test Plan: Imported from OSS

Reviewed By: ngimel

Differential Revision: D26257855

Pulled By: mruberry

@peterbell10 @facebook-github-bot
Warn about floor_divide performing incorrect rounding (pytorch#50281)
9f09b27 
Summary: Pull Request resolved: pytorch#50281

Test Plan: Imported from OSS

Reviewed By: ngimel

Differential Revision: D26257855

Pulled By: mruberry

fbshipit-source-id: 3c4a91f97fe99e7f0905212f8a9e188e28130b57
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Feb 4, 2021 •
edited
Loading

💊 CI failures summary and remediations

As of commit f66d6c1 (more details on the Dr. CI page):

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See CircleCI build pytorch_linux_xenial_py3_clang7_onnx_ort_test2 (1/1)

Step: "Run tests" (full log | diagnosis details | 🔁 rerun)

Feb 04 23:30:44 test/onnx/test_pytorch_onnx_onnxruntime.py::TestONNXRuntime_opset10::test_transformer_encoder FAILED [ 94%] 
Feb 04 23:30:42 test/onnx/test_pytorch_onnx_onnxruntime.py::TestONNXRuntime_opset10::test_tensor_index_advanced_indexing_consecutive PASSED [ 92%]
Feb 04 23:30:42 test/onnx/test_pytorch_onnx_onnxruntime.py::TestONNXRuntime_opset10::test_tensor_index_advanced_indexing_ellipsis PASSED [ 92%]
Feb 04 23:30:42 test/onnx/test_pytorch_onnx_onnxruntime.py::TestONNXRuntime_opset10::test_tensor_like_factories_script PASSED [ 92%]
Feb 04 23:30:42 test/onnx/test_pytorch_onnx_onnxruntime.py::TestONNXRuntime_opset10::test_tolist SKIPPED [ 92%]
Feb 04 23:30:42 test/onnx/test_pytorch_onnx_onnxruntime.py::TestONNXRuntime_opset10::test_topk PASSED [ 93%]
Feb 04 23:30:42 test/onnx/test_pytorch_onnx_onnxruntime.py::TestONNXRuntime_opset10::test_topk_script PASSED [ 93%]
Feb 04 23:30:42 test/onnx/test_pytorch_onnx_onnxruntime.py::TestONNXRuntime_opset10::test_topk_smallest_unsorted SKIPPED [ 93%]
Feb 04 23:30:42 test/onnx/test_pytorch_onnx_onnxruntime.py::TestONNXRuntime_opset10::test_torch_mm PASSED [ 93%]
Feb 04 23:30:42 test/onnx/test_pytorch_onnx_onnxruntime.py::TestONNXRuntime_opset10::test_trace_script PASSED [ 93%]
Feb 04 23:30:42 test/onnx/test_pytorch_onnx_onnxruntime.py::TestONNXRuntime_opset10::test_transform_images SKIPPED [ 93%]
Feb 04 23:30:44 test/onnx/test_pytorch_onnx_onnxruntime.py::TestONNXRuntime_opset10::test_transformer_encoder FAILED [ 94%]
Feb 04 23:30:44 test/onnx/test_pytorch_onnx_onnxruntime.py::TestONNXRuntime_opset10::test_transpose_infer_shape PASSED [ 94%]
Feb 04 23:30:44 test/onnx/test_pytorch_onnx_onnxruntime.py::TestONNXRuntime_opset10::test_unbind PASSED [ 94%]
Feb 04 23:30:44 test/onnx/test_pytorch_onnx_onnxruntime.py::TestONNXRuntime_opset10::test_unbind_dynamic SKIPPED [ 94%]
Feb 04 23:30:44 test/onnx/test_pytorch_onnx_onnxruntime.py::TestONNXRuntime_opset10::test_unfold PASSED [ 94%]
Feb 04 23:30:44 test/onnx/test_pytorch_onnx_onnxruntime.py::TestONNXRuntime_opset10::test_unfold_dynamic_inputs SKIPPED [ 94%]
Feb 04 23:30:44 test/onnx/test_pytorch_onnx_onnxruntime.py::TestONNXRuntime_opset10::test_unfold_infer_shape PASSED [ 95%]
Feb 04 23:30:44 test/onnx/test_pytorch_onnx_onnxruntime.py::TestONNXRuntime_opset10::test_uninitialized SKIPPED [ 95%]
Feb 04 23:30:44 test/onnx/test_pytorch_onnx_onnxruntime.py::TestONNXRuntime_opset10::test_uninitialized_dynamic SKIPPED [ 95%]
Feb 04 23:30:44 test/onnx/test_pytorch_onnx_onnxruntime.py::TestONNXRuntime_opset10::test_unique SKIPPED [ 95%]
Feb 04 23:30:44 test/onnx/test_pytorch_onnx_onnxruntime.py::TestONNXRuntime_opset10::test_unique_along_dim SKIPPED [ 95%]

❄️ 1 failure tentatively classified as flaky

but reruns have not yet been triggered to confirm:

See CircleCI build pytorch_linux_xenial_py3_clang7_onnx_ort_test1 (1/1)

Step: "Run tests" (full log | diagnosis details | 🔁 rerun) ❄️

Feb 04 23:28:10 test/onnx/test_pytorch_onnx_onnxruntime.py::TestONNXRuntime_opset7::test_transformer_encoder Fatal Python error: Segmentation fault 
Feb 04 23:28:08 test/onnx/test_pytorch_onnx_onnxruntime.py::TestONNXRuntime_opset7::test_tensor_index_advanced_indexing_consecutive PASSED [  8%]
Feb 04 23:28:08 test/onnx/test_pytorch_onnx_onnxruntime.py::TestONNXRuntime_opset7::test_tensor_index_advanced_indexing_ellipsis PASSED [  8%]
Feb 04 23:28:08 test/onnx/test_pytorch_onnx_onnxruntime.py::TestONNXRuntime_opset7::test_tensor_like_factories_script SKIPPED [  8%]
Feb 04 23:28:08 test/onnx/test_pytorch_onnx_onnxruntime.py::TestONNXRuntime_opset7::test_tolist SKIPPED [  8%]
Feb 04 23:28:08 test/onnx/test_pytorch_onnx_onnxruntime.py::TestONNXRuntime_opset7::test_topk PASSED [  8%]
Feb 04 23:28:08 test/onnx/test_pytorch_onnx_onnxruntime.py::TestONNXRuntime_opset7::test_topk_script SKIPPED [  8%]
Feb 04 23:28:08 test/onnx/test_pytorch_onnx_onnxruntime.py::TestONNXRuntime_opset7::test_topk_smallest_unsorted SKIPPED [  8%]
Feb 04 23:28:08 test/onnx/test_pytorch_onnx_onnxruntime.py::TestONNXRuntime_opset7::test_torch_mm PASSED [  8%]
Feb 04 23:28:08 test/onnx/test_pytorch_onnx_onnxruntime.py::TestONNXRuntime_opset7::test_trace_script SKIPPED [  8%]
Feb 04 23:28:08 test/onnx/test_pytorch_onnx_onnxruntime.py::TestONNXRuntime_opset7::test_transform_images SKIPPED [  8%]
Feb 04 23:28:10 test/onnx/test_pytorch_onnx_onnxruntime.py::TestONNXRuntime_opset7::test_transformer_encoder Fatal Python error: Segmentation fault
Feb 04 23:28:10 
Feb 04 23:28:10 Current thread 0x00007f437e390700 (most recent call first):
Feb 04 23:28:10   File "/opt/conda/lib/python3.6/site-packages/_pytest/_io/saferepr.py", line 58 in repr_instance
Feb 04 23:28:10   File "/opt/conda/lib/python3.6/reprlib.py", line 65 in repr1
Feb 04 23:28:10   File "/opt/conda/lib/python3.6/reprlib.py", line 55 in repr
Feb 04 23:28:10   File "/opt/conda/lib/python3.6/site-packages/_pytest/_io/saferepr.py", line 49 in repr
Feb 04 23:28:10   File "/opt/conda/lib/python3.6/site-packages/_pytest/_io/saferepr.py", line 88 in saferepr
Feb 04 23:28:10   File "/opt/conda/lib/python3.6/site-packages/_pytest/_code/code.py", line 707 in repr_args
Feb 04 23:28:10   File "/opt/conda/lib/python3.6/site-packages/_pytest/_code/code.py", line 797 in repr_traceback_entry
Feb 04 23:28:10   File "/opt/conda/lib/python3.6/site-packages/_pytest/_code/code.py", line 846 in repr_traceback
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Feb 4, 2021

This pull request was exported from Phabricator. Differential Revision: D26257855

@facebook-github-bot facebook-github-bot added cla signed oncall: jit Add this issue/PR to JIT oncall triage queue labels Feb 4, 2021
@mruberry mruberry mentioned this pull request Feb 4, 2021
Closed
facebook-github-bot
facebook-github-bot reviewed Feb 4, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mruberry has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Feb 10, 2021

@mruberry merged this pull request in 594a66d.

xsacha pushed a commit to xsacha/pytorch that referenced this pull request Mar 31, 2021
Warn about floor_divide performing incorrect rounding (pytorch#50281) (…
39e4cce 
…pytorch#50281)

Summary:
Pull Request resolved: pytorch#50281

Pull Request resolved: pytorch#51745

Test Plan: Imported from OSS

Reviewed By: ngimel

Pulled By: mruberry

Differential Revision: D26257855

fbshipit-source-id: e5d497cf07b0c746838ed081c5d0e82fb4cb701b
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 24, 2026
@facebook-github-bot
Warn about floor_divide performing incorrect rounding (pytorch#50281) (…
c4a2508 
…pytorch#50281)

Summary:
Pull Request resolved: pytorch#50281

Pull Request resolved: pytorch#51745

Test Plan: Imported from OSS

Reviewed By: ngimel

Pulled By: mruberry

Differential Revision: D26257855

fbshipit-source-id: e5d497cf07b0c746838ed081c5d0e82fb4cb701b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla signed fb-exported Merged oncall: jit Add this issue/PR to JIT oncall triage queue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mruberry @facebook-github-bot @peterbell10