[package] make importer a little more obscure#51676
Closed
suo wants to merge 6 commits intogh/suo/392/basefrom
Closed
[package] make importer a little more obscure#51676suo wants to merge 6 commits intogh/suo/392/basefrom
suo wants to merge 6 commits intogh/suo/392/basefrom
Conversation
We offer the ability to access the importer from within packaged modules by doing `import resources`. This behavior is nice (and more powerful than the importlib resources API), but I think `resources` is too common a name (pip has a package for it) Change to `import torch_package_importer` but open to bikeshedding [ghstack-poisoned]
suo
added a commit
that referenced
this pull request
Feb 3, 2021
We offer the ability to access the importer from within packaged modules by doing `import resources`. This behavior is nice (and more powerful than the importlib resources API), but I think `resources` is too common a name (pip has a package for it) Change to `import torch_package_importer` but open to bikeshedding ghstack-source-id: f3de119 Pull Request resolved: #51676
Contributor
💊 CI failures summary and remediationsAs of commit 4b6fe4b (more details on the Dr. CI page):
1 failure not recognized by patterns:
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
zdevito
approved these changes
Feb 16, 2021
We offer the ability to access the importer from within packaged modules by doing `import resources`. This behavior is nice (and more powerful than the importlib resources API), but I think `resources` is too common a name (pip has a package for it) Change to `import torch_package_importer` but open to bikeshedding [ghstack-poisoned]
suo
added a commit
that referenced
this pull request
Feb 23, 2021
We offer the ability to access the importer from within packaged modules by doing `import resources`. This behavior is nice (and more powerful than the importlib resources API), but I think `resources` is too common a name (pip has a package for it) Change to `import torch_package_importer` but open to bikeshedding ghstack-source-id: da7f93b Pull Request resolved: #51676
We offer the ability to access the importer from within packaged modules by doing `import resources`. This behavior is nice (and more powerful than the importlib resources API), but I think `resources` is too common a name (pip has a package for it) Change to `import torch_package_importer` but open to bikeshedding Differential Revision: [D26620314](https://our.internmc.facebook.com/intern/diff/D26620314) [ghstack-poisoned]
suo
added a commit
that referenced
this pull request
Mar 2, 2021
We offer the ability to access the importer from within packaged modules by doing `import resources`. This behavior is nice (and more powerful than the importlib resources API), but I think `resources` is too common a name (pip has a package for it) Change to `import torch_package_importer` but open to bikeshedding ghstack-source-id: 75ba56b Pull Request resolved: #51676
We offer the ability to access the importer from within packaged modules by doing `import resources`. This behavior is nice (and more powerful than the importlib resources API), but I think `resources` is too common a name (pip has a package for it) Change to `import torch_package_importer` but open to bikeshedding Differential Revision: [D26620314](https://our.internmc.facebook.com/intern/diff/D26620314) [ghstack-poisoned]
We offer the ability to access the importer from within packaged modules by doing `import resources`. This behavior is nice (and more powerful than the importlib resources API), but I think `resources` is too common a name (pip has a package for it) Change to `import torch_package_importer` but open to bikeshedding Differential Revision: [D26620314](https://our.internmc.facebook.com/intern/diff/D26620314) [ghstack-poisoned]
suo
added a commit
that referenced
this pull request
Mar 10, 2021
We offer the ability to access the importer from within packaged modules by doing `import resources`. This behavior is nice (and more powerful than the importlib resources API), but I think `resources` is too common a name (pip has a package for it) Change to `import torch_package_importer` but open to bikeshedding ghstack-source-id: d21913d Pull Request resolved: #51676
We offer the ability to access the importer from within packaged modules by doing `import resources`. This behavior is nice (and more powerful than the importlib resources API), but I think `resources` is too common a name (pip has a package for it) Change to `import torch_package_importer` but open to bikeshedding Differential Revision: [D26620314](https://our.internmc.facebook.com/intern/diff/D26620314) [ghstack-poisoned]
suo
added a commit
that referenced
this pull request
Mar 10, 2021
We offer the ability to access the importer from within packaged modules by doing `import resources`. This behavior is nice (and more powerful than the importlib resources API), but I think `resources` is too common a name (pip has a package for it) Change to `import torch_package_importer` but open to bikeshedding ghstack-source-id: cf4d82c Pull Request resolved: #51676
Contributor
xsacha
pushed a commit
to xsacha/pytorch
that referenced
this pull request
Mar 31, 2021
Summary: Pull Request resolved: pytorch#51676 We offer the ability to access the importer from within packaged modules by doing `import resources`. This behavior is nice (and more powerful than the importlib resources API), but I think `resources` is too common a name (pip has a package for it) Change to `import torch_package_importer` but open to bikeshedding Test Plan: Imported from OSS Reviewed By: jamesr66a Differential Revision: D26620314 Pulled By: suo fbshipit-source-id: 0942c99f02c0f55f5f3a1b2566961018b796bdd4
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
Summary: Pull Request resolved: pytorch#51676 We offer the ability to access the importer from within packaged modules by doing `import resources`. This behavior is nice (and more powerful than the importlib resources API), but I think `resources` is too common a name (pip has a package for it) Change to `import torch_package_importer` but open to bikeshedding Test Plan: Imported from OSS Reviewed By: jamesr66a Differential Revision: D26620314 Pulled By: suo fbshipit-source-id: 0942c99f02c0f55f5f3a1b2566961018b796bdd4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
get_resource_readerAPI #51674 [package] implementget_resource_readerAPIWe offer the ability to access the importer from within packaged modules by doing
import resources. This behavior is nice (and more powerful than theimportlib resources API), but I think
resourcesis too common a name(pip has a package for it)
Change to
import torch_package_importerbut open to bikesheddingDifferential Revision: D26620314