Added missing VSX dispatch for cholesky_inverse#51562
Closed
IvanYashchuk wants to merge 1 commit intopytorch:masterfrom
Closed
Added missing VSX dispatch for cholesky_inverse#51562IvanYashchuk wants to merge 1 commit intopytorch:masterfrom
IvanYashchuk wants to merge 1 commit intopytorch:masterfrom
Conversation
Contributor
💊 CI failures summary and remediationsAs of commit 1409695 (more details on the Dr. CI page):
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
Contributor
|
Thanks @IvanYashchuk for the rapid response! |
anjali411
approved these changes
Feb 2, 2021
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@anjali411 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Codecov Report
@@ Coverage Diff @@
## master #51562 +/- ##
=======================================
Coverage 80.87% 80.87%
=======================================
Files 1942 1942
Lines 211446 211446
=======================================
+ Hits 171006 171014 +8
+ Misses 40440 40432 -8 |
Contributor
|
@anjali411 merged this pull request in 4746b3d. |
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
Summary: It was overlooked that vsx dispatch is also needed for cholesky_inverse cpu dispatch. See pytorch#50269 (comment) Pull Request resolved: pytorch#51562 Reviewed By: H-Huang Differential Revision: D26199581 Pulled By: anjali411 fbshipit-source-id: 5d02c6da52ce1d2e9e26001f5d4648a71dd0e829
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was overlooked that vsx dispatch is also needed for cholesky_inverse cpu dispatch.
See #50269 (comment)