Skip to content

[complex] Enable complex autograd and jit tests for trace#51537

Closed
kshitij12345 wants to merge 2 commits intopytorch:masterfrom
kshitij12345:complex/autograd/trace
Closed

[complex] Enable complex autograd and jit tests for trace#51537
kshitij12345 wants to merge 2 commits intopytorch:masterfrom
kshitij12345:complex/autograd/trace

Conversation

@kshitij12345
Copy link
Copy Markdown
Collaborator

Fixes #50381

Now that index_fill_ supports complex, we can enable complex support for trace.

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Feb 2, 2021

💊 CI failures summary and remediations

As of commit 0aac060 (more details on the Dr. CI page):


  • 1/1 failures possibly* introduced in this PR
    • 1/1 non-CircleCI failure(s)

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

@kshitij12345 kshitij12345 marked this pull request as ready for review February 2, 2021 08:39
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 2, 2021

Codecov Report

Merging #51537 (0aac060) into master (b6c6fb7) will increase coverage by 12.84%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master   #51537       +/-   ##
===========================================
+ Coverage   68.02%   80.87%   +12.84%     
===========================================
  Files        1786     1943      +157     
  Lines      179793   211583    +31790     
===========================================
+ Hits       122307   171121    +48814     
+ Misses      57486    40462    -17024     

@anjali411 anjali411 added complex_autograd module: complex Related to complex number support in PyTorch labels Feb 2, 2021
Copy link
Copy Markdown
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anjali411 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Copy link
Copy Markdown
Contributor

@anjali411 anjali411 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome! thanks @kshitij12345 :D

Copy link
Copy Markdown
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anjali411 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Copy Markdown
Contributor

@anjali411 merged this pull request in 38eb836.

laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 24, 2026
…51537)

Summary:
Fixes pytorch#50381

Now that `index_fill_` supports complex, we can enable complex support for `trace`.

Pull Request resolved: pytorch#51537

Reviewed By: H-Huang

Differential Revision: D26198904

Pulled By: anjali411

fbshipit-source-id: d62bb02549919fe35b0bac44f77af964ebd0e92e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

trace_backward does not work for complex tensors

4 participants