OpInfo: Added clamp and trunc tests with aliases by vfdev-5 · Pull Request #51167 · pytorch/pytorch

vfdev-5 · 2021-01-27T00:48:21Z

Description:

Added clamp, trunc tests with aliases
Added tests for aliases for asin(h), acos(h), etc
fixed 'fix' alias implementation
fixed annotations in test_jit_alias_remapping
updated native_functions.yaml aliases guidelines

Blocked by #50368

cc @mruberry

Context: pytorch#49158

…stCommon

…opinfo-aliases

- jit_name_remapping instead jit consistency - removed auto generated tests for abs - added aliases tests inside test_variant_consistency_eager - added aliases tests to test_out

- added jit scripting in test_jit_alias_remapping - etc

facebook-github-bot · 2021-01-27T00:48:51Z

💊 CI failures summary and remediations

As of commit 37d9b64 (more details on the Dr. CI page):

1/1 failures possibly* introduced in this PR
- 1/1 non-CircleCI failure(s)

This comment was automatically generated by Dr. CI (expand for details).

Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

mruberry · 2021-01-27T17:13:37Z

This looks good. It should also cleanup the clamp metadata here:

pytorch/test/test_torch.py

Line 6617 in 0b5303e

    
           ('clamp', 'neg', _medium_2d, lambda t, d: [-1, 5], 1e-5, 1e-2, 1e-5, _signed_types, [torch.bfloat16]),

and the trunc metadata here:

pytorch/test/test_torch.py

Line 6855 in 0b5303e

    
           ('trunc', '', _small_3d, lambda t, d: [], 1e-5, 1e-2, 1e-5, _float_types, [torch.bfloat16]),

and here:

pytorch/torch/testing/_internal/common_methods_invocations.py

Line 2133 in 0b5303e

('trunc', (S, S, S), NO_ARGS, '', (True,)),

mruberry · 2021-01-27T17:14:59Z

Most test failures are in base and should be fixed if this rebases. The clamp failures like this are real, though:

test_batch_vs_slicing_clamp_cpu_int16 - TestUnaryUfuncsCPU
test_unary_ufuncs.py

Traceback (most recent call last):
  File "/Users/distiller/workspace/miniconda3/lib/python3.7/site-packages/torch/testing/_internal/common_device_type.py", line 295, in instantiated_test
    raise rte
  File "/Users/distiller/workspace/miniconda3/lib/python3.7/site-packages/torch/testing/_internal/common_device_type.py", line 290, in instantiated_test
    result = test_fn(self, *args)
  File "/Users/distiller/workspace/miniconda3/lib/python3.7/site-packages/torch/testing/_internal/common_device_type.py", line 268, in test_wrapper
    return test(*args, **kwargs)
  File "test_unary_ufuncs.py", line 400, in test_batch_vs_slicing
    actual = op(input)
  File "/Users/distiller/workspace/miniconda3/lib/python3.7/site-packages/torch/testing/_internal/common_methods_invocations.py", line 217, in __call__
    return self.op(*args, **kwargs)
RuntimeError: At least one of 'min' or 'max' must not be None

Should be an easy fix.

mruberry · 2021-01-27T18:12:03Z

And these can be removed, too:

pytorch/test/test_unary_ufuncs.py

Line 1685 in 4a2aa0f

_TorchMathTestMeta('trunc'),

pytorch/test/test_unary_ufuncs.py

Line 1698 in 4a2aa0f

    
           _TorchMathTestMeta('abs', input_fn=_medium_2d, dtypes=_types_no_half, rtol=0., atol=0.),

- fixed 'fix' alias implementation - fixed annotations in test_jit_alias_remapping

…-more-aliases

codecov · 2021-02-02T23:04:45Z

Codecov Report

Merging #51167 (37d9b64) into master (8f0968f) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master   #51167   +/-   ##
=======================================
  Coverage   80.87%   80.87%           
=======================================
  Files        1943     1943           
  Lines      211510   211520   +10     
=======================================
+ Hits       171056   171075   +19     
+ Misses      40454    40445    -9

mruberry · 2021-02-03T06:54:07Z

Looking good, @vfdev-5, I made just a few comments inline!

- added code explanation - more inputs for clamp

mruberry

Great attention to detail, removal of legacy tests, and an awesome fix for fix! Thanks @vfdev-5!

facebook-github-bot

@mruberry has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

facebook-github-bot · 2021-02-10T15:16:22Z

@mruberry merged this pull request in 8b0cb5e.

Summary: Description: - Added clamp, trunc tests with aliases - Added tests for aliases for asin(h), acos(h), etc - fixed 'fix' alias implementation - fixed annotations in test_jit_alias_remapping - updated native_functions.yaml aliases guidelines Blocked by pytorch#50368 cc mruberry Pull Request resolved: pytorch#51167 Reviewed By: gchanan Differential Revision: D26245753 Pulled By: mruberry fbshipit-source-id: e17b657f0515139735a8a677b1ae284904f98aef

vfdev-5 and others added 12 commits January 11, 2021 04:51

Introduced AliasInfo for OpInfo

c21bfe0

Context: pytorch#49158

Merge branch 'master' into add-opinfo-aliases

b6ce6bf

Added arcsin alias, added abs UnaryUfuncInfo

e4cde50

[WIP] Added test_aliases_consistency_eager/jit methods to test_ops.Te…

65b39de

…stCommon

Merge branch 'master' of https://github.com/pytorch/pytorch into add-…

b2917b5

…opinfo-aliases

Fixed test_aliases_consistency_jit

4134a45

Merge branch 'master' into add-opinfo-aliases

b1c225c

Fixed failing tests

306420b

Merge branch 'master' of https://github.com/pytorch/pytorch into add-…

159fc21

…opinfo-aliases

Updated code according to PR's review

00f7dfb

- jit_name_remapping instead jit consistency - removed auto generated tests for abs - added aliases tests inside test_variant_consistency_eager - added aliases tests to test_out

Fixed typing issue by ignoring the type

e699695

Updates according to the review

38cab9f

- added jit scripting in test_jit_alias_remapping - etc

facebook-github-bot added the cla signed label Jan 27, 2021

pytorchbot added the open source label Jan 27, 2021

vfdev-5 and others added 2 commits January 27, 2021 22:35

Merge branch 'master' into add-opinfo-aliases

38bed6c

Added clamp and trunc ops with aliases

74d14a0

- fixed 'fix' alias implementation - fixed annotations in test_jit_alias_remapping

vfdev-5 mentioned this pull request Jan 27, 2021

[tests][UnaryUfuncInfo] Improve TestUnaryUfuncs for ops with args/kwargs #51242

Closed

Removed generated tests according to the review

2c30e63

vfdev-5 force-pushed the port-more-aliases branch from edca24a to 2c30e63 Compare January 27, 2021 22:44

mruberry mentioned this pull request Jan 28, 2021

[testing] Add OpInfo for round and logit #51272

Closed

ailzhang requested a review from mruberry January 29, 2021 04:10

ailzhang added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Jan 29, 2021

vfdev-5 and others added 4 commits February 2, 2021 02:52

Merge branch 'master' of https://github.com/pytorch/pytorch into port…

b3d9111

…-more-aliases

Merge branch 'master' of https://github.com/pytorch/pytorch into port…

5cc078c

…-more-aliases

Fixes mypy

f4c96f5

Merge branch 'master' into port-more-aliases

e1fdaeb

mruberry reviewed Feb 3, 2021

View reviewed changes

Comment thread torch/testing/_internal/common_methods_invocations.py

mruberry reviewed Feb 3, 2021

View reviewed changes

Comment thread torch/testing/_internal/common_methods_invocations.py

mruberry reviewed Feb 3, 2021

View reviewed changes

Comment thread test/test_ops.py

vfdev-5 added 2 commits February 3, 2021 05:22

Fixes according to the review

8e32eed

- added code explanation - more inputs for clamp

Removed already covered test cases

37d9b64

mruberry self-requested a review February 4, 2021 04:50

mruberry approved these changes Feb 4, 2021

View reviewed changes

facebook-github-bot reviewed Feb 4, 2021

View reviewed changes

facebook-github-bot closed this in 8b0cb5e Feb 10, 2021

vfdev-5 deleted the port-more-aliases branch February 10, 2021 14:05

facebook-github-bot added the Merged label Feb 10, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

OpInfo: Added clamp and trunc tests with aliases#51167

OpInfo: Added clamp and trunc tests with aliases#51167
vfdev-5 wants to merge 21 commits intopytorch:masterfrom
Quansight:port-more-aliases

vfdev-5 commented Jan 27, 2021 •

edited

Loading

Uh oh!

facebook-github-bot commented Jan 27, 2021 •

edited

Loading

Uh oh!

mruberry commented Jan 27, 2021

Uh oh!

mruberry commented Jan 27, 2021

Uh oh!

mruberry commented Jan 27, 2021

Uh oh!

codecov Bot commented Feb 2, 2021 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mruberry commented Feb 3, 2021

Uh oh!

mruberry left a comment

Uh oh!

facebook-github-bot left a comment

Uh oh!

facebook-github-bot commented Feb 10, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

vfdev-5 commented Jan 27, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

facebook-github-bot commented Jan 27, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💊 CI failures summary and remediations

Uh oh!

mruberry commented Jan 27, 2021

Uh oh!

mruberry commented Jan 27, 2021

Uh oh!

mruberry commented Jan 27, 2021

Uh oh!

codecov Bot commented Feb 2, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mruberry commented Feb 3, 2021

Uh oh!

mruberry left a comment

Choose a reason for hiding this comment

Uh oh!

facebook-github-bot left a comment

Choose a reason for hiding this comment

Uh oh!

facebook-github-bot commented Feb 10, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

vfdev-5 commented Jan 27, 2021 •

edited

Loading

facebook-github-bot commented Jan 27, 2021 •

edited

Loading

codecov Bot commented Feb 2, 2021 •

edited

Loading